From: Marco Felsch <m.felsch@pengutronix.de>
To: mchehab@kernel.org, rmfrfs@gmail.com, zhengsq@rock-chips.com,
prabhakar.csengg@gmail.com, corbet@lwn.net,
wenyou.yang@microchip.com, lkundrak@v3.sk,
hverkuil-cisco@xs4all.nl, sakari.ailus@linux.intel.com,
jacopo+renesas@jmondi.org
Cc: linux-media@vger.kernel.org, kernel@pengutronix.de
Subject: [PATCH 2/6] media: ov2659: get rid of extra ifdefs
Date: Thu, 4 Apr 2019 09:39:58 +0200 [thread overview]
Message-ID: <20190404074002.18730-3-m.felsch@pengutronix.de> (raw)
In-Reply-To: <20190404074002.18730-1-m.felsch@pengutronix.de>
We can drop the ifdef dance since the v4l2_subdev_get_try_format
return the correct value in both cases with or without
CONFIG_VIDEO_V4L2_SUBDEV_API is enabled.
The patch is based on Lubomir's series [1].
[1] https://patchwork.kernel.org/cover/10703017/
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
drivers/media/i2c/ov2659.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
index 799acce803fe..1c9cbd43f903 100644
--- a/drivers/media/i2c/ov2659.c
+++ b/drivers/media/i2c/ov2659.c
@@ -1046,17 +1046,16 @@ static int ov2659_get_fmt(struct v4l2_subdev *sd,
dev_dbg(&client->dev, "ov2659_get_fmt\n");
if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
-#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API
struct v4l2_mbus_framefmt *mf;
mf = v4l2_subdev_get_try_format(sd, cfg, 0);
+ if (IS_ERR(mf))
+ return PTR_ERR(mf);
+
mutex_lock(&ov2659->lock);
fmt->format = *mf;
mutex_unlock(&ov2659->lock);
return 0;
-#else
- return -ENOTTY;
-#endif
}
mutex_lock(&ov2659->lock);
@@ -1126,12 +1125,12 @@ static int ov2659_set_fmt(struct v4l2_subdev *sd,
mutex_lock(&ov2659->lock);
if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
-#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API
mf = v4l2_subdev_get_try_format(sd, cfg, fmt->pad);
+ if (IS_ERR(mf)) {
+ mutex_unlock(&ov2659->lock);
+ return PTR_ERR(mf);
+ }
*mf = fmt->format;
-#else
- return -ENOTTY;
-#endif
} else {
s64 val;
--
2.20.1
next prev parent reply other threads:[~2019-04-04 7:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 7:39 [PATCH 0/6] Avoid v4l2_subdev_get_try_ ifdef dance Marco Felsch
2019-04-04 7:39 ` [PATCH 1/6] media: v4l2-subdev: add stubs for v4l2_subdev_get_try_* Marco Felsch
2019-04-04 8:39 ` Sakari Ailus
2019-04-04 14:39 ` Jacopo Mondi
2019-04-05 7:26 ` Marco Felsch
2019-05-29 17:45 ` Mauro Carvalho Chehab
2019-04-04 7:39 ` Marco Felsch [this message]
2019-04-04 7:39 ` [PATCH 3/6] media: ov2680: get rid of extra ifdefs Marco Felsch
2019-04-04 7:40 ` [PATCH 4/6] media: ov5695: " Marco Felsch
2019-04-04 7:40 ` [PATCH 5/6] media: ov7670: " Marco Felsch
2019-04-04 7:40 ` [PATCH 6/6] media: ov7740: " Marco Felsch
2019-05-31 11:51 ` [PATCH 0/6] Avoid v4l2_subdev_get_try_ ifdef dance Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404074002.18730-3-m.felsch@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=corbet@lwn.net \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo+renesas@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mchehab@kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=rmfrfs@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=wenyou.yang@microchip.com \
--cc=zhengsq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.