From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69423C4360F for ; Thu, 4 Apr 2019 11:05:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C3C220855 for ; Thu, 4 Apr 2019 11:05:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728762AbfDDLFM (ORCPT ); Thu, 4 Apr 2019 07:05:12 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:50023 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726563AbfDDLFM (ORCPT ); Thu, 4 Apr 2019 07:05:12 -0400 X-Originating-IP: 90.88.30.125 Received: from localhost (aaubervilliers-681-1-89-125.w90-88.abo.wanadoo.fr [90.88.30.125]) (Authenticated sender: maxime.ripard@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id D8ED51BF210; Thu, 4 Apr 2019 11:05:08 +0000 (UTC) Date: Thu, 4 Apr 2019 13:05:08 +0200 From: Maxime Ripard To: Srinivas Kandagatla Cc: Yangtao Li , robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] nvmem: sunxi-sid: add new reg_read func Message-ID: <20190404110508.rbk3z5urndtiqbmq@flea> References: <20190402154514.11284-1-tiny.windzz@gmail.com> <20190402154514.11284-5-tiny.windzz@gmail.com> <7dc60dd9-3bbb-f215-4554-a0051c0cfbfd@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ny7tgfpxvwmv6vfd" Content-Disposition: inline In-Reply-To: <7dc60dd9-3bbb-f215-4554-a0051c0cfbfd@linaro.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ny7tgfpxvwmv6vfd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 04, 2019 at 11:59:44AM +0100, Srinivas Kandagatla wrote: > > > On 02/04/2019 16:45, Yangtao Li wrote: > > Because there was an endianness issue. It seems that reg_read > > function which the nvmem the driver currently exposes is wrong. > > So add the new read function, the new function is used when the > > native_endian flag is set. > > > > Signed-off-by: Yangtao Li > > This patch and 5/5 does not apply cleanly on nvmem-next. > Also I would need an ack from Maxime to be able to apply it. Chen-Yu has mostly been taking care of this recently, so I'd like his feedback on this. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ny7tgfpxvwmv6vfd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXKXk5AAKCRDj7w1vZxhR xTuEAQDJYNsyUIVjp1/OIKiaTRqefwV1Kzo8JrfqXvqyq3DWnQD9GRUbaA8kkh5q 19AYo+3YuKFkWdfrbe2rIgGkpRfMyAo= =d7g+ -----END PGP SIGNATURE----- --ny7tgfpxvwmv6vfd-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65BA1C4360F for ; Thu, 4 Apr 2019 11:05:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32B28206DF for ; Thu, 4 Apr 2019 11:05:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y2D1zvRi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32B28206DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jxP2kR0ZDxVExZehNLsHtaw0kZ4qgNQXt95LchCFMsE=; b=Y2D1zvRibctMnX2N6TgcPZEoN 06Kbsm8WXHcltJAuyNSO6WcFnJN1ewVIYw7eHCOOPbfWeuSyOqe7WuT4Qs6PAO7vQtt8UfIGntdme evwjUlUWcBT7hWoYCRZwU2F0Abpt+iiCX7rYYN/lam/15gdiOEAk2TMgU4BcUAjCrqt8v4DT7B5bo y0CPyGc7Ol3+Whpr+JPB8EoQb333ubT+ckXsi2JsxWRffJkD3NbzPtHnWYgz7EiK5mTRmYqQ0+cXd ayLvRTKxbdFl8HlKimT+Eobx7jGsC20+uS4pkWpzybo02fA7OB0A+/cDtXbfIRgBpHNZ7he6D/iT/ J4bBY96Yw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hC0BM-0008PW-C3; Thu, 04 Apr 2019 11:05:20 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hC0BI-0008Ig-Fo for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2019 11:05:18 +0000 X-Originating-IP: 90.88.30.125 Received: from localhost (aaubervilliers-681-1-89-125.w90-88.abo.wanadoo.fr [90.88.30.125]) (Authenticated sender: maxime.ripard@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id D8ED51BF210; Thu, 4 Apr 2019 11:05:08 +0000 (UTC) Date: Thu, 4 Apr 2019 13:05:08 +0200 From: Maxime Ripard To: Srinivas Kandagatla Subject: Re: [PATCH v2 4/5] nvmem: sunxi-sid: add new reg_read func Message-ID: <20190404110508.rbk3z5urndtiqbmq@flea> References: <20190402154514.11284-1-tiny.windzz@gmail.com> <20190402154514.11284-5-tiny.windzz@gmail.com> <7dc60dd9-3bbb-f215-4554-a0051c0cfbfd@linaro.org> MIME-Version: 1.0 In-Reply-To: <7dc60dd9-3bbb-f215-4554-a0051c0cfbfd@linaro.org> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190404_040516_679993_8DBE8E7E X-CRM114-Status: GOOD ( 13.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, Yangtao Li , linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============5104066303094450984==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5104066303094450984== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ny7tgfpxvwmv6vfd" Content-Disposition: inline --ny7tgfpxvwmv6vfd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 04, 2019 at 11:59:44AM +0100, Srinivas Kandagatla wrote: > > > On 02/04/2019 16:45, Yangtao Li wrote: > > Because there was an endianness issue. It seems that reg_read > > function which the nvmem the driver currently exposes is wrong. > > So add the new read function, the new function is used when the > > native_endian flag is set. > > > > Signed-off-by: Yangtao Li > > This patch and 5/5 does not apply cleanly on nvmem-next. > Also I would need an ack from Maxime to be able to apply it. Chen-Yu has mostly been taking care of this recently, so I'd like his feedback on this. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ny7tgfpxvwmv6vfd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXKXk5AAKCRDj7w1vZxhR xTuEAQDJYNsyUIVjp1/OIKiaTRqefwV1Kzo8JrfqXvqyq3DWnQD9GRUbaA8kkh5q 19AYo+3YuKFkWdfrbe2rIgGkpRfMyAo= =d7g+ -----END PGP SIGNATURE----- --ny7tgfpxvwmv6vfd-- --===============5104066303094450984== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5104066303094450984==--