From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support Date: Thu, 4 Apr 2019 13:24:15 +0200 Message-ID: <20190404112415.GB18653@amd> References: <20190308203801.57920-1-ncrews@chromium.org> <20190308210843.GA16125@amd> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LpQ9ahxlCli8rRTG" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Nick Crews Cc: Enric Balletbo i Serra , Benson Leung , linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com, linux-kernel , Duncan Laurie , Daniel Erat , Guenter Roeck , Dmitry Torokhov List-Id: linux-leds@vger.kernel.org --LpQ9ahxlCli8rRTG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2019-03-11 09:29:06, Nick Crews wrote: > Thanks for looking this over. I will fix most of your concerns, but > have one question. >=20 > On Fri, Mar 8, 2019 at 2:08 PM Pavel Machek wrote: > > > > On Fri 2019-03-08 13:38:02, Nick Crews wrote: > > > This patch is meant to be applied on top of the for-next > > > branch of the platform/chrome repository, as it uses some of > > > the code staged there. > > > > > > The EC is in charge of controlling the keyboard backlight on > > > the Wilco platform. We expose a standard LED class device at > > > /sys/class/leds/wilco::kbd_backlight. This driver is modeled > > > after the standard Chrome OS keyboard backlight driver at > > > drivers/platform/chrome/cros_kbd_led_backlight.c > > > > Can you make it "platform::kbd_backlight"? We want some consistency > > there. >=20 > The analogous name in the standard driver > drivers/platform/chrome/cros_kbd_led_backlight.c is > "chromeos::kbd_backlight", and I thought "wilco" was a better > substitute for "chromeos" than "platform" would be. What other thing > are you saying "platform" would be consistent with? Yeah, well, we not let the cros_kbd_led_backlight.c use chromeos:: in the first place. But it happened. We want all backlights for the system keyboard to use common name, and "chromeos" is not really suitable for that. "platform" is. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --LpQ9ahxlCli8rRTG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlyl6V8ACgkQMOfwapXb+vLF+gCglhx7EadWK3nlJphDZ1ubCXLD FnkAoKcA8GDxGY39W8axiHo5p9J505A7 =TBrn -----END PGP SIGNATURE----- --LpQ9ahxlCli8rRTG--