From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C474C4360F for ; Thu, 4 Apr 2019 12:24:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF650206DD for ; Thu, 4 Apr 2019 12:24:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="NoHbjUCQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729847AbfDDMYa (ORCPT ); Thu, 4 Apr 2019 08:24:30 -0400 Received: from mail.skyhub.de ([5.9.137.197]:38804 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727562AbfDDMY2 (ORCPT ); Thu, 4 Apr 2019 08:24:28 -0400 Received: from zn.tnic (p200300EC2F148A00329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2f14:8a00:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 1F72F1EC064E; Thu, 4 Apr 2019 14:24:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1554380667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=uZTXvTLGkLDqy3CIH4NGp3FIe5g/vVod/lzgCt4u3cU=; b=NoHbjUCQbyNtqSuNHrljUOdUzT68sCf6L7MJQS5vd1Wv1KBzSY8FR0Q1Ws3v2jFskbzDdi 7G849nGI0/pNc2Mh6ijhDP2AGisy1gLgsRcRp1F+CtvCNCzDr8cIMZm0yCCSPUOXUsEqtX OHLsGgwFNXWo4eOZ26cPzhxXaWAIIB4= Date: Thu, 4 Apr 2019 14:24:25 +0200 From: Borislav Petkov To: Dave Young Cc: Junichi Nomura , "bhe@redhat.com" , "fanc.fnst@cn.fujitsu.com" , "x86@kernel.org" , "kexec@lists.infradead.org" , "kasong@redhat.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Message-ID: <20190404122425.GC22539@zn.tnic> References: <20190325123229.GL12016@zn.tnic> <20190325231000.GA9184@jeru.linux.bs1.fc.nec.co.jp> <20190326135714.GG1867@zn.tnic> <20190327014852.GA3659@MiWiFi-R3L-srv> <73322ba9-e436-68db-7863-afd31607d969@ce.jp.nec.com> <20190328064343.GA1877@MiWiFi-R3L-srv> <20190328074337.GA9470@jeru.linux.bs1.fc.nec.co.jp> <20190328155256.GP22720@zn.tnic> <20190402102529.GA21698@jeru.linux.bs1.fc.nec.co.jp> <20190404073233.GC5708@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190404073233.GC5708@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 04, 2019 at 03:32:33PM +0800, Dave Young wrote: > BTW, it would be good to start a new thread when you send V4 :) Yes please. > > + /* Get systab from boot params. */ > > + systab = (efi_system_table_64_t *) (ei->efi_systab | ((__u64)ei->efi_systab_hi << 32)); > > + if (!systab) > > + error("EFI system table not found in kexec boot_params."); > > Instead of hang the system, return 0 should be better Can the kexec kernel even function if we fail here? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.skyhub.de ([2a01:4f8:190:11c2::b:1457]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hC1Px-0002nq-8m for kexec@lists.infradead.org; Thu, 04 Apr 2019 12:24:31 +0000 Date: Thu, 4 Apr 2019 14:24:25 +0200 From: Borislav Petkov Subject: Re: [PATCH v3] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Message-ID: <20190404122425.GC22539@zn.tnic> References: <20190325123229.GL12016@zn.tnic> <20190325231000.GA9184@jeru.linux.bs1.fc.nec.co.jp> <20190326135714.GG1867@zn.tnic> <20190327014852.GA3659@MiWiFi-R3L-srv> <73322ba9-e436-68db-7863-afd31607d969@ce.jp.nec.com> <20190328064343.GA1877@MiWiFi-R3L-srv> <20190328074337.GA9470@jeru.linux.bs1.fc.nec.co.jp> <20190328155256.GP22720@zn.tnic> <20190402102529.GA21698@jeru.linux.bs1.fc.nec.co.jp> <20190404073233.GC5708@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190404073233.GC5708@dhcp-128-65.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Dave Young Cc: "x86@kernel.org" , "kasong@redhat.com" , "bhe@redhat.com" , "fanc.fnst@cn.fujitsu.com" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Junichi Nomura On Thu, Apr 04, 2019 at 03:32:33PM +0800, Dave Young wrote: > BTW, it would be good to start a new thread when you send V4 :) Yes please. > > + /* Get systab from boot params. */ > > + systab = (efi_system_table_64_t *) (ei->efi_systab | ((__u64)ei->efi_systab_hi << 32)); > > + if (!systab) > > + error("EFI system table not found in kexec boot_params."); > > Instead of hang the system, return 0 should be better Can the kexec kernel even function if we fail here? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec