From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75574C4360F for ; Thu, 4 Apr 2019 12:42:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46DBF206C0 for ; Thu, 4 Apr 2019 12:42:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729581AbfDDMmG (ORCPT ); Thu, 4 Apr 2019 08:42:06 -0400 Received: from mga09.intel.com ([134.134.136.24]:23989 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728858AbfDDMmF (ORCPT ); Thu, 4 Apr 2019 08:42:05 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2019 05:42:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,308,1549958400"; d="scan'208";a="139949362" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.143]) by orsmga003.jf.intel.com with ESMTP; 04 Apr 2019 05:42:01 -0700 Date: Thu, 4 Apr 2019 15:42:01 +0300 From: Jarkko Sakkinen To: Matthew Garrett Cc: linux-integrity@vger.kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca, roberto.sassu@huawei.com, linux-efi@vger.kernel.org, tweek@google.com, Matthew Garrett Subject: Re: [PATCH] efi: Include tpm_eventlog.h after asm/efi.h to avoid memcpy breakage Message-ID: <20190404124201.GD14738@linux.intel.com> References: <20190403193238.145204-1-matthewgarrett@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190403193238.145204-1-matthewgarrett@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Wed, Apr 03, 2019 at 12:32:37PM -0700, Matthew Garrett wrote: > 769a8089c1fd2 (x86, efi, kasan: #undef memset/memcpy/memmove per arch) > disables the KASAN version of certain memory calls in the EFI boot stub. > tpm_eventlog.h references memcpy, so must be included after asm/efi.h in > order to allow 769a8089c1fd2 to take effect on its declarations. > > Signed-off-by: Matthew Garrett Reviewed-by: Jarkko Sakkinen /Jarkko