From: kbuild test robot <lkp@intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: Albert Astals Cid <aacid@kde.org>,
intel-gfx@lists.freedesktop.org, Ralgor <ralgorfdb@compuspex.org>,
kbuild-all@01.org, Emanuele Panigati <ilpanich@gmail.com>
Subject: Re: [PATCH] drm/i915/dp: On link train failure on eDP, retry with max params first
Date: Thu, 4 Apr 2019 13:21:32 +0800 [thread overview]
Message-ID: <201904041312.MATlaGbs%lkp@intel.com> (raw)
In-Reply-To: <20190404003826.845-1-manasi.d.navare@intel.com>
[-- Attachment #1: Type: text/plain, Size: 3697 bytes --]
Hi Manasi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v5.1-rc3 next-20190403]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Manasi-Navare/drm-i915-dp-On-link-train-failure-on-eDP-retry-with-max-params-first/20190404-115622
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x006-201913 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/intel_dp.c: In function 'intel_dp_uses_max_link_params':
drivers/gpu/drm/i915/intel_dp.c:466:50: error: parameter name omitted
static bool intel_dp_uses_max_link_params(struct intel_dp*,
^~~~~~~~
drivers/gpu/drm/i915/intel_dp.c:470:22: error: 'intel_dp' undeclared (first use in this function)
return link_rate == intel_dp->max_link_rate &&
^~~~~~~~
drivers/gpu/drm/i915/intel_dp.c:470:22: note: each undeclared identifier is reported only once for each function it appears in
drivers/gpu/drm/i915/intel_dp.c: In function 'intel_dp_get_link_train_fallback_values':
>> drivers/gpu/drm/i915/intel_dp.c:484:7: error: the address of 'intel_dp_uses_max_link_params' will always evaluate as 'true' [-Werror=address]
if (!intel_dp_uses_max_link_params) {
^
drivers/gpu/drm/i915/intel_dp.c:486:4: error: implicit declaration of function 'DRM_DEBUGS_KMS'; did you mean 'DRM_DEBUG_KMS'? [-Werror=implicit-function-declaration]
DRM_DEBUGS_KMS("Retrying Link training for eDP with max link parameters\n");
^~~~~~~~~~~~~~
DRM_DEBUG_KMS
cc1: all warnings being treated as errors
vim +484 drivers/gpu/drm/i915/intel_dp.c
465
> 466 static bool intel_dp_uses_max_link_params(struct intel_dp*,
467 int link_rate,
468 u8 lane_count)
469 {
470 return link_rate == intel_dp->max_link_rate &&
471 lane_count == intel_dp->max_link_lane_count;
472 }
473
474 int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
475 int link_rate, u8 lane_count)
476 {
477 int index;
478
479 index = intel_dp_rate_index(intel_dp->common_rates,
480 intel_dp->num_common_rates,
481 link_rate);
482
483 if (intel_dp_is_edp(intel_dp)) {
> 484 if (!intel_dp_uses_max_link_params) {
485 intel_dp->retry_with_max_link_params = true;
486 DRM_DEBUGS_KMS("Retrying Link training for eDP with max link parameters\n");
487 return 0;
488 } else if (!intel_dp_can_link_train_fallback_for_edp(intel_dp,
489 intel_dp->common_rates[index - 1],
490 lane_count)) {
491 DRM_DEBUG_KMS("Retrying Link training for eDP with same parameters\n");
492 return 0;
493 }
494 }
495 if (index > 0) {
496 intel_dp->max_link_rate = intel_dp->common_rates[index - 1];
497 intel_dp->max_link_lane_count = lane_count;
498 } else if (lane_count > 1) {
499 intel_dp->max_link_rate = intel_dp_max_common_rate(intel_dp);
500 intel_dp->max_link_lane_count = lane_count >> 1;
501 } else {
502 DRM_ERROR("Link Training Unsuccessful\n");
503 return -1;
504 }
505
506 return 0;
507 }
508
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32405 bytes --]
[-- Attachment #3: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-04-04 5:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 0:38 [PATCH] drm/i915/dp: On link train failure on eDP, retry with max params first Manasi Navare
2019-04-04 0:53 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-04-04 5:18 ` [PATCH] " kbuild test robot
2019-04-04 5:21 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201904041312.MATlaGbs%lkp@intel.com \
--to=lkp@intel.com \
--cc=aacid@kde.org \
--cc=ilpanich@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kbuild-all@01.org \
--cc=manasi.d.navare@intel.com \
--cc=ralgorfdb@compuspex.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.