Re: [PATCH] build: don't mandate availability of a fetcher program

[Wei Liu <wei.liu2@citrix.com>]

On Thu, Mar 14, 2019 at 02:08:47PM +0000, Wei Liu wrote:
> It is common that build hosts are isolated from outside world. They
> don't necessarily have wget or ftp installed.
> 
> Turn the error into warning in configure. And point FETCHER to `false'
> command if neither wget nor ftp is available, so any attempt to
> download will result in error.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Ping?

This one is rather low risk. I intend to commit it if I don't hear back
by next week.

Wei.

> ---
>  m4/fetcher.m4     |  4 +++-
>  stubdom/configure | 46 +++++++++++++++++++++++++++++++++++++++++++++-
>  tools/configure   | 46 +++++++++++++++++++++++++++++++++++++++++++++-
>  3 files changed, 93 insertions(+), 3 deletions(-)
> 
> diff --git a/m4/fetcher.m4 b/m4/fetcher.m4
> index 86f33b3937..c1a72c189c 100644
> --- a/m4/fetcher.m4
> +++ b/m4/fetcher.m4
> @@ -1,5 +1,6 @@
>  AC_DEFUN([AX_CHECK_FETCHER], [
>  AC_PATH_PROG([WGET],[wget], [no])
> +AC_PATH_PROG([FALSE],[false], [/bin/false])
>  AS_IF([test x"$WGET" != x"no"], [
>      FETCHER="$WGET -c -O"
>  ], [
> @@ -7,7 +8,8 @@ AS_IF([test x"$WGET" != x"no"], [
>      AS_IF([test x"$FTP" != x"no"], [
>          FETCHER="$FTP -o"
>      ], [
> -        AC_MSG_ERROR([cannot find wget or ftp])
> +        FETCHER="$FALSE"
> +        AC_MSG_WARN([cannot find wget or ftp])
>      ])
>  ])
>  AC_SUBST(FETCHER)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel