All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Song Liu <songliubraving@fb.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Andi Kleen <andi@firstfloor.org>,
	"jolsa@kernel.org" <jolsa@kernel.org>,
	"namhyung@kernel.org" <namhyung@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-perf-users@vger.kernel.org"
	<linux-perf-users@vger.kernel.org>,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [BUG] perf: intel_pt won't display kernel function
Date: Thu, 4 Apr 2019 19:38:04 +0200	[thread overview]
Message-ID: <20190404173804.GB16733@krava> (raw)
In-Reply-To: <678C87FF-A33E-477C-94C1-533026400B95@fb.com>

On Thu, Apr 04, 2019 at 05:08:55PM +0000, Song Liu wrote:
> 
> 
> > On Apr 4, 2019, at 5:25 AM, Jiri Olsa <jolsa@redhat.com> wrote:
> > 
> > On Thu, Apr 04, 2019 at 11:14:38AM +0200, Jiri Olsa wrote:
> > 
> > SNIP
> > 
> >> Program received signal SIGABRT, Aborted.
> >> 0x00007ffff75e60f5 in raise () from /lib64/libc.so.6
> >> Missing separate debuginfos, use: dnf debuginfo-install bzip2-libs-1.0.6-29.fc30.x86_64 elfutils-libelf-0.176-1.fc30.x86_64 elfutils-libs-0.176-1.fc30.x86_64 libgcc-9.0.1-0.10.fc30.x86_64 libunwind-1.3.1-2.fc30.x86_64 libxcrypt-4.4.4-2.fc30.x86_64 numactl-libs-2.0.12-2.fc30.x86_64 perl-libs-5.28.1-434.fc30.x86_64 python2-libs-2.7.16-1.fc30.x86_64 slang-2.3.2-5.fc30.x86_64 xz-libs-5.2.4-5.fc30.x86_64 zlib-1.2.11-15.fc30.x86_64
> >> (gdb) bt
> >> #0  0x00007ffff75e60f5 in raise () from /lib64/libc.so.6
> >> #1  0x00007ffff75d0895 in abort () from /lib64/libc.so.6
> >> #2  0x00007ffff75d0769 in __assert_fail_base.cold () from /lib64/libc.so.6
> >> #3  0x00007ffff75de596 in __assert_fail () from /lib64/libc.so.6
> >> #4  0x00000000004fc006 in refcount_sub_and_test (i=1, r=0x1224e88) at /home/jolsa/linux/tools/include/linux/refcount.h:131
> >> #5  refcount_dec_and_test (r=0x1224e88) at /home/jolsa/linux/tools/include/linux/refcount.h:148
> >> #6  map__put (map=0x1224df0) at util/map.c:299
> >> #7  0x00000000004fdb95 in __maps__remove (map=0x1224df0, maps=0xb17d80) at util/map.c:953
> >> #8  maps__remove (maps=0xb17d80, map=0x1224df0) at util/map.c:959
> >> #9  0x00000000004f7d8a in map_groups__remove (map=<optimized out>, mg=<optimized out>) at util/map_groups.h:65
> >> #10 machine__process_ksymbol_unregister (sample=<optimized out>, event=0x7ffff7279670, machine=<optimized out>) at util/machine.c:728
> >> #11 machine__process_ksymbol (machine=<optimized out>, event=0x7ffff7279670, sample=<optimized out>) at util/machine.c:741
> >> #12 0x00000000004fffbb in perf_session__deliver_event (session=0xb11390, event=0x7ffff7279670, tool=0x7fffffffc7b0, file_offset=13936) at util/session.c:1362
> >> #13 0x00000000005039bb in do_flush (show_progress=false, oe=0xb17e80) at util/ordered-events.c:243
> >> #14 __ordered_events__flush (oe=0xb17e80, how=OE_FLUSH__ROUND, timestamp=<optimized out>) at util/ordered-events.c:322
> >> #15 0x00000000005005e4 in perf_session__process_user_event (session=session@entry=0xb11390, event=event@entry=0x7ffff72a4af8,
> >>    file_offset=file_offset@entry=191224) at util/session.c:1402
> >> #16 0x000000000050091e in perf_session__process_event (file_offset=191224, event=0x7ffff72a4af8, session=0xb11390) at util/session.c:1529
> >> #17 process_simple (session=session@entry=0xb11390, event=event@entry=0x7ffff72a4af8, file_offset=file_offset@entry=191224) at util/session.c:1962
> >> #18 0x0000000000501f44 in reader__process_events (prog=0x7fffffffc680, session=0xb11390, rd=<synthetic pointer>) at util/session.c:1931
> >> #19 __perf_session__process_events (session=0xb11390) at util/session.c:1985
> >> #20 perf_session__process_events (session=0xb11390) at util/session.c:2018
> >> #21 0x000000000045bb42 in __cmd_script (script=0x7fffffffc7b0) at builtin-script.c:2429
> >> #22 cmd_script (argc=<optimized out>, argv=<optimized out>) at builtin-script.c:3770
> >> #23 0x00000000004a65cb in run_builtin (p=p@entry=0x994918 <commands+408>, argc=argc@entry=4, argv=argv@entry=0x7fffffffe160) at perf.c:303
> >> #24 0x000000000042da1e in handle_internal_command (argv=0x7fffffffe160, argc=4) at perf.c:355
> >> #25 run_argv (argcp=<synthetic pointer>, argv=<synthetic pointer>) at perf.c:399
> >> #26 main (argc=4, argv=0x7fffffffe160) at perf.c:521
> > 
> 
> For some reason, I cannot repro this issue. I tried to load two
> bpf programs with same name, but that doesn't trigger it either. 

for some reason I see multiple same name of bpf programs
on my setup.. need to check for the reason

> 
> 
> > 
> > we dont increase the map's reference for same name,
> > which we need to.. I assume we we re able to hit this
> > path with bpf maps/dso with same name
> > 
> > jirka
> 
> Does the following change fix the issue on your side?

yes, I'll post full patch later

jirka

  reply	other threads:[~2019-04-04 17:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 14:37 [BUG] perf: intel_pt won't display kernel function Jiri Olsa
2019-04-03 14:53 ` Arnaldo Carvalho de Melo
2019-04-03 15:15   ` Arnaldo Carvalho de Melo
2019-04-03 16:27     ` Song Liu
2019-04-03 18:50       ` Arnaldo Carvalho de Melo
2019-04-03 18:55         ` Song Liu
2019-04-03 18:59           ` Song Liu
2019-04-03 21:48             ` Song Liu
2019-04-04  9:14               ` Jiri Olsa
2019-04-04 12:25                 ` Jiri Olsa
2019-04-04 17:08                   ` Song Liu
2019-04-04 17:38                     ` Jiri Olsa [this message]
2019-04-03 17:05 ` Song Liu
2019-04-03 18:10   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190404173804.GB16733@krava \
    --to=jolsa@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=arnaldo.melo@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.