From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79900C4360F for ; Thu, 4 Apr 2019 19:09:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51CB32075E for ; Thu, 4 Apr 2019 19:09:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730095AbfDDTJH (ORCPT ); Thu, 4 Apr 2019 15:09:07 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:37960 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729848AbfDDTJG (ORCPT ); Thu, 4 Apr 2019 15:09:06 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 5BB1D20025; Thu, 4 Apr 2019 21:09:00 +0200 (CEST) Date: Thu, 4 Apr 2019 21:08:58 +0200 From: Sam Ravnborg To: Joe Perches Cc: Guido =?iso-8859-1?Q?G=FCnther?= , Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Kevin Hilman , Manivannan Sadhasivam , Shawn Guo , Jagan Teki , Martin Blumenstingl , Johan Hovold , "David S. Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Nicolas Ferre , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging Message-ID: <20190404190858.GA8008@ravnborg.org> References: <20190403161735.GN5238@ulmo> <1ed5eb3af4df6b2dd1544c7b696e034ed5c94f06.camel@perches.com> <20190404105359.GA8255@bogon.m.sigxcpu.org> <20190404170040.GA23897@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=Wvc7zV2IR4HhXB_Na8QA:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joe. > > > > > > ret = mipi_dsi_dcs_exit_sleep_mode(dsi); > > > if (ret < 0) { > > > - DRM_DEV_ERROR(dev, "Failed to exit sleep mode"); > > > + DRM_DEV_ERROR(dev, "Failed to exit sleep mode\n"); > > > > I was under the impression that newlines was optional these days. > > Should we always use them with logging? > > Yes. > > The general problem is KERN_CONT/pr_cont uses where interleaving > is still possible from multiple threads. > > > I did not find any obvious clues in linux/printk.h > > I'll see about adding something one day to the Documentation. > Likely in coding-style.rst. Thanks for the clarification. A seperate doc on logging would be awesome. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging Date: Thu, 4 Apr 2019 21:08:58 +0200 Message-ID: <20190404190858.GA8008@ravnborg.org> References: <20190403161735.GN5238@ulmo> <1ed5eb3af4df6b2dd1544c7b696e034ed5c94f06.camel@perches.com> <20190404105359.GA8255@bogon.m.sigxcpu.org> <20190404170040.GA23897@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Joe Perches Cc: Mark Rutland , devicetree@vger.kernel.org, Greg Kroah-Hartman , David Airlie , Kevin Hilman , Guido =?iso-8859-1?Q?G=FCnther?= , Johan Hovold , dri-devel@lists.freedesktop.org, Nicolas Ferre , Martin Blumenstingl , Rob Herring , Thierry Reding , Jagan Teki , Manivannan Sadhasivam , Mauro Carvalho Chehab , Shawn Guo , "David S. Miller" , linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org SGkgSm9lLgoKPiA+ID4gIAo+ID4gPiAgCXJldCA9IG1pcGlfZHNpX2Rjc19leGl0X3NsZWVwX21v ZGUoZHNpKTsKPiA+ID4gIAlpZiAocmV0IDwgMCkgewo+ID4gPiAtCQlEUk1fREVWX0VSUk9SKGRl diwgIkZhaWxlZCB0byBleGl0IHNsZWVwIG1vZGUiKTsKPiA+ID4gKwkJRFJNX0RFVl9FUlJPUihk ZXYsICJGYWlsZWQgdG8gZXhpdCBzbGVlcCBtb2RlXG4iKTsKPiA+IAo+ID4gSSB3YXMgdW5kZXIg dGhlIGltcHJlc3Npb24gdGhhdCBuZXdsaW5lcyB3YXMgb3B0aW9uYWwgdGhlc2UgZGF5cy4KPiA+ IFNob3VsZCB3ZSBhbHdheXMgdXNlIHRoZW0gd2l0aCBsb2dnaW5nPwo+IAo+IFllcy4KPiAKPiBU aGUgZ2VuZXJhbCBwcm9ibGVtIGlzIEtFUk5fQ09OVC9wcl9jb250IHVzZXMgd2hlcmUgaW50ZXJs ZWF2aW5nCj4gaXMgc3RpbGwgcG9zc2libGUgZnJvbSBtdWx0aXBsZSB0aHJlYWRzLgo+IAo+ID4g SSBkaWQgbm90IGZpbmQgYW55IG9idmlvdXMgY2x1ZXMgaW4gbGludXgvcHJpbnRrLmgKPiAKPiBJ J2xsIHNlZSBhYm91dCBhZGRpbmcgc29tZXRoaW5nIG9uZSBkYXkgdG8gdGhlIERvY3VtZW50YXRp b24uCj4gTGlrZWx5IGluIGNvZGluZy1zdHlsZS5yc3QuCgpUaGFua3MgZm9yIHRoZSBjbGFyaWZp Y2F0aW9uLgpBIHNlcGVyYXRlIGRvYyBvbiBsb2dnaW5nIHdvdWxkIGJlIGF3ZXNvbWUuCgoJU2Ft Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==