All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/freerdp: add h264 support
Date: Thu, 4 Apr 2019 23:23:01 +0200	[thread overview]
Message-ID: <20190404232301.3250a15d@windsurf> (raw)
In-Reply-To: <20190404130854.18876-1-skif@skif-web.ru>

Hello Alexey,

Thanks for your contribution!

On Thu,  4 Apr 2019 16:08:54 +0300
Alexey Lukyanchuk <skif@skif-web.ru> wrote:

> +config BR2_PACKAGE_FREERDP_H264
> +        bool "h264 support"
> +        depends on BR2_PACKAGE_X264
> +        default y
> +        help
> +                h264 codec support for freerdp
> +

I think we would prefer to handle it like cups or ffmpeg, i.e as
"automatic dependencies", without an explicit Config.in option.

> +ifeq ($(BR2_PACKAGE_FREERDP_H264),y)
> +       FREERDP_CONF_OPTS += -DWITH_GFX_H264=ON
> +       FREERDP_DEPENDENCIES += x264
> +endif

i.e, make this:

ifeq ($(BR2_PACKAGE_X264),y)
FREERDP_CONF_OPTS += -DWITH_GFX_H264=ON
FREERDP_DEPENDENCIES += x264
else
FREERDP_CONF_OPTS += -DWITH_GFX_H264=OFF
endif

Could you rework your patch accordingly and send an updated version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2019-04-04 21:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 13:08 [Buildroot] [PATCH 1/1] package/freerdp: add h264 support Alexey Lukyanchuk
2019-04-04 21:23 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190404232301.3250a15d@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.