From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC343C4360F for ; Fri, 5 Apr 2019 14:11:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A73DC21852 for ; Fri, 5 Apr 2019 14:11:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="o3SWFO7r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731247AbfDEOLH (ORCPT ); Fri, 5 Apr 2019 10:11:07 -0400 Received: from mail-eopbgr40083.outbound.protection.outlook.com ([40.107.4.83]:7662 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726594AbfDEOLH (ORCPT ); Fri, 5 Apr 2019 10:11:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KvRMccKVNHCl4gbGfzGS1mDI2bgwFVE0+8bKwxbIMQU=; b=o3SWFO7rSjzUTLnPSc9weNRJmnZqlv6WNwovtK5jGMjI+nE8aQvPmLVYmrXsGVPG8G0OQHTfFgz0dF6ImoL4SryhwhyqVruw7AThBJA1eCWKBmQRfPTR0t4/7Xmv6OEVmMQ5KZ//DuaC4cJxvFuDZDxgB9qNPDXBb1DLKxINnz8= Received: from VI1PR05MB6111.eurprd05.prod.outlook.com (20.178.204.213) by VI1PR05MB4925.eurprd05.prod.outlook.com (20.177.51.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16; Fri, 5 Apr 2019 14:11:04 +0000 Received: from VI1PR05MB6111.eurprd05.prod.outlook.com ([fe80::28c7:8df1:920b:ee0e]) by VI1PR05MB6111.eurprd05.prod.outlook.com ([fe80::28c7:8df1:920b:ee0e%5]) with mapi id 15.20.1771.016; Fri, 5 Apr 2019 14:11:04 +0000 From: Ido Schimmel To: David Ahern CC: "davem@davemloft.net" , "netdev@vger.kernel.org" , Jiri Pirko , David Ahern Subject: Re: [PATCH net-next 08/18] ipv4: Refactor fib_check_nh Thread-Topic: [PATCH net-next 08/18] ipv4: Refactor fib_check_nh Thread-Index: AQHU6w7Vc952yEbZxUm8Zruf4mVZHKYtnKuA Date: Fri, 5 Apr 2019 14:11:03 +0000 Message-ID: <20190405141059.GC18494@splinter> References: <20190404175007.8150-1-dsahern@kernel.org> <20190404175007.8150-9-dsahern@kernel.org> In-Reply-To: <20190404175007.8150-9-dsahern@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6P191CA0031.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::44) To VI1PR05MB6111.eurprd05.prod.outlook.com (2603:10a6:803:eb::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [79.176.7.115] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b7f6bb5c-7671-47ff-e5ea-08d6b9d0891e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:VI1PR05MB4925; x-ms-traffictypediagnostic: VI1PR05MB4925: x-microsoft-antispam-prvs: x-forefront-prvs: 0998671D02 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(376002)(346002)(396003)(39860400002)(366004)(136003)(199004)(189003)(3846002)(6116002)(6436002)(6486002)(6246003)(386003)(6506007)(66066001)(102836004)(76176011)(5660300002)(53936002)(9686003)(106356001)(105586002)(6512007)(6916009)(4326008)(229853002)(7736002)(305945005)(33656002)(68736007)(33716001)(25786009)(316002)(81166006)(81156014)(256004)(486006)(11346002)(476003)(97736004)(54906003)(2906002)(86362001)(446003)(478600001)(14454004)(4744005)(1076003)(71190400001)(71200400001)(8936002)(99286004)(186003)(8676002)(26005)(52116002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB4925;H:VI1PR05MB6111.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: s++vlZC8NY8oFc80AWIWvet25mXfgR6NH+0Rw5yQ7Vd3poscqTR25JElf3LCHZsTrg3cE18ThNARFlBb5ov0DGu/xyPNSo4drN9zlujrmiC2VUGs5JrjkcdamcK8uhp5k/4LI8A66LwFuv26YHnjWIDQ0P+BM0X/YoLypUWlKWfsIjYS5g9LR8p9Jt7iMoyS2annn4szpZMFZv+tLUeDGuLpk+3JYx2s6ioiM7vJtegScBAWRcbwZbKDTIH1dip7EJwjV7+pa8CX+b/FzF9D2VAUkhuHcDhL8IFN408iiPTUcqvVOjovlhEJDv937p46npaP0C3AXn4rT2FjjX+CC8QJwP9xjB5CIjrqXGFc3T4hw6Ve9r1Rl1I3ylSYeSFvauBymBQjf8P2Ho5R9FHvQmDzFxf3FCRdOSxkWN4U8mA= Content-Type: text/plain; charset="us-ascii" Content-ID: <29DA9A0252F57144B15F53AF7C384620@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7f6bb5c-7671-47ff-e5ea-08d6b9d0891e X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2019 14:11:04.0845 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB4925 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 04, 2019 at 10:49:57AM -0700, David Ahern wrote: > From: David Ahern >=20 > fib_check_nh is currently huge covering multiple uses cases - device only= , > device + gateway, and device + gateway with ONLINK. The next patch adds > validation checks for IPv6 which only further complicates it. So, break > fib_check_nh into 2 helpers - one for gateway validation and one for devi= ce > only. >=20 > Signed-off-by: David Ahern Reviewed-by: Ido Schimmel