From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v5 3/3] drm/i915/icl: Fix clockgating issue
 when using scalers
Date: Fri, 5 Apr 2019 18:07:00 +0300
Message-ID: <20190405150700.GL3888@intel.com>
References: <20190315221838.22444-1-radhakrishna.sripada@intel.com>
 <20190330011921.10397-3-radhakrishna.sripada@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 4026089DEA
 for <intel-gfx@lists.freedesktop.org>; Fri,  5 Apr 2019 15:07:04 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190330011921.10397-3-radhakrishna.sripada@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBNYXIgMjksIDIwMTkgYXQgMDY6MTk6MjFQTSAtMDcwMCwgUmFkaGFrcmlzaG5hIFNy
aXBhZGEgd3JvdGU6Cj4gRml4ZXMgdGhlIGNsb2NrLWdhdGluZyBpc3N1ZSB3aGVuIHBpcGUgc2Nh
bGluZyBpcyBlbmFibGVkLgo+IChMaW5lYWdlICMyMDA2NjA0MzEyKQo+IAo+IFYyOiBGaXggdHlw
byBpbiBoZWFkbGluZShDaHJpcykKPiAgICAgSGFuZGxlIHRoZSBub24gZG91YmxlIGJ1ZmZlcmVk
IG5hdHVyZSBvZiB0aGUgcmVnaXN0ZXIoVmlsbGUpCj4gVjM6IEZpeCBjaGVja3BhdGNoIHdhcm5p
bmcuIEJBVCBmYWlsdXJlIGZvciBWMiBvbiBnZW4zIGxvb2tzIHVucmVsYXRlZC4KPiBWNDogU3Bs
aXQgdGhlIGljbCBhbmQgc2tsIHdhJ3MoVmlsbGUpCj4gVjU6IFNwbGl0IHRoZSBjaGVja3MgZm9y
IGljbCBhbmQgc2tsKFZpbGxlKQo+IAo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp
bHNvbi5jby51az4KPiBDYzogVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl
bC5jb20+Cj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiBDYzog
QWRpdHlhIFN3YXJ1cCA8YWRpdHlhLnN3YXJ1cEBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTog
UmFkaGFrcmlzaG5hIFNyaXBhZGEgPHJhZGhha3Jpc2huYS5zcmlwYWRhQGludGVsLmNvbT4KPiAt
LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNDEgKysrKysrKysr
KysrKysrKysrKysrKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMzUgaW5zZXJ0aW9ucygrKSwg
NiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5k
ZXggZjU0MTgzNzYxYTQwLi42MWJkZWYxYjE5YTEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZGlzcGxheS5jCj4gQEAgLTQ2Niw2ICs0NjYsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGlu
dGVsX2xpbWl0IGludGVsX2xpbWl0c19ieHQgPSB7Cj4gIAkucDIgPSB7IC5wMl9zbG93ID0gMSwg
LnAyX2Zhc3QgPSAyMCB9LAo+ICB9Owo+ICAKPiArLyogV0EgRGlzcGxheSAjMDgyNzogR2VuOTph
bGwgKi8KPiAgc3RhdGljIHZvaWQKPiAgc2tsX3dhXzgyNyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0
ZSAqZGV2X3ByaXYsIGludCBwaXBlLCBib29sIGVuYWJsZSkKPiAgewo+IEBAIC00NzksNiArNDgw
LDE4IEBAIHNrbF93YV84Mjcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBpbnQg
cGlwZSwgYm9vbCBlbmFibGUpCj4gIAkJCSAgIH4oRFVQUzFfR0FUSU5HX0RJUyB8IERVUFMyX0dB
VElOR19ESVMpKTsKPiAgfQo+ICAKPiArLyogV2FfMjAwNjYwNDMxMjppY2wgKi8KPiArc3RhdGlj
IHZvaWQKPiAraWNsX3dhX3NjYWxlcmNsa2dhdGluZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq
ZGV2X3ByaXYsIGludCBwaXBlLCBib29sIGVuYWJsZSkKPiArewo+ICsJaWYgKGVuYWJsZSkKPiAr
CQlJOTE1X1dSSVRFKENMS0dBVEVfRElTX1BTTChwaXBlKSwKPiArCQkJICAgSTkxNV9SRUFEKENM
S0dBVEVfRElTX1BTTChwaXBlKSkgfCBEUEZSX0dBVElOR19ESVMpOwo+ICsJZWxzZQo+ICsJCUk5
MTVfV1JJVEUoQ0xLR0FURV9ESVNfUFNMKHBpcGUpLAo+ICsJCQkgICBJOTE1X1JFQUQoQ0xLR0FU
RV9ESVNfUFNMKHBpcGUpKSAmIH5EUEZSX0dBVElOR19ESVMpOwo+ICt9Cj4gKwo+ICBzdGF0aWMg
Ym9vbAo+ICBuZWVkc19tb2Rlc2V0KGNvbnN0IHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqc3RhdGUp
Cj4gIHsKPiBAQCAtNTQ5NSw2ICs1NTA4LDE2IEBAIHN0YXRpYyBib29sIG5lZWRzX252MTJfd2Eo
c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJcmV0dXJuIGZhbHNlOwo+ICB9
Cj4gIAo+ICtzdGF0aWMgYm9vbCBuZWVkc19zY2FsZXJjbGtfd2Eoc3RydWN0IGRybV9pOTE1X3By
aXZhdGUgKmRldl9wcml2LAo+ICsJCQkgICAgICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3Rh
dGUgKmNydGNfc3RhdGUpCj4gK3sKPiArCS8qIFdhXzIwMDY2MDQzMTI6aWNsICovCj4gKwlpZiAo
Y3J0Y19zdGF0ZS0+cGNoX3BmaXQuZW5hYmxlZCAmJiBJU19JQ0VMQUtFKGRldl9wcml2KSkKPiAr
CQlyZXR1cm4gdHJ1ZTsKPiArCj4gKwlyZXR1cm4gZmFsc2U7Cj4gK30KPiArCj4gIHN0YXRpYyB2
b2lkIGludGVsX3Bvc3RfcGxhbmVfdXBkYXRlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRf
Y3J0Y19zdGF0ZSkKPiAgewo+ICAJc3RydWN0IGludGVsX2NydGMgKmNydGMgPSB0b19pbnRlbF9j
cnRjKG9sZF9jcnRjX3N0YXRlLT5iYXNlLmNydGMpOwo+IEBAIC01NTI4LDExICs1NTUxLDEzIEBA
IHN0YXRpYyB2b2lkIGludGVsX3Bvc3RfcGxhbmVfdXBkYXRlKHN0cnVjdCBpbnRlbF9jcnRjX3N0
YXRlICpvbGRfY3J0Y19zdGF0ZSkKPiAgCQkJaW50ZWxfcG9zdF9lbmFibGVfcHJpbWFyeSgmY3J0
Yy0+YmFzZSwgcGlwZV9jb25maWcpOwo+ICAJfQo+ICAKPiAtCS8qIERpc3BsYXkgV0EgODI3ICov
Cj4gIAlpZiAobmVlZHNfbnYxMl93YShkZXZfcHJpdiwgb2xkX2NydGNfc3RhdGUpICYmCj4gLQkg
ICAgIW5lZWRzX252MTJfd2EoZGV2X3ByaXYsIHBpcGVfY29uZmlnKSkgewo+ICsJICAgICFuZWVk
c19udjEyX3dhKGRldl9wcml2LCBwaXBlX2NvbmZpZykpCj4gIAkJc2tsX3dhXzgyNyhkZXZfcHJp
diwgY3J0Yy0+cGlwZSwgZmFsc2UpOwo+IC0JfQo+ICsKPiArCWlmIChuZWVkc19zY2FsZXJjbGtf
d2EoZGV2X3ByaXYsIG9sZF9jcnRjX3N0YXRlKSAmJgo+ICsJICAgICFuZWVkc19zY2FsZXJjbGtf
d2EoZGV2X3ByaXYsIHBpcGVfY29uZmlnKSkKPiArCQlpY2xfd2Ffc2NhbGVyY2xrZ2F0aW5nKGRl
dl9wcml2LCBjcnRjLT5waXBlLCBmYWxzZSk7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIGludGVs
X3ByZV9wbGFuZV91cGRhdGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRl
LAo+IEBAIC01NTY4LDEwICs1NTkzLDE0IEBAIHN0YXRpYyB2b2lkIGludGVsX3ByZV9wbGFuZV91
cGRhdGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlLAo+ICAJfQo+ICAK
PiAgCS8qIERpc3BsYXkgV0EgODI3ICovCj4gLQlpZiAoIW5lZWRzX252MTJfd2EoZGV2X3ByaXYs
IG9sZF9jcnRjX3N0YXRlKSAmJgo+IC0JICAgIG5lZWRzX252MTJfd2EoZGV2X3ByaXYsIHBpcGVf
Y29uZmlnKSkgewo+ICsJaWYgKG5lZWRzX252MTJfd2EoZGV2X3ByaXYsIG9sZF9jcnRjX3N0YXRl
KSAmJgo+ICsJICAgICFuZWVkc19udjEyX3dhKGRldl9wcml2LCBwaXBlX2NvbmZpZykpCgpUaGVz
ZSBnb3QgZmxpcHBlZCB0aGUgd3Jvbmcgd2F5IGFyb3VuZCBmb3Igc29tZSByZWFzb24uCgo+ICAJ
CXNrbF93YV84MjcoZGV2X3ByaXYsIGNydGMtPnBpcGUsIHRydWUpOwo+IC0JfQo+ICsKPiArCS8q
IFdhXzIwMDY2MDQzMTI6aWNsICovCj4gKwlpZiAobmVlZHNfc2NhbGVyY2xrX3dhKGRldl9wcml2
LCBvbGRfY3J0Y19zdGF0ZSkgJiYKPiArCSAgICAhbmVlZHNfc2NhbGVyY2xrX3dhKGRldl9wcml2
LCBwaXBlX2NvbmZpZykpCgpBbmQgdGhlc2UgbG9vayBmbGlwcGVkIHRvby4KCj4gKwkJaWNsX3dh
X3NjYWxlcmNsa2dhdGluZyhkZXZfcHJpdiwgY3J0Yy0+cGlwZSwgdHJ1ZSk7Cj4gIAo+ICAJLyoK
PiAgCSAqIFZibGFuayB0aW1lIHVwZGF0ZXMgZnJvbSB0aGUgc2hhZG93IHRvIGxpdmUgcGxhbmUg
Y29udHJvbCByZWdpc3Rlcgo+IC0tIAo+IDIuMjAuMC5yYzIuNy5nOTY1Nzk4ZDFmMjk5CgotLSAK
VmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk
ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv
L2ludGVsLWdmeA==