Re: [PATCH RESEND v7 1/2] media: uapi: Add H264 low-level decoder API compound controls.

From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Tomasz Figa <tfiga@chromium.org>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Alexandre Courbot <acourbot@chromium.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Pawel Osciak <posciak@chromium.org>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"list@263.net:IOMMU DRIVERS <iommu@lists.linux-foundation.org>,
	Joerg  Roedel <joro@8bytes.org>,"
	<linux-arm-kernel@lists.infradead.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Jens Kuske <jenskuske@gmail.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Ezequiel Garcia <ezequiel@collabora.com>,
	linux-sunxi <linux-sunxi@googlegroups.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH RESEND v7 1/2] media: uapi: Add H264 low-level decoder API compound controls.
Date: Fri, 5 Apr 2019 17:15:52 +0200	[thread overview]
Message-ID: <20190405151552.biesirbs35uivk7d@flea> (raw)
In-Reply-To: <c3ed6d00bf5642b1524ef4973f2db7ba6759fb6d.camel@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 2308 bytes --]

Hi Nicolas,

On Thu, Apr 04, 2019 at 11:41:13AM -0400, Nicolas Dufresne wrote:
> > > > +    * - __u16
> > > > +      - ``pic_width_in_mbs_minus1``
> > > > +      -
> > > > +    * - __u16
> > > > +      - ``pic_height_in_map_units_minus1``
> > > > +      -
> > >
> > > We recently had some reflection with Alex that this is redundant with
> > > the width and height in the OUTPUT format. It may also apply to some
> > > other fields in these structs. I feel like they should be removed and
> > > passed via corresponding generic V4L2 properties - format, selection,
> > > etc.
> > >
> > > The same problem is also present in the MPEG2 controls. In fact, there
> > > was a patch already which used some fields from the controls to
> > > calculate the destination buffer strides, rather than bytesperline in
> > > the format.
> > >
> > > Since we're in staging, it could be done with a follow-up patch, though.
> >
> > Just my two cents. I played with some codecs a while back. IIRC some
> > specify a "codec" size in addition to the actual picture size, like
> > when the encoder does padding to fit the requirements of the codec
> > (spec). Is this needed anywhere?
>
> With state-less encoders, the headers, which contains the crop
> information is created by userspace and for state less decoder, the
> headers that contains this information is parsed by userspace. So I
> believe that in theory, the accelerator does not strictly need to be
> aware of the cropped dimensions.
>
> Another thing, is that there is not guarantied matches between e.g.
> depth of the chrome/luma and the final image buffers. Some hardware may
> have bandwidth limitation or internal converter and could possibly
> decode 10bit data into 8bit buffers.
>
> A third reason why I would not try and encode this header information
> is that there can be multiple PPS/SPS at the same time, and I think
> it's confusing if the relevant information to differentiate them is
> removed.

Sorry if that sounds a bit dumb, but it's not really clear to me if
you're arguing for the removal of the data as Tomasz suggests, or if
you want to keep them.

The first paragrah seems to advocate for the former, but the two
others for the latter.

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]