All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Ellison <matt@arroyo.io>
To: Antony Antony <antony@phenome.org>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute2] ip: support for xfrm interfaces
Date: Fri, 5 Apr 2019 17:16:57 -0400	[thread overview]
Message-ID: <20190405171657.27190bfa@aquamarine> (raw)
In-Reply-To: <20190405210317.dtvseosbu3tobula@AntonyAntony.local>


> One comment. It seems to accept -ve value for if_id and quietly set
> to 0 may be throw an error for -ve values? or take it as u32?
> in my opinion setting to 0 is confusing

Ah good catch. I'll add the check in my version.

-- 



Please be advised that this email may contain confidential information. 
If you are not the intended recipient, please notify us by email by 
replying to the sender and delete this message. The sender disclaims that 
the content of this email constitutes an offer to enter into, or the 
acceptance of, any agreement; provided that the foregoing does not 
invalidate the binding effect of any digital or other electronic 
reproduction of a manual signature that is included in any attachment.


 
<https://twitter.com/arroyo_networks>   
<https://www.linkedin.com/company/arroyo-networks>   
<https://www.github.com/ArroyoNetworks>

      reply	other threads:[~2019-04-05 21:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-28 15:32 [PATCH iproute2] ip: support for xfrm interfaces Matt Ellison
2019-01-01  6:11 ` Stephen Hemminger
2019-01-01 17:40   ` Matt Ellison
2019-04-04 16:25     ` [iproute2] " Antony Antony
2019-04-05 19:46       ` Matt Ellison
2019-04-05 21:03         ` Antony Antony
2019-04-05 21:16           ` Matt Ellison [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190405171657.27190bfa@aquamarine \
    --to=matt@arroyo.io \
    --cc=antony@phenome.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.