All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeedm@mellanox.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Tonghao Zhang <xiangxia.m.yue@gmail.com>,
	Roi Dayan <roid@mellanox.com>,
	Saeed Mahameed <saeedm@mellanox.com>
Subject: [net-next V2 04/15] net/mlx5e: Remove 'parse_attr' argument in parse_tc_fdb_actions()
Date: Fri,  5 Apr 2019 14:17:08 -0700	[thread overview]
Message-ID: <20190405211719.14979-5-saeedm@mellanox.com> (raw)
In-Reply-To: <20190405211719.14979-1-saeedm@mellanox.com>

From: Tonghao Zhang <xiangxia.m.yue@gmail.com>

This patch is a little improvement. Simplify the parse_tc_fdb_actions().

Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Reviewed-by: Roi Dayan <roid@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index 2fd425a7b156..c061e5bdf365 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -2541,13 +2541,13 @@ static int parse_tc_vlan_action(struct mlx5e_priv *priv,
 
 static int parse_tc_fdb_actions(struct mlx5e_priv *priv,
 				struct flow_action *flow_action,
-				struct mlx5e_tc_flow_parse_attr *parse_attr,
 				struct mlx5e_tc_flow *flow,
 				struct netlink_ext_ack *extack)
 {
 	struct pedit_headers_action hdrs[2] = {};
 	struct mlx5_eswitch *esw = priv->mdev->priv.eswitch;
 	struct mlx5_esw_flow_attr *attr = flow->esw_attr;
+	struct mlx5e_tc_flow_parse_attr *parse_attr = attr->parse_attr;
 	struct mlx5e_rep_priv *rpriv = priv->ppriv;
 	const struct ip_tunnel_info *info = NULL;
 	const struct flow_action_entry *act;
@@ -2889,7 +2889,7 @@ __mlx5e_add_fdb_flow(struct mlx5e_priv *priv,
 	if (err)
 		goto err_free;
 
-	err = parse_tc_fdb_actions(priv, &rule->action, parse_attr, flow, extack);
+	err = parse_tc_fdb_actions(priv, &rule->action, flow, extack);
 	if (err)
 		goto err_free;
 
-- 
2.20.1


  parent reply	other threads:[~2019-04-05 21:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-05 21:17 [pull request][net-next V2 00/15] Mellanox, mlx5 updates 2019-04-02 Saeed Mahameed
2019-04-05 21:17 ` [net-next V2 01/15] net/mlx5: Handle event of power detection in the PCIE slot Saeed Mahameed
2019-04-05 21:17 ` [net-next V2 02/15] net/mlx5: E-Switch, Fix double mutex initialization Saeed Mahameed
2019-04-05 21:17 ` [net-next V2 03/15] net/mlx5e: Make the log friendly when decapsulation offload not supported Saeed Mahameed
2019-04-05 21:17 ` Saeed Mahameed [this message]
2019-04-05 21:17 ` [net-next V2 05/15] net/mlx5e: Deletes unnecessary setting of esw_attr->parse_attr Saeed Mahameed
2019-04-05 21:17 ` [net-next V2 06/15] net/mlx5e: Return -EOPNOTSUPP when attempting to offload an unsupported action Saeed Mahameed
2019-04-05 21:17 ` [net-next V2 07/15] net/mlx5e: Use helpers to get headers criteria and value pointers Saeed Mahameed
2019-04-05 21:17 ` [net-next V2 08/15] net/mlx5e: Deny VLAN rewrite if there is no VLAN header match Saeed Mahameed
2019-04-05 21:17 ` [net-next V2 09/15] net/mlx5e: Allow VLAN rewrite of prio field with the same match Saeed Mahameed
2019-04-05 21:17 ` [net-next V2 10/15] net/mlx5e: Offload TC e-switch rules with egress VLAN device Saeed Mahameed
2019-04-05 21:17 ` [net-next V2 11/15] net/mlx5e: Offload TC e-switch rules with ingress " Saeed Mahameed
2019-04-05 21:17 ` [net-next V2 12/15] net/mlx5e: Do not rewrite fields with the same match Saeed Mahameed
2019-04-05 21:17 ` [net-next V2 13/15] net/mlx5: A write memory barrier is sufficient in EQ ci update Saeed Mahameed
2019-04-05 21:17 ` [net-next V2 14/15] net/mlx5e: Obsolete param field holding a constant value Saeed Mahameed
2019-04-05 21:17 ` [net-next V2 15/15] net/mlx5e: Unify logic of MTU boundaries Saeed Mahameed
2019-04-08 21:32 ` [pull request][net-next V2 00/15] Mellanox, mlx5 updates 2019-04-02 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190405211719.14979-5-saeedm@mellanox.com \
    --to=saeedm@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=roid@mellanox.com \
    --cc=xiangxia.m.yue@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.