Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Guenter Roeck <groeck@google.com>,
	Dmitry Torokhov <dtor@google.com>,
	Nick Crews <ncrews@chromium.org>,
	Benson Leung <bleung@chromium.org>,
	linux-leds@vger.kernel.org,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	linux-rtc@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Duncan Laurie <dlaurie@chromium.org>,
	Simon Glass <sjg@google.com>
Subject: Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name
Date: Sat, 6 Apr 2019 11:53:46 +0200	[thread overview]
Message-ID: <20190406095346.GB7546@amd> (raw)
In-Reply-To: <469dfb68-a7ab-668d-15cb-9e021c0d3f0c@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1755 bytes --]

Hi!

> The patch set introduces also a set of predefined LED_FUNCTION
> names to be used in DT bindings. This along with the removal
> of devicename section from LED naming pattern will help to keep
> LED sysfs interface more uniform and not varying depending on
> underlaying hardware driving the LEDs.
> 
> Regarding the problem discussed in this thread - I would not necessarily
> go for "platform" in place of devicename LED name section in the
> cros_kbd_led_backlight driver. If we change it (should we at all - it is
> already in 5.0 AFAICS?), then I would opt for dropping the "chromeos:"
> part. It believe it will be possible to retrieve this name with
> get_led_device_info.sh script. It would be good exercise to check
> it out.

I am not sure about existing driver. Important thing for me is that
new drivers use consistent naming.

> In cases like above:
> 
>     keyboardist::kbd_backlight
>     tclnumpad::kbd_backlight
> 
> we could do with the following:
> 
>     :kbd-backlight
>     :numpad-backlight
> 
> I used hyphens instead of underscores since we will have this convention
> in the LED_FUNCTION names, which is more common for Device Tree, and
> some of existing LED triggers.

Existing userspace already searches for *:kbd_backlight", AFAICT, so
we probably want to keep the "_".

I don't care much if we use "platform:" or no prefix at all for
backlight of internal keyboard, as long as it is consistent across all
devices.

We certainly want to use some prefix (probably inputX:) for backlight
on USB keyboards.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]