All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vadim Kochan <vadim4j@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Revert "package/gettext-tiny: bump version to add --template option"
Date: Sun, 7 Apr 2019 12:13:42 +0300	[thread overview]
Message-ID: <20190407091342.urpr5hri5rqly5xn@vkochan-ThinkPad-T470p> (raw)
In-Reply-To: <20190407084926.GJ2659@scaer>

Hi Yann, James, All

On Sun, Apr 07, 2019 at 10:49:26AM +0200, Yann E. MORIN wrote:
> James, All,
> 
> On 2019-04-07 10:45 +0200, James Hilliard spake thusly:
> > On Sun, Apr 7, 2019 at 10:30 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > > On 2019-04-07 10:23 +0200, James Hilliard spake thusly:
> > > > On Sun, Apr 7, 2019 at 9:37 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > > > >
> > > > > This reverts commit 758ea0e518492c703482a323653c3d20520b599b.
> > > > >
> > > > > 758ea0e bumped gettext-tiny to the latest (at the time) head of the
> > > > > upstream git tree. In so doing, it included an upstream change of
> > > > > behaviour that eventually broke the build of packages that use
> > > > > -Werror=format-string.
> > > > I'm assuming the glib2 build error was caused by this change.
> > >
> > > Yes, see the build failure I pointed to below...
> > Ah, I was a little confused exactly how -Werror=format-nonliteral was related to
> > -Werror=format-string.
> 
> That's me again confused with the other patch from Vadim that was
> applied to gettext-tiny...
> 
> > > > I have a potential fix for that here:
> > > > https://gitlab.gnome.org/GNOME/glib/merge_requests/770/diffs
> > >
> > > I've ahd a quick look, but since I don;t know the glib2 code, I have no
> > > idea if that is the correct solution.
> > >
> > > However, you're probably going to have to provide more explanations
> > > about your change to upstream, because libglib2 does build with the
> > > non-tiny  implementations (either from glibc or from GNU gettext).
> > Oh, I wasn't aware this was limited to a specific getttext implementation.
> > I'll mention that in the pull request.
> 
> Be sure to check and test locally before hand! ;-)
> 

I sent yet-another-patch in:

	https://patchwork.ozlabs.org/patch/1079937/

but do you think it is better to fix issue per-package ?

Regards,
Vadim Kochan

  reply	other threads:[~2019-04-07  9:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-07  7:37 [Buildroot] [PATCH] Revert "package/gettext-tiny: bump version to add --template option" Yann E. MORIN
2019-04-07  8:03 ` Vadim Kochan
2019-04-07  8:23 ` James Hilliard
2019-04-07  8:30   ` Yann E. MORIN
2019-04-07  8:45     ` James Hilliard
2019-04-07  8:49       ` Yann E. MORIN
2019-04-07  9:13         ` Vadim Kochan [this message]
2019-04-07 13:11 ` Thomas Petazzoni
2019-04-07 13:55   ` Yann E. MORIN
2019-04-07 14:13     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190407091342.urpr5hri5rqly5xn@vkochan-ThinkPad-T470p \
    --to=vadim4j@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.