From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=X3pK=SK=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE08C10F13
	for <netdev@archiver.kernel.org>; Mon,  8 Apr 2019 23:38:03 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id E128720883
	for <netdev@archiver.kernel.org>; Mon,  8 Apr 2019 23:38:02 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726573AbfDHXiB (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 8 Apr 2019 19:38:01 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:42054 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726240AbfDHXiB (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 8 Apr 2019 19:38:01 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 1B8471456F2AC;
        Mon,  8 Apr 2019 16:38:01 -0700 (PDT)
Date:   Mon, 08 Apr 2019 16:38:00 -0700 (PDT)
Message-Id: <20190408.163800.424533196820923931.davem@davemloft.net>
To:     mzhivich@akamai.com
Cc:     sgoutham@cavium.com, rric@kernel.org, netdev@vger.kernel.org,
        andrew@lunn.ch
Subject: Re: [PATCH] ethtool: thunder_bgx: use ethtool.h constants for
 speed and duplex
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1554750046-9937-1-git-send-email-mzhivich@akamai.com>
References: <1554750046-9937-1-git-send-email-mzhivich@akamai.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 08 Apr 2019 16:38:01 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Michael Zhivich <mzhivich@akamai.com>
Date: Mon, 8 Apr 2019 15:00:46 -0400

> Use constants provided by ethtool.h for speed and duplex values
> instead of raw integer constants to increase code readability.
> 
> thunder_bgx already uses SPEED_UNKNOWN and DUPLEX_UNKNOWN constants,
> also provided by ethtool.h.
> 
> Signed-off-by: Michael Zhivich <mzhivich@akamai.com>

Applied.