All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	Zhihong Wang <zhihong.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/5] examples/vhost_scsi: fix header check for meson build
Date: Mon, 8 Apr 2019 11:23:02 +0800	[thread overview]
Message-ID: <20190408032301.GA20719@dpdk-tbie.sh.intel.com> (raw)
In-Reply-To: <20190405143709.50352-2-bruce.richardson@intel.com>

On Fri, Apr 05, 2019 at 03:37:05PM +0100, Bruce Richardson wrote:
> The header check for the example app was looking for virtio_scsi.h without
> the "linux/" prefix, which meant it was never getting found when it should
> have been.
> 
> Fixes: 8d47a753b7cb ("examples/vhost_scsi: disable build if missing dependency")
> CC: stable@dpdk.org
> CC: Maxime Coquelin <maxime.coquelin@redhat.com>
> CC: Tiwei Bie <tiwei.bie@intel.com>
> CC: Zhihong Wang <zhihong.wang@intel.com>
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  examples/vhost_scsi/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/vhost_scsi/meson.build b/examples/vhost_scsi/meson.build
> index ca1248023..e00a7dab1 100644
> --- a/examples/vhost_scsi/meson.build
> +++ b/examples/vhost_scsi/meson.build
> @@ -10,7 +10,7 @@ if host_machine.system() != 'linux'
>  	build = false
>  endif
>  
> -if not cc.has_header('virtio_scsi.h')
> +if not cc.has_header('linux/virtio_scsi.h')
>  	build = false
>  endif
>  
> -- 
> 2.20.1

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

  reply	other threads:[~2019-04-08  3:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-05 13:45 [dpdk-dev] [PATCH 0/5] some small fixes Bruce Richardson
2019-04-05 13:45 ` [dpdk-dev] [PATCH 1/5] examples/vhost_scsi: fix header check for meson build Bruce Richardson
2019-04-05 13:45 ` [dpdk-dev] [PATCH 2/5] examples/vhost_scsi: fix missing NULL-check for parameter Bruce Richardson
2019-04-05 13:45 ` [dpdk-dev] [PATCH 3/5] net/i40e: fix dereference before NULL check in mbuf release Bruce Richardson
2019-04-05 14:08   ` Rami Rosen
2019-04-05 13:45 ` [dpdk-dev] [PATCH 4/5] app/testpmd: fix variable use before NULL check Bruce Richardson
2019-04-05 14:13   ` Rami Rosen
2019-04-05 13:45 ` [dpdk-dev] [PATCH 5/5] net/i40e: fix dereference before check when getting EEPROM Bruce Richardson
2019-04-05 14:19   ` Rami Rosen
2019-04-05 14:37 ` [dpdk-dev] [PATCH v2 0/5] some small fixes Bruce Richardson
2019-04-05 14:37   ` [dpdk-dev] [PATCH v2 1/5] examples/vhost_scsi: fix header check for meson build Bruce Richardson
2019-04-08  3:23     ` Tiwei Bie [this message]
2019-04-05 14:37   ` [dpdk-dev] [PATCH v2 2/5] examples/vhost_scsi: fix missing NULL-check for parameter Bruce Richardson
2019-04-08  3:31     ` Tiwei Bie
2019-04-08  9:37       ` Bruce Richardson
2019-04-05 14:37   ` [dpdk-dev] [PATCH v2 3/5] net/i40e: fix dereference before NULL check in mbuf release Bruce Richardson
2019-04-05 14:37   ` [dpdk-dev] [PATCH v2 4/5] app/testpmd: fix variable use before NULL check Bruce Richardson
2019-04-05 14:37   ` [dpdk-dev] [PATCH v2 5/5] net/i40e: fix dereference before check when getting EEPROM Bruce Richardson
2019-04-08  9:46 ` [dpdk-dev] [PATCH v3 0/5] some small fixes Bruce Richardson
2019-04-08  9:46   ` [dpdk-dev] [PATCH v3 1/5] examples/vhost_scsi: fix header check for meson build Bruce Richardson
2019-04-08  9:46   ` [dpdk-dev] [PATCH v3 2/5] examples/vhost_scsi: fix missing NULL-check for parameter Bruce Richardson
2019-04-09  1:53     ` Tiwei Bie
2019-04-08  9:46   ` [dpdk-dev] [PATCH v3 3/5] net/i40e: fix dereference before NULL check in mbuf release Bruce Richardson
2019-04-08  9:46   ` [dpdk-dev] [PATCH v3 4/5] app/testpmd: fix variable use before NULL check Bruce Richardson
2019-04-08  9:46   ` [dpdk-dev] [PATCH v3 5/5] net/i40e: fix dereference before check when getting EEPROM Bruce Richardson
2019-04-22 21:49   ` [dpdk-dev] [PATCH v3 0/5] some small fixes Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190408032301.GA20719@dpdk-tbie.sh.intel.com \
    --to=tiwei.bie@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.