From: <wen.yang99@zte.com.cn>
To: laurent.pinchart@ideasonboard.com
Cc: wang.yi59@zte.com.cn, airlied@linux.ie,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
sebastian.reichel@collabora.com, tomi.valkeinen@ti.com
Subject: Re: [PATCH 4/7] drm/omap: fix possible object reference leak
Date: Mon, 8 Apr 2019 09:24:20 +0800 (CST) [thread overview]
Message-ID: <201904080924207059818@zte.com.cn> (raw)
In-Reply-To: <20190404132529.GB7817@pendragon.ideasonboard.com>
[-- Attachment #1.1: Type: text/plain, Size: 1471 bytes --]
> > The call to of_find_matching_node returns a node pointer with refcount
> > incremented thus it must be explicitly decremented after the last
> > usage.
> >
> > Detected by coccinelle with the following warnings:
> > drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c:212:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 209, but without a corresponding object release within this function.
> > drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c:237:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 209, but without a corresponding object release within this function.
> >
> > Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Sebastian Reichel <sebastian.reichel@collabora.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: linux-kernel@vger.kernel.org
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Would you like to get the series merged in one go, or individual patches
> picked by the respective maintainer ?
Thank you.
We are sorry that we did not respond in time because of
the Ching Ming Festival holiday.
In our opinion, both ways are fine.
In addition, we just checked and found that some patches
have been selected by the maintainers.
--
Regards,
Wen
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-04-08 1:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 16:04 [PATCH 0/7] fix possible object reference leaks in drivers/gpu Wen Yang
2019-04-03 16:04 ` [PATCH 1/7] drm/mediatek: fix possible object reference leak Wen Yang
2019-04-03 16:04 ` Wen Yang
2019-04-09 5:15 ` CK Hu
2019-04-09 5:15 ` CK Hu
2019-04-09 5:15 ` CK Hu
2019-04-03 16:04 ` [PATCH 2/7] drm/meson: " Wen Yang
2019-04-03 16:04 ` Wen Yang
2019-04-03 16:04 ` Wen Yang
2019-04-03 16:04 ` Wen Yang
2019-04-04 20:05 ` Markus Elfring
2019-04-04 20:05 ` Markus Elfring
2019-04-04 20:05 ` Markus Elfring
2019-04-04 20:05 ` Markus Elfring
2019-04-04 20:05 ` Markus Elfring
2019-04-03 16:04 ` [PATCH 3/7] drm/msm: a5xx: " Wen Yang
2019-04-10 16:21 ` Jordan Crouse
2019-04-10 16:21 ` Jordan Crouse
2019-04-03 16:04 ` [PATCH 4/7] drm/omap: " Wen Yang
2019-04-04 13:25 ` Laurent Pinchart
2019-04-08 1:24 ` wen.yang99 [this message]
2019-04-04 20:42 ` Markus Elfring
2019-04-04 20:42 ` Markus Elfring
2019-04-03 16:04 ` [PATCH 5/7] drm/pl111: " Wen Yang
2019-04-03 16:04 ` Wen Yang
2019-04-04 19:59 ` Eric Anholt
2019-04-04 19:59 ` Eric Anholt
2019-04-04 21:05 ` Markus Elfring
2019-04-04 21:05 ` Markus Elfring
2019-04-03 16:04 ` [PATCH 6/7] drm: rcar-du: " Wen Yang
2019-04-04 13:35 ` Laurent Pinchart
2019-04-08 1:10 ` 答复: " wen.yang99
2019-04-03 16:04 ` [PATCH 7/7] drm/tegra: " Wen Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201904080924207059818@zte.com.cn \
--to=wen.yang99@zte.com.cn \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=tomi.valkeinen@ti.com \
--cc=wang.yi59@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.