From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FC0DC282CE for ; Mon, 8 Apr 2019 09:45:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50E9F20870 for ; Mon, 8 Apr 2019 09:45:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=verge.net.au header.i=@verge.net.au header.b="BTyTZGNC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726383AbfDHJpz (ORCPT ); Mon, 8 Apr 2019 05:45:55 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:49681 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726253AbfDHJpy (ORCPT ); Mon, 8 Apr 2019 05:45:54 -0400 Received: from reginn.horms.nl (watermunt.horms.nl [80.127.179.77]) by kirsty.vergenet.net (Postfix) with ESMTPA id 19FC125B766; Mon, 8 Apr 2019 19:45:53 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; t=1554716753; bh=a8yFJvtnHQTRDeEePGs91FDOCdeojOy+6G5WbiDfaVQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BTyTZGNCTkU+XQ0ZSjsNnp9IXqxqB2Bur5a6p6He11Ib5DMUeXGwFBSjnZLlp8qF6 imErFRZQla5bb6+4hli6Y8puMg+A6TgBoPfDLOTpwWlO19EOu5uV4a/8jkIAPgn2/A Nvdbp+KbcxzU1LsehmnPk+nOvBB7ZstPl1+oYigM= Received: by reginn.horms.nl (Postfix, from userid 7100) id 275E594069B; Mon, 8 Apr 2019 11:45:51 +0200 (CEST) Date: Mon, 8 Apr 2019 11:45:51 +0200 From: Simon Horman To: Wolfram Sang Cc: linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Magnus Damm , Yoshihiro Shimoda , Wolfram Sang , Sergei Shtylyov Subject: Re: [PATCH/RFC] arm64: dts: renesas: ebisu, draak: Limit EtherAVB to 100Mbps Message-ID: <20190408094550.omzfxgsxalux7pxv@verge.net.au> References: <20190408083148.23134-1-horms+renesas@verge.net.au> <20190408084143.GA1615@kunai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190408084143.GA1615@kunai> Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Mon, Apr 08, 2019 at 10:41:43AM +0200, Wolfram Sang wrote: > Hi Simon, > > On Mon, Apr 08, 2019 at 10:31:48AM +0200, Simon Horman wrote: > > * According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of > > August 24, 2018, the TX clock internal delay mode isn't supported > > on R-Car E3 (r8a77990) and D3 (r8a77995). > > > > * TX clock internal delay mode is required for reliable 1Gbps communication > > using the KSZ9031RNX phy present on the Ebisu and Draak boards. > > > > Thus, the E3 based Ebisu and D3 based Draak boards reliably use 1Gbps and > > the speed should be limited to 100Mbps. > > "cannot" missing? Yes indeed, thanks for noticing. > > Based on work by Kazuya Mizuguchi. > > > > Signed-off-by: Simon Horman > > --- > > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 1 + > > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 1 + > > 2 files changed, 2 insertions(+) > > > > Based on renesas-devel-20190404-v5.1-rc3 > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > > index c72772589953..05214b8dd2c5 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > > @@ -272,6 +272,7 @@ > > interrupt-parent = <&gpio2>; > > interrupts = <21 IRQ_TYPE_LEVEL_LOW>; > > reset-gpios = <&gpio1 20 GPIO_ACTIVE_LOW>; > > + max-speed = <100>; > > What about adding a comment explaining this speed limit? Sure, if you think its worth highlighting in the dts as well as the changelog. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90B04C282CE for ; Mon, 8 Apr 2019 09:46:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D6DE20870 for ; Mon, 8 Apr 2019 09:46:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XvyqUzBc"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=verge.net.au header.i=@verge.net.au header.b="BTyTZGNC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D6DE20870 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=verge.net.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U2pfaFq0xekbByMWj9Hne9APx0RfLyC5f6yINJgFaVQ=; b=XvyqUzBcsOsD0X Xa5+qvhUlQ2Xrx+rF4vx9h+08JF7slfEMwUHrA6XohnGOzERVU+vzwGLuvFjzLPIJr5AXcFzgv7NM U6I4EFQ/++PtSLx4AKoXITHCr8KId0yE0rBQUAr9laJVjxTLEi+vhQbMpcfMG39tpTuj0qQlVrN9j sPUT7qxTVo55DiWQqAMauotE3BL+kZ+OdTIyIWTJ/RgUr2Qof7JNw7jajdv2PmJ1TqEMH/vDNxKCt nY8P7nuvnrZPxWxIDVVGZBNj/z1zXAXUijelpC8yfG/Nu1cqoMjmb0+QroRfyy4DY7hj+mjocJCVq ZPldEqFA2/ji7N0ch79g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDQqj-00006N-3E; Mon, 08 Apr 2019 09:45:57 +0000 Received: from kirsty.vergenet.net ([202.4.237.240]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDQqg-00004s-4O for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2019 09:45:55 +0000 Received: from reginn.horms.nl (watermunt.horms.nl [80.127.179.77]) by kirsty.vergenet.net (Postfix) with ESMTPA id 19FC125B766; Mon, 8 Apr 2019 19:45:53 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; t=1554716753; bh=a8yFJvtnHQTRDeEePGs91FDOCdeojOy+6G5WbiDfaVQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BTyTZGNCTkU+XQ0ZSjsNnp9IXqxqB2Bur5a6p6He11Ib5DMUeXGwFBSjnZLlp8qF6 imErFRZQla5bb6+4hli6Y8puMg+A6TgBoPfDLOTpwWlO19EOu5uV4a/8jkIAPgn2/A Nvdbp+KbcxzU1LsehmnPk+nOvBB7ZstPl1+oYigM= Received: by reginn.horms.nl (Postfix, from userid 7100) id 275E594069B; Mon, 8 Apr 2019 11:45:51 +0200 (CEST) Date: Mon, 8 Apr 2019 11:45:51 +0200 From: Simon Horman To: Wolfram Sang Subject: Re: [PATCH/RFC] arm64: dts: renesas: ebisu, draak: Limit EtherAVB to 100Mbps Message-ID: <20190408094550.omzfxgsxalux7pxv@verge.net.au> References: <20190408083148.23134-1-horms+renesas@verge.net.au> <20190408084143.GA1615@kunai> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190408084143.GA1615@kunai> Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190408_024554_329111_554FA18A X-CRM114-Status: GOOD ( 17.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sergei Shtylyov , Yoshihiro Shimoda , Magnus Damm , linux-renesas-soc@vger.kernel.org, Wolfram Sang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 08, 2019 at 10:41:43AM +0200, Wolfram Sang wrote: > Hi Simon, > > On Mon, Apr 08, 2019 at 10:31:48AM +0200, Simon Horman wrote: > > * According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of > > August 24, 2018, the TX clock internal delay mode isn't supported > > on R-Car E3 (r8a77990) and D3 (r8a77995). > > > > * TX clock internal delay mode is required for reliable 1Gbps communication > > using the KSZ9031RNX phy present on the Ebisu and Draak boards. > > > > Thus, the E3 based Ebisu and D3 based Draak boards reliably use 1Gbps and > > the speed should be limited to 100Mbps. > > "cannot" missing? Yes indeed, thanks for noticing. > > Based on work by Kazuya Mizuguchi. > > > > Signed-off-by: Simon Horman > > --- > > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 1 + > > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 1 + > > 2 files changed, 2 insertions(+) > > > > Based on renesas-devel-20190404-v5.1-rc3 > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > > index c72772589953..05214b8dd2c5 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > > @@ -272,6 +272,7 @@ > > interrupt-parent = <&gpio2>; > > interrupts = <21 IRQ_TYPE_LEVEL_LOW>; > > reset-gpios = <&gpio1 20 GPIO_ACTIVE_LOW>; > > + max-speed = <100>; > > What about adding a comment explaining this speed limit? Sure, if you think its worth highlighting in the dts as well as the changelog. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel