From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10892C282CE for ; Mon, 8 Apr 2019 14:01:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2C72218E2 for ; Mon, 8 Apr 2019 14:01:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="epfTus88" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726930AbfDHOBc (ORCPT ); Mon, 8 Apr 2019 10:01:32 -0400 Received: from mail-yw1-f65.google.com ([209.85.161.65]:38698 "EHLO mail-yw1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726721AbfDHOBc (ORCPT ); Mon, 8 Apr 2019 10:01:32 -0400 Received: by mail-yw1-f65.google.com with SMTP id m207so4950145ywd.5 for ; Mon, 08 Apr 2019 07:01:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=87ry1+exZi+/r/H1mx0oaRyz2ApizjtVLTtMVs6O4KM=; b=epfTus88c4eRGhAeKPB+w0UBih0X5+8GOVPdjdeDrOIuawJkAra876VswUDkPrzXrF HZTNiUGKFjHK6EliBB7LfVnu7J0YbJ4gRjnRJw9sZn4eyu6XtfKYm1rQM10dUOk5SUhK qFOgKLY0E/90a+l+opyE6j2jJpUCsoihkBrcw43HRL5UwF4znQ4fQnXsvdP5SOy/tS8S NiITnNxXRlSHZZp7KB4R4sdBaEaWcaIX3eAv0UYF9kxSw2bHw+xwXYeNwL+1usE2pRMP z6ybCG6ck+RDO66DAUGOPFouG/rkKzWIZU7wogBnKXOAYFkI7XQG3JWkKpT/wTTKrjPj X2SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=87ry1+exZi+/r/H1mx0oaRyz2ApizjtVLTtMVs6O4KM=; b=EH7HKvqGx+9ZSftSMgXaSUijwX5n7D7C4yVNO5mWKHM0udNFBvHfkzAbZWOT2rZ6O2 kClHqlKhjuG5fimP4b8Vo2G966mA08IFovxMSFpVBP/hwRJYblIQ+Noo4q/8jgiG93ph aVsoMdwWJC7eVHrAoCcJ06CBaA/swv7qhaah5YK+8t3bNCD7lwcAXzKsnj2H6kUZGIq0 Z3blKZjFTLZCVSxhl92GIp7q+5qbuYbvCjdjwXj4K4QAVUuhcot6KaKVYYOeaMq+uHQT 4Q+Oq57zebIjQqpBBb2MDw1npetkC/xhtlzA28nqTYWaRAdeyyIPOrE27q9gHiOVxuFW JMlQ== X-Gm-Message-State: APjAAAVO504LoPtzqv8Ky83x7D5Km4wQW2QM6GC94FDUFqLQVN+g+gs3 cmF01mqcbrjnQK8+8ZOpKjVsag== X-Google-Smtp-Source: APXvYqwV60OGZXfXmQa9eBA+1B3IhacLaxH+kmOW6+TFCdnaJ58QyKiI6bsfa/3fbPi/PhIPcFpIDA== X-Received: by 2002:a81:52c2:: with SMTP id g185mr24177643ywb.386.1554732090855; Mon, 08 Apr 2019 07:01:30 -0700 (PDT) Received: from leoy-ThinkPad-X240s (li931-65.members.linode.com. [45.56.113.65]) by smtp.gmail.com with ESMTPSA id p3sm2698232ywd.94.2019.04.08.07.01.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Apr 2019 07:01:29 -0700 (PDT) Date: Mon, 8 Apr 2019 22:01:15 +0800 From: Leo Yan To: Suzuki K Poulose Cc: mathieu.poirier@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, shiwanglai@hisilicon.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/4] dt-bindings: arm: coresight: Add new compatible for static replicator Message-ID: <20190408140115.GA6541@leoy-ThinkPad-X240s> References: <20190406112145.15184-1-leo.yan@linaro.org> <20190406112145.15184-2-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Suzuki, On Mon, Apr 08, 2019 at 11:44:56AM +0100, Suzuki K Poulose wrote: > On 04/06/2019 12:21 PM, Leo Yan wrote: > > CoreSight uses below bindings for replicator: > > > > Static replicator, aka. non-configurable replicator: > > "arm,coresight-replicator"; > > > > Dynamic replicator, aka. configurable replicator: > > "arm,coresight-dynamic-replicator", "arm,primecell"; > > > > The compatible string "arm,coresight-replicator" is not an explicit > > naming to express the replicator is 'static'. To unify the naming > > convention, this patch introduces a new compatible string > > "arm,coresight-static-replicator" for the static replicator; the > > compatible string "arm,coresight-replicator" is still kept thus we > > can support the old DT binding, but tag it as obsolete and suggest > > to use the new compatible string. > > > > As result CoreSight replicator have below bindings: > > > > Static replicator: > > "arm,coresight-replicator"; (obsolete) > > "arm,coresight-static-replicator"; > > > > Dynamic replicator: > > "arm,coresight-dynamic-replicator", "arm,primecell"; > > > > Signed-off-by: Leo Yan > > --- > > Documentation/devicetree/bindings/arm/coresight.txt | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt > > index f8aff65ab921..f8f794869af2 100644 > > --- a/Documentation/devicetree/bindings/arm/coresight.txt > > +++ b/Documentation/devicetree/bindings/arm/coresight.txt > > @@ -69,7 +69,11 @@ its hardware characteristcs. > > * compatible: Currently supported value is (note the absence of the > > AMBA markee): > > - - "arm,coresight-replicator" > > + - Coresight Non-configurable Replicator, the compatible string > > + "arm,coresight-replicator" is obsolete, keep it to support > > To make it more obvious : s/obsolete/OBSOLETE/ > > > + the old DT bindings: > > + "arm,coresight-replicator"; > > + "arm,coresight-static-replicator"; > > nit: I would re-order the compatible strings to show the precedence of > choice. > > e.g, > - CoreSight non-configurable Replicator > "arm,coresight-static-replicator"; > "arm,coresight-replicator"; (OBSOLETE. For > backward compatibility. Will be removed ) The suggestion looks good to me since it's neat. Will do it. > Also, please could we put a warning in the driver when we encounter it > and request to update it ? Will do. Thanks for reviewing! Leo Yan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76C71C10F13 for ; Mon, 8 Apr 2019 14:01:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 376B72147A for ; Mon, 8 Apr 2019 14:01:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E6Njto3x"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="epfTus88" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 376B72147A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jHsi9BnocphmCDvzhD8+/hU4ifn6GZHDSK0wYgTheaE=; b=E6Njto3xHkvU4D N5V+mPXrXP4j5OIgp4J4rJ+XFIAGKbkWerNAWQcg5I6Ri8YU2kbLELV0riQa6b4jHBx6nLWTECsOj TV22UDg704GEdI5vCz2kUNoTFRNDLHNA8Gcrw2la7LJCW2AS1evSM+R+0J8SjFoSf5g3NP4sw+C2Y g/YICQajjxGJJ9cLuJPQRWcF0/Dt18WsoyP2DZOT9rDWUggFkPIr1jQeWxoKQl2gGp61lAXy5pTxv MqmCqJUmKvPeT7lR/BvAJZgssZ/MgLal867UTcQBQG9NJ7s05puFA/a8p4DYNHkdJLpNFEPEl0Z1c KI9oIqhU0NLLbk3sy3GA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDUqC-0007GA-Kj; Mon, 08 Apr 2019 14:01:40 +0000 Received: from mail-yw1-xc41.google.com ([2607:f8b0:4864:20::c41]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDUq4-00077v-Q0 for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2019 14:01:35 +0000 Received: by mail-yw1-xc41.google.com with SMTP id d132so4963975ywa.2 for ; Mon, 08 Apr 2019 07:01:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=87ry1+exZi+/r/H1mx0oaRyz2ApizjtVLTtMVs6O4KM=; b=epfTus88c4eRGhAeKPB+w0UBih0X5+8GOVPdjdeDrOIuawJkAra876VswUDkPrzXrF HZTNiUGKFjHK6EliBB7LfVnu7J0YbJ4gRjnRJw9sZn4eyu6XtfKYm1rQM10dUOk5SUhK qFOgKLY0E/90a+l+opyE6j2jJpUCsoihkBrcw43HRL5UwF4znQ4fQnXsvdP5SOy/tS8S NiITnNxXRlSHZZp7KB4R4sdBaEaWcaIX3eAv0UYF9kxSw2bHw+xwXYeNwL+1usE2pRMP z6ybCG6ck+RDO66DAUGOPFouG/rkKzWIZU7wogBnKXOAYFkI7XQG3JWkKpT/wTTKrjPj X2SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=87ry1+exZi+/r/H1mx0oaRyz2ApizjtVLTtMVs6O4KM=; b=EX+2jXcHYZdY8qFzzfVlVGRM/9C4W/58qtUS8RoVppvg75Y6vwKrPmdS7duzGa3w9d m067MY6tuKuepKfVQP6/2EsoWlch7uxZyFDZL9jO5cnUH5p6AaIDxyyi9JRa4DZYrWO+ 8/ngMOv8nFELx6z2a5KfRtkjMTdoP3dZlepgNm7TezFbr1o9ylKz4HwJh2ugfwtUJ8M8 OJZgC/gvcTxdbO8KY9rTW0/isyr6yqwJP8r5ZWtgWWql0walD2DPdcS13jh5X+gULnBR fCU8noXNqgUQpsuZUFnYxaNIPcUMuiUqNRitcrwU+bjFOBIe1CaS22PQp1jQmklMsKAK vnmQ== X-Gm-Message-State: APjAAAUFoZj1lC23czauWwcqVAODVMt5JwdCdcheXr55rsvn5qlmMZrg bewlW+cYoTS2YD/go8XM3aZG4RePqoWMHw== X-Google-Smtp-Source: APXvYqwV60OGZXfXmQa9eBA+1B3IhacLaxH+kmOW6+TFCdnaJ58QyKiI6bsfa/3fbPi/PhIPcFpIDA== X-Received: by 2002:a81:52c2:: with SMTP id g185mr24177643ywb.386.1554732090855; Mon, 08 Apr 2019 07:01:30 -0700 (PDT) Received: from leoy-ThinkPad-X240s (li931-65.members.linode.com. [45.56.113.65]) by smtp.gmail.com with ESMTPSA id p3sm2698232ywd.94.2019.04.08.07.01.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Apr 2019 07:01:29 -0700 (PDT) Date: Mon, 8 Apr 2019 22:01:15 +0800 From: Leo Yan To: Suzuki K Poulose Subject: Re: [PATCH v4 1/4] dt-bindings: arm: coresight: Add new compatible for static replicator Message-ID: <20190408140115.GA6541@leoy-ThinkPad-X240s> References: <20190406112145.15184-1-leo.yan@linaro.org> <20190406112145.15184-2-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190408_070133_007575_5A9ADABF X-CRM114-Status: GOOD ( 22.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, shiwanglai@hisilicon.com, mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Suzuki, On Mon, Apr 08, 2019 at 11:44:56AM +0100, Suzuki K Poulose wrote: > On 04/06/2019 12:21 PM, Leo Yan wrote: > > CoreSight uses below bindings for replicator: > > > > Static replicator, aka. non-configurable replicator: > > "arm,coresight-replicator"; > > > > Dynamic replicator, aka. configurable replicator: > > "arm,coresight-dynamic-replicator", "arm,primecell"; > > > > The compatible string "arm,coresight-replicator" is not an explicit > > naming to express the replicator is 'static'. To unify the naming > > convention, this patch introduces a new compatible string > > "arm,coresight-static-replicator" for the static replicator; the > > compatible string "arm,coresight-replicator" is still kept thus we > > can support the old DT binding, but tag it as obsolete and suggest > > to use the new compatible string. > > > > As result CoreSight replicator have below bindings: > > > > Static replicator: > > "arm,coresight-replicator"; (obsolete) > > "arm,coresight-static-replicator"; > > > > Dynamic replicator: > > "arm,coresight-dynamic-replicator", "arm,primecell"; > > > > Signed-off-by: Leo Yan > > --- > > Documentation/devicetree/bindings/arm/coresight.txt | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt > > index f8aff65ab921..f8f794869af2 100644 > > --- a/Documentation/devicetree/bindings/arm/coresight.txt > > +++ b/Documentation/devicetree/bindings/arm/coresight.txt > > @@ -69,7 +69,11 @@ its hardware characteristcs. > > * compatible: Currently supported value is (note the absence of the > > AMBA markee): > > - - "arm,coresight-replicator" > > + - Coresight Non-configurable Replicator, the compatible string > > + "arm,coresight-replicator" is obsolete, keep it to support > > To make it more obvious : s/obsolete/OBSOLETE/ > > > + the old DT bindings: > > + "arm,coresight-replicator"; > > + "arm,coresight-static-replicator"; > > nit: I would re-order the compatible strings to show the precedence of > choice. > > e.g, > - CoreSight non-configurable Replicator > "arm,coresight-static-replicator"; > "arm,coresight-replicator"; (OBSOLETE. For > backward compatibility. Will be removed ) The suggestion looks good to me since it's neat. Will do it. > Also, please could we put a warning in the driver when we encounter it > and request to update it ? Will do. Thanks for reviewing! Leo Yan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel