All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Michael Zhivich <mzhivich@akamai.com>
Cc: davem@davemloft.net, sgoutham@cavium.com, rric@kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH] ethtool: thunder_bgx: use ethtool.h constants for speed and duplex
Date: Mon, 8 Apr 2019 21:22:44 +0200	[thread overview]
Message-ID: <20190408192244.GH6051@lunn.ch> (raw)
In-Reply-To: <1554750046-9937-1-git-send-email-mzhivich@akamai.com>

On Mon, Apr 08, 2019 at 03:00:46PM -0400, Michael Zhivich wrote:
> Use constants provided by ethtool.h for speed and duplex values
> instead of raw integer constants to increase code readability.
> 
> thunder_bgx already uses SPEED_UNKNOWN and DUPLEX_UNKNOWN constants,
> also provided by ethtool.h.
> 
> Signed-off-by: Michael Zhivich <mzhivich@akamai.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

  reply	other threads:[~2019-04-08 19:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 19:00 [PATCH] ethtool: thunder_bgx: use ethtool.h constants for speed and duplex Michael Zhivich
2019-04-08 19:22 ` Andrew Lunn [this message]
2019-04-08 23:38 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190408192244.GH6051@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=mzhivich@akamai.com \
    --cc=netdev@vger.kernel.org \
    --cc=rric@kernel.org \
    --cc=sgoutham@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.