From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7243DC10F0E for ; Tue, 9 Apr 2019 20:20:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DC1C2084F for ; Tue, 9 Apr 2019 20:20:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726568AbfDIUT7 (ORCPT ); Tue, 9 Apr 2019 16:19:59 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:56460 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726496AbfDIUT7 (ORCPT ); Tue, 9 Apr 2019 16:19:59 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 454D014B4AE7A; Tue, 9 Apr 2019 13:19:58 -0700 (PDT) Date: Tue, 09 Apr 2019 13:19:52 -0700 (PDT) Message-Id: <20190409.131952.887218664911322088.davem@davemloft.net> To: hkallweit1@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, linux@armlinux.org.uk, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: phy: remove unnecessary callback settings in C45 drivers From: David Miller In-Reply-To: <5cc623bf-1d73-3de6-d78e-acedc40c1471@gmail.com> References: <5cc623bf-1d73-3de6-d78e-acedc40c1471@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 09 Apr 2019 13:19:58 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Sun, 7 Apr 2019 12:11:35 +0200 > genphy_c45_aneg_done() is used by phylib as fallback for c45 PHY's if > callback aneg_done isn't defined. So we don't have to set this > explicitly. Same for genphy_c45_pma_read_abilities(). > > Signed-off-by: Heiner Kallweit This patch looks sane to me, applied to net-next. Thanks.