All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/civetweb: fix link failure due to missing OpenSSL dependency
Date: Tue, 9 Apr 2019 23:28:25 +0200	[thread overview]
Message-ID: <20190409232825.2cdb0766@windsurf.home> (raw)
In-Reply-To: <20190409211032.66320-1-giulio.benetti@micronovasrl.com>

On Tue,  9 Apr 2019 23:10:32 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> During linking one OpenSSL dependecy is missing(-latomic) on linking
> library list.
> 
> - Substitute explicit library list with `pkg-config libssl` when
> BR2_PACKAGE_OPENSSL is enabled. In such way all needed libraries will be
> included in linking list.
> - Add also `host-pkgconf` to CIVETWEB_DEPENDENCIES if
> BR2_PACKAGE_OPENSSL is enabled to make it available for previous point.
> 
> Fixes:
> http://autobuild.buildroot.net/results/b2e/b2e210bdefe84f4ec9cfda79a33d81788fb7e66c/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

Applied to master, with one small change, see below.

> +CIVETWEB_LIBS += `$(HOST_DIR)/usr/bin/pkg-config --libs libssl`

$(HOST_DIR)/usr no longer really exists, it's a symlink to $(HOST_DIR),
so this path should have been just $(HOST_DIR)/bin/pkg-config.

However, pkgconf.mk precisely provides the PKG_CONFIG_HOST_BINARY
variable, which contains exactly the path to pkg-config. So I've used
that instead.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-04-09 21:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09 21:10 [Buildroot] [PATCH] package/civetweb: fix link failure due to missing OpenSSL dependency Giulio Benetti
2019-04-09 21:28 ` Thomas Petazzoni [this message]
2019-04-10 10:06   ` Giulio Benetti
2019-04-14 21:26 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190409232825.2cdb0766@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.