From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:58802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE8uP-00053M-Ag for qemu-devel@nongnu.org; Wed, 10 Apr 2019 04:48:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hE8uO-0005Lm-HL for qemu-devel@nongnu.org; Wed, 10 Apr 2019 04:48:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41692) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hE8uO-0005Km-8h for qemu-devel@nongnu.org; Wed, 10 Apr 2019 04:48:40 -0400 Date: Wed, 10 Apr 2019 10:48:30 +0200 From: Gerd Hoffmann Message-ID: <20190410084830.hiesbi6aumiwsdfk@sirius.home.kraxel.org> References: <20190409161009.6322-1-marcandre.lureau@redhat.com> <20190409161009.6322-18-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190409161009.6322-18-marcandre.lureau@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 17/20] console: make screendump asynchronous List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, Eric Blake , Markus Armbruster , "Dr. David Alan Gilbert" , Michael Roth > +static void qmp_screendump_finish(QemuConsole *con, struct qmp_screendump *dump) > +{ > + Error *err = NULL; > + DisplaySurface *surface; > + Monitor *prev_mon = cur_mon; Why this is needed? > + /* > + * FIXME: async save with coroutine? it would have to copy or > + * lock the surface. > + */ > + ppm_save(dump->filename, surface, &err); DisplaySurface is just a thin layer above pixman images these days. Pixman images are reference counted, so you can pixman_image_ref(surface->image) to make sure it doesn't disappear underneath you, then pass the pixman image to ppm_save. cheers, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E337C10F11 for ; Wed, 10 Apr 2019 08:49:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F41EE20850 for ; Wed, 10 Apr 2019 08:49:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F41EE20850 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:55903 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE8vc-0005Xh-7S for qemu-devel@archiver.kernel.org; Wed, 10 Apr 2019 04:49:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE8uP-00053M-Ag for qemu-devel@nongnu.org; Wed, 10 Apr 2019 04:48:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hE8uO-0005Lm-HL for qemu-devel@nongnu.org; Wed, 10 Apr 2019 04:48:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41692) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hE8uO-0005Km-8h for qemu-devel@nongnu.org; Wed, 10 Apr 2019 04:48:40 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BE2B1356F5; Wed, 10 Apr 2019 08:48:38 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-65.ams2.redhat.com [10.36.116.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id DAF8810C853A; Wed, 10 Apr 2019 08:48:35 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 1CB8116E03; Wed, 10 Apr 2019 10:48:30 +0200 (CEST) Date: Wed, 10 Apr 2019 10:48:30 +0200 From: Gerd Hoffmann To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <20190410084830.hiesbi6aumiwsdfk@sirius.home.kraxel.org> References: <20190409161009.6322-1-marcandre.lureau@redhat.com> <20190409161009.6322-18-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190409161009.6322-18-marcandre.lureau@redhat.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 10 Apr 2019 08:48:38 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v4 17/20] console: make screendump asynchronous X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190410084830.Bs9vXeLU97lkyuAwPmf7BpZyKsJWnXdcfbuMeFXl9fw@z> > +static void qmp_screendump_finish(QemuConsole *con, struct qmp_screendump *dump) > +{ > + Error *err = NULL; > + DisplaySurface *surface; > + Monitor *prev_mon = cur_mon; Why this is needed? > + /* > + * FIXME: async save with coroutine? it would have to copy or > + * lock the surface. > + */ > + ppm_save(dump->filename, surface, &err); DisplaySurface is just a thin layer above pixman images these days. Pixman images are reference counted, so you can pixman_image_ref(surface->image) to make sure it doesn't disappear underneath you, then pass the pixman image to ppm_save. cheers, Gerd