From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86008C10F11 for ; Thu, 11 Apr 2019 03:09:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CE08218D2 for ; Thu, 11 Apr 2019 03:09:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726732AbfDKDJg (ORCPT ); Wed, 10 Apr 2019 23:09:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:48200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726247AbfDKDJg (ORCPT ); Wed, 10 Apr 2019 23:09:36 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19D8C20818; Thu, 11 Apr 2019 03:09:35 +0000 (UTC) Date: Wed, 10 Apr 2019 23:09:33 -0400 From: Steven Rostedt To: Josh Poimboeuf Cc: Thomas Gleixner , LKML , x86@kernel.org, Andy Lutomirski , Alexander Potapenko , iommu@lists.linux-foundation.org, Robin Murphy , Christoph Hellwig , Marek Szyprowski Subject: Re: [RFC patch 28/41] dma/debug: Simplify stracktrace retrieval Message-ID: <20190410230933.7d1138b3@oasis.local.home> In-Reply-To: <20190411030201.uko3njal44w2ea4b@treble> References: <20190410102754.387743324@linutronix.de> <20190410103646.130022106@linutronix.de> <20190411030201.uko3njal44w2ea4b@treble> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Apr 2019 22:02:01 -0500 Josh Poimboeuf wrote: > > #ifdef CONFIG_STACKTRACE > > - struct stack_trace stacktrace; > > - unsigned long st_entries[DMA_DEBUG_STACKTRACE_ENTRIES]; > > + unsigned int st_len; > > + unsigned long st_entries[DMA_DEBUG_STACKTRACE_ENTRIES]; > > nit: st_entries isn't very readable. Thanks to the magic of compilers, > the characters are free, so why not call them "stacktrace_entries" and > "stacktrace_len". But doesn't that slow down the time it takes to compile? /me runs... -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63481C10F11 for ; Thu, 11 Apr 2019 03:09:55 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F18920850 for ; Thu, 11 Apr 2019 03:09:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F18920850 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id E6D6121E0; Thu, 11 Apr 2019 03:09:54 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 89E191964 for ; Thu, 11 Apr 2019 03:09:36 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 43CF57FB for ; Thu, 11 Apr 2019 03:09:36 +0000 (UTC) Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19D8C20818; Thu, 11 Apr 2019 03:09:35 +0000 (UTC) Date: Wed, 10 Apr 2019 23:09:33 -0400 From: Steven Rostedt To: Josh Poimboeuf Subject: Re: [RFC patch 28/41] dma/debug: Simplify stracktrace retrieval Message-ID: <20190410230933.7d1138b3@oasis.local.home> In-Reply-To: <20190411030201.uko3njal44w2ea4b@treble> References: <20190410102754.387743324@linutronix.de> <20190410103646.130022106@linutronix.de> <20190411030201.uko3njal44w2ea4b@treble> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: x86@kernel.org, LKML , iommu@lists.linux-foundation.org, Alexander Potapenko , Andy Lutomirski , Thomas Gleixner , Robin Murphy , Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190411030933.Bn_9GEPQBrqA-bOTLQDEGGqJUE2cT1fVnqPPWRB8fZM@z> On Wed, 10 Apr 2019 22:02:01 -0500 Josh Poimboeuf wrote: > > #ifdef CONFIG_STACKTRACE > > - struct stack_trace stacktrace; > > - unsigned long st_entries[DMA_DEBUG_STACKTRACE_ENTRIES]; > > + unsigned int st_len; > > + unsigned long st_entries[DMA_DEBUG_STACKTRACE_ENTRIES]; > > nit: st_entries isn't very readable. Thanks to the magic of compilers, > the characters are free, so why not call them "stacktrace_entries" and > "stacktrace_len". But doesn't that slow down the time it takes to compile? /me runs... -- Steve _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu