From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC922C10F11 for ; Thu, 11 Apr 2019 02:47:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E9AD206DF for ; Thu, 11 Apr 2019 02:47:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726843AbfDKCrw (ORCPT ); Wed, 10 Apr 2019 22:47:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37938 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbfDKCrw (ORCPT ); Wed, 10 Apr 2019 22:47:52 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DAA947F6AE; Thu, 11 Apr 2019 02:47:51 +0000 (UTC) Received: from treble (ovpn-120-231.rdu2.redhat.com [10.10.120.231]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 291B05C29A; Thu, 11 Apr 2019 02:47:51 +0000 (UTC) Date: Wed, 10 Apr 2019 21:47:49 -0500 From: Josh Poimboeuf To: Thomas Gleixner Cc: LKML , x86@kernel.org, Andy Lutomirski , Steven Rostedt , Alexander Potapenko Subject: Re: [RFC patch 20/41] backtrace-test: Simplify stack trace handling Message-ID: <20190411024749.tddkzalul4uhcjuy@treble> References: <20190410102754.387743324@linutronix.de> <20190410103645.403947650@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190410103645.403947650@linutronix.de> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 11 Apr 2019 02:47:51 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 10, 2019 at 12:28:14PM +0200, Thomas Gleixner wrote: > Replace the indirection through struct stack_trace by using the storage > array based interfaces. > > Signed-off-by: Thomas Gleixner > --- > kernel/backtracetest.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > --- a/kernel/backtracetest.c > +++ b/kernel/backtracetest.c > @@ -48,19 +48,14 @@ static void backtrace_test_irq(void) > #ifdef CONFIG_STACKTRACE > static void backtrace_test_saved(void) > { > - struct stack_trace trace; > unsigned long entries[8]; > + unsigned int nent; "Nent" isn't immediately readable to my eyes. How about just good old "nr_entries"? (for this patch and all the others) -- Josh