From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/android-tools: host-android-tools need pkg-conf
Date: Thu, 11 Apr 2019 08:25:28 +0200 [thread overview]
Message-ID: <20190411082528.3152fca9@windsurf.home> (raw)
In-Reply-To: <20190411082218.2503be2d@windsurf.home>
On Thu, 11 Apr 2019 08:22:18 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> We don't typically re-use the target dependencies variable for the host
> dependencies. So I changed this to = host-pkgconf and applied.
An illustration of why re-using $(ANDROID_TOOLS_DEPENDENCIES) doesn't
do what you think it does:
$ cat foo.mk
FOO_DEPENDENCIES = host-pkgconf
HOST_FOO_DEPENDENCIES = $(FOO_DEPENDENCIES)
FOO_DEPENDENCIES += zlib
HOST_FOO_DEPENDENCIES += host-zlib
all:
@echo $(FOO_DEPENDENCIES)
@echo $(HOST_FOO_DEPENDENCIES)
$ make -f foo.mk
host-pkgconf zlib
host-pkgconf zlib host-zlib
See how HOST_FOO_DEPENDENCIES contains "zlib" ?
= assignments are evaluated at the time of use, not at the time of
assignment (contrary to := assignments).
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-04-11 6:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 13:17 [Buildroot] [PATCH] package/android-tools: host-android-tools need pkg-conf Giulio Benetti
2019-04-11 6:22 ` Thomas Petazzoni
2019-04-11 6:25 ` Thomas Petazzoni [this message]
2019-04-11 6:46 ` Giulio Benetti
2019-04-14 21:19 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411082528.3152fca9@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.