From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1308C10F13 for ; Thu, 11 Apr 2019 13:47:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB3C421852 for ; Thu, 11 Apr 2019 13:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554990473; bh=ByR2RKeploSynhHARPU/EzKB/rHYuhHFfY7sX/K+SLM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=xyVookGD9IyHwncDZgBkQeU7IaIPcx1OpvAohJN+jxvYft7WnT3c+XINe6bONFpKE ZxMsdPpKIbDb05F33t1mC5B/zm6iPziwlZ07ieSXblgpZ+vzgx9ZfCZtgc0BCA2r+D od31Ri6ZBXUDTNm3j6rUVufelWsHLel58Fb+P0J0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726640AbfDKNrx (ORCPT ); Thu, 11 Apr 2019 09:47:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:45882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbfDKNrx (ORCPT ); Thu, 11 Apr 2019 09:47:53 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A5A472133D; Thu, 11 Apr 2019 13:47:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554990472; bh=ByR2RKeploSynhHARPU/EzKB/rHYuhHFfY7sX/K+SLM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i3DWgHBb6miHIa8zRyVk45uWaQKZPV1PDJaxLRFNdQMBtkwNY4WjXqLq74sCtmFeM RbAwBnKMjP3xjoBeMr0t3hu9y8ym36XMrgfKDQzkL6ZC9advqer5oXZUpbRHMMHzxg Ns9JFMXOjMrKR00EyJLUGgncQu86RnacNIKDlNaM= Date: Thu, 11 Apr 2019 09:47:49 -0400 From: Sasha Levin To: Masahiro Yamada Cc: Ivan Babrou , Greg Kroah-Hartman , Linux Kbuild mailing list , kernel-team , stable Subject: Re: syncconfig changes in 4.19.34 break builds Message-ID: <20190411134749.GH11568@sasha-vm> References: <20190409153933.GM4689@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Apr 11, 2019 at 01:27:43PM +0900, Masahiro Yamada wrote: >Hi Sasha, > >On Wed, Apr 10, 2019 at 12:39 AM Sasha Levin wrote: >> >> On Tue, Apr 09, 2019 at 02:50:04PM +0900, Masahiro Yamada wrote: >> >Greg, Sasha, >> > >> > >> >Sorry, the commit ID was wrong. >> > >> > >> >The following commit for 4.19.x: >> > >> >commit 02826a6ba301b72461c3706e1cc66d5571cd327e >> >Author: Masahiro Yamada >> >Date: Mon Nov 5 16:52:34 2018 +0900 >> > >> > kbuild: deb-pkg: fix bindeb-pkg breakage when O= is used >> >> This commit claims it's fixing 80463f1b7bf9, which is not in 4.19. Was >> that a mistake in the commit message? > >No. The commit message is correct. >The Fixes: tag points to the first bad commit in _upstream_. > > >What I want to say is: >638ecaf58369 [which was 9390dff66a5 in upstream] >depends on 02826a6ba301b, which is missing in v4.19.x branch. > >638ecaf58369 was cherry-picked without correct patch >dependency, so it got broken. That's all. > > >There are two options to fix the breakage: > - backport 02826a6ba301b > OR > - revert 638ecaf58369. Alrighty, I've picked 02826a6ba301b for 4.19, thanks. -- Thanks, Sasha