From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 994CAC10F13 for ; Thu, 11 Apr 2019 16:47:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 592272146F for ; Thu, 11 Apr 2019 16:47:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech-se.20150623.gappssmtp.com header.i=@ragnatech-se.20150623.gappssmtp.com header.b="Vnh7M0nM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726391AbfDKQra (ORCPT ); Thu, 11 Apr 2019 12:47:30 -0400 Received: from mail-lj1-f179.google.com ([209.85.208.179]:43581 "EHLO mail-lj1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbfDKQr3 (ORCPT ); Thu, 11 Apr 2019 12:47:29 -0400 Received: by mail-lj1-f179.google.com with SMTP id f18so6142645lja.10 for ; Thu, 11 Apr 2019 09:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=7TOrm/pIUjywy+PcLxQavGH3pPV+PtonB7njN6vd3Vk=; b=Vnh7M0nM7lWbgVm8irPx5LIVNe97+r/gl4keZFc+9YVrPBx0FufjXVvUQCET7Thyyw tsljOfFLHNVZqbM3nlPfEEJpMYMO/61zmwdcqal2HOPCPWjmsx+Hb2+DQHY4pWhbrrRg SrgR0AM3sGNUj+D/c6jDTe/hrdjP94YkBxIOVxsKPsFzQi+Tn9ghmZbz5IbrL29G6EfN FFxekp41AhMIsg70/XHNnKiSdTrm3SRHmrAYHnQ+NLlK4o0pTeM56U+uG6Ab5L0WE7fe 5pCZOHzjufzYBFJ1z+qaJGQP8Ft+VSCjvzsaGb6qSR8mcbYJu1rB1pIp+b+Lw8NocFQV pZJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=7TOrm/pIUjywy+PcLxQavGH3pPV+PtonB7njN6vd3Vk=; b=Xp2QaCd9BFe3o8KV7CSUtzA1O87fpQzLb18hmYfccPqr4wCHMDwhhVcqibgpcgo716 PbFNUAZevNz370ZNNCX0f+ntLaYEUC5MZsURCqWA32ePdh+BnygRz01NXpsPs5fCLEIg IiQ5gY/SalTfay9yflORJRjUDA/NJx04oukv3wK9+aTKd7NL9fNEgcOkuMxYRaG1mXQ3 OVYlW0SP2+ePR77P3riKngsQ3OAPNslo7NJSltASzXWS+mstultliKVydy7CXTWHqJmH EFkbVRA1PuydgqOq+f/B/TDBOz7hwRqL96fT6OAMB0EQtLRkIXMEdpkDo79jYUsyBaQX v8Sw== X-Gm-Message-State: APjAAAUFguzGsmKkwLh7pMcbZ58aLU8auBQ3DQzrFcdvNdktj/XJIzsJ tpqa7ndDrsalsLVg7xu/GyBbfQ== X-Google-Smtp-Source: APXvYqyiUySD+Iexj0LgZ0MKP+TmhGxuIn8SCyQW6/VeGdC0Fx8RhazqSDDQf/mawoEXeCRLjORQ8Q== X-Received: by 2002:a2e:420c:: with SMTP id p12mr27591808lja.1.1555001247610; Thu, 11 Apr 2019 09:47:27 -0700 (PDT) Received: from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99]) by smtp.gmail.com with ESMTPSA id s24sm7778325ljs.30.2019.04.11.09.47.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Apr 2019 09:47:26 -0700 (PDT) Date: Thu, 11 Apr 2019 18:47:25 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Simon Horman Cc: Yoshihiro Kaneko , linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven , Magnus Damm , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH/RFT] arm64: dts: renesas: r8a7795: Create thermal zone to support IPA Message-ID: <20190411164725.GE30887@bigcity.dyn.berto.se> References: <1545338982-19466-1-git-send-email-ykaneko0929@gmail.com> <20190110163356.GF24252@bigcity.dyn.berto.se> <20190408122941.wziujh5ibgwy5cdp@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190408122941.wziujh5ibgwy5cdp@verge.net.au> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Simon, On 2019-04-08 14:29:41 +0200, Simon Horman wrote: > > > @@ -3172,11 +3158,15 @@ > > > > > > cooling-maps { > > > map0 { > > > - trip = <&sensor3_passive>; > > > - cooling-device = <&a57_0 4 4>, > > > - <&a57_1 4 4>, > > > - <&a57_2 4 4>, > > > - <&a57_3 4 4>; > > > + trip = <&target>; > > > + cooling-device = <&a57_0 0 2>; > > > > We have 5 (0-4) cooling states for the A57s on this SoC. Out of > > curiosity why allow states 0-2 here and not force it do more cooling or > > keep the to max cooling (4) as before this change as this is set to a > > trip point with a rather large temperature? Not saying this is wrong > > only curious :-) > > This I do not know. Do you think it would be worth following-up on > internally? I'm no expert on this but I think it could be educational to learn why not the full range is used. Still this might be correct so I don't want to block this patch based on my ignorance. -- Regards, Niklas Söderlund From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DCA7C10F13 for ; Thu, 11 Apr 2019 16:47:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F17FA2146F for ; Thu, 11 Apr 2019 16:47:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="somwu9uC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ragnatech-se.20150623.gappssmtp.com header.i=@ragnatech-se.20150623.gappssmtp.com header.b="Vnh7M0nM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F17FA2146F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ragnatech.se Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NlLbHG/A3HPSEL70T24hLKd+ZgvH5YQqGdW8Dx9eyiQ=; b=somwu9uCluKrt5 Nsyrco8UqycEuzvPrTSKSBip90eiRDSNw7ULvJ8PGTVaQd6WJNvY5ZIPZuE7SLxCb0P1VSUmuk2Zi rVDKaa6x+z3PW3afNVVsewemXgBjWNX5rox6G/mPQrewCazbTcgQLg/SYTDVUYYzMKvFF+czjTwmF a8496Xi33pXCskv5SCa3dMTyCuZm7ACFyM7cj5tyXe0xl7eoI1/QI5m47gLoBnsoD+Y58VXoRt/Ef 05D2M2GG6OtU8i2E/fxsR0to8kzvanLDyFy2/jJjSoTnc0S332MKR6fDSBYYw9pJbh2BQNXA8wolz T4XoyzIoX7yeKq449XYg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEcrP-0001V8-Re; Thu, 11 Apr 2019 16:47:35 +0000 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEcrL-0001TS-EQ for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2019 16:47:33 +0000 Received: by mail-lj1-x234.google.com with SMTP id l7so6159628ljg.6 for ; Thu, 11 Apr 2019 09:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=7TOrm/pIUjywy+PcLxQavGH3pPV+PtonB7njN6vd3Vk=; b=Vnh7M0nM7lWbgVm8irPx5LIVNe97+r/gl4keZFc+9YVrPBx0FufjXVvUQCET7Thyyw tsljOfFLHNVZqbM3nlPfEEJpMYMO/61zmwdcqal2HOPCPWjmsx+Hb2+DQHY4pWhbrrRg SrgR0AM3sGNUj+D/c6jDTe/hrdjP94YkBxIOVxsKPsFzQi+Tn9ghmZbz5IbrL29G6EfN FFxekp41AhMIsg70/XHNnKiSdTrm3SRHmrAYHnQ+NLlK4o0pTeM56U+uG6Ab5L0WE7fe 5pCZOHzjufzYBFJ1z+qaJGQP8Ft+VSCjvzsaGb6qSR8mcbYJu1rB1pIp+b+Lw8NocFQV pZJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=7TOrm/pIUjywy+PcLxQavGH3pPV+PtonB7njN6vd3Vk=; b=PhrA664+5flZ7EVCKGX6m16X1QrRNI3aJzjQfsbcHrXJB8hL2OYOct9eVlCqSpu8M8 762O0BcN29okP7qy0O/dVqLRKmySd2QM0s4TSdPXHhj/4GmfxGhYTcwanPmYuI2q5BMo tsHZYVMu9i2P6muuWQj4HsfSlHFrxnyETU6tBRjmgRZb75rtjQEXaTKD2Bse4YEbdwTX EX8UL+84tH6D5mdYelSDwLBCV7wv1zjgGx88s0VgYorgyVA4OJvDa5hCwYrvseNoSwSS o6RG6PF8ZAlHrkQZzqaNEKLPfasb+TlAT5Y3tBKOgsZ3rQSYIYAJj3QKWl0+X7dboy/z bvSQ== X-Gm-Message-State: APjAAAXDQOeCZqzmFUoC8R5M17BKNI05aY16SgQumutVWjIKPHW6zxvV fPDPFrSM+mFhutNK1/HZcHh3Sw== X-Google-Smtp-Source: APXvYqyiUySD+Iexj0LgZ0MKP+TmhGxuIn8SCyQW6/VeGdC0Fx8RhazqSDDQf/mawoEXeCRLjORQ8Q== X-Received: by 2002:a2e:420c:: with SMTP id p12mr27591808lja.1.1555001247610; Thu, 11 Apr 2019 09:47:27 -0700 (PDT) Received: from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99]) by smtp.gmail.com with ESMTPSA id s24sm7778325ljs.30.2019.04.11.09.47.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Apr 2019 09:47:26 -0700 (PDT) Date: Thu, 11 Apr 2019 18:47:25 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Simon Horman Subject: Re: [PATCH/RFT] arm64: dts: renesas: r8a7795: Create thermal zone to support IPA Message-ID: <20190411164725.GE30887@bigcity.dyn.berto.se> References: <1545338982-19466-1-git-send-email-ykaneko0929@gmail.com> <20190110163356.GF24252@bigcity.dyn.berto.se> <20190408122941.wziujh5ibgwy5cdp@verge.net.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190408122941.wziujh5ibgwy5cdp@verge.net.au> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_094731_525559_C869C86D X-CRM114-Status: GOOD ( 16.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven , Magnus Damm , Yoshihiro Kaneko , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Simon, On 2019-04-08 14:29:41 +0200, Simon Horman wrote: > > > @@ -3172,11 +3158,15 @@ > > > = > > > cooling-maps { > > > map0 { > > > - trip =3D <&sensor3_passive>; > > > - cooling-device =3D <&a57_0 4 4>, > > > - <&a57_1 4 4>, > > > - <&a57_2 4 4>, > > > - <&a57_3 4 4>; > > > + trip =3D <&target>; > > > + cooling-device =3D <&a57_0 0 2>; > > = > > We have 5 (0-4) cooling states for the A57s on this SoC. Out of = > > curiosity why allow states 0-2 here and not force it do more cooling or = > > keep the to max cooling (4) as before this change as this is set to a = > > trip point with a rather large temperature? Not saying this is wrong = > > only curious :-) > = > This I do not know. Do you think it would be worth following-up on > internally? I'm no expert on this but I think it could be educational to learn why = not the full range is used. Still this might be correct so I don't want = to block this patch based on my ignorance. -- = Regards, Niklas S=F6derlund _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel