[clk:clk-fixes 4/4] WARNING: vmlinux.o(.text.unlikely+0x42409): Section mismatch in reference from the function pmc_setup_dev.isra.4() to the variable .init.rodata:critclk_systems

[clk:clk-fixes 4/4] WARNING: vmlinux.o(.text.unlikely+0x42409): Section mismatch in reference from the function pmc_setup_dev.isra.4() to the variable .init.rodata:critclk_systems

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-fixes
head:   7c2e07130090ae001a97a6b65597830d6815e93e
commit: 7c2e07130090ae001a97a6b65597830d6815e93e [4/4] clk: x86: Add system specific quirk to mark clocks as critical
config: x86_64-randconfig-s4-04111213 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        git checkout 7c2e07130090ae001a97a6b65597830d6815e93e
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

>> WARNING: vmlinux.o(.text.unlikely+0x42409): Section mismatch in reference from the function pmc_setup_dev.isra.4() to the variable .init.rodata:critclk_systems
   The function pmc_setup_dev.isra.4() references
   the variable __initconst critclk_systems.
   This is often because pmc_setup_dev.isra.4 lacks a __initconst
   annotation or the annotation of critclk_systems is wrong.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30814 bytes --]

[clk:clk-fixes 4/4] WARNING: vmlinux.o(.text.unlikely+0x42409): Section mismatch in reference from the function pmc_setup_dev.isra.4() to the variable .init.rodata:critclk_systems

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-fixes
head:   7c2e07130090ae001a97a6b65597830d6815e93e
commit: 7c2e07130090ae001a97a6b65597830d6815e93e [4/4] clk: x86: Add system specific quirk to mark clocks as critical
config: x86_64-randconfig-s4-04111213 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        git checkout 7c2e07130090ae001a97a6b65597830d6815e93e
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

>> WARNING: vmlinux.o(.text.unlikely+0x42409): Section mismatch in reference from the function pmc_setup_dev.isra.4() to the variable .init.rodata:critclk_systems
   The function pmc_setup_dev.isra.4() references
   the variable __initconst critclk_systems.
   This is often because pmc_setup_dev.isra.4 lacks a __initconst
   annotation or the annotation of critclk_systems is wrong.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30814 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [clk:clk-fixes 4/4] WARNING: vmlinux.o(.text.unlikely+0x42409): Section mismatch in reference from the function pmc_setup_dev.isra.4() to the variable .init.rodata:critclk_systems

[Stephen Boyd]

Quoting kbuild test robot (2019-04-11 02:25:41)
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-fixes
> head:   7c2e07130090ae001a97a6b65597830d6815e93e
> commit: 7c2e07130090ae001a97a6b65597830d6815e93e [4/4] clk: x86: Add system specific quirk to mark clocks as critical
> config: x86_64-randconfig-s4-04111213 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
>         git checkout 7c2e07130090ae001a97a6b65597830d6815e93e
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All warnings (new ones prefixed by >>):
> 
> >> WARNING: vmlinux.o(.text.unlikely+0x42409): Section mismatch in reference from the function pmc_setup_dev.isra.4() to the variable .init.rodata:critclk_systems
>    The function pmc_setup_dev.isra.4() references
>    the variable __initconst critclk_systems.
>    This is often because pmc_setup_dev.isra.4 lacks a __initconst
>    annotation or the annotation of critclk_systems is wrong.
> 

I don't know why there's __initconst there at all.

---8<----
diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
index eaec2d306481..c7039f52ad51 100644
--- a/drivers/platform/x86/pmc_atom.c
+++ b/drivers/platform/x86/pmc_atom.c
@@ -396,7 +396,7 @@ static int pmc_dbgfs_register(struct pmc_dev *pmc)
  * Some systems need one or more of their pmc_plt_clks to be
  * marked as critical.
  */
-static const struct dmi_system_id critclk_systems[] __initconst = {
+static const struct dmi_system_id critclk_systems[] = {
 	{
 		.ident = "MPL CEC1x",
 		.matches = {

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH] platform/x86: pmc_atom: Drop __initconst on dmi table

[Stephen Boyd]

It's used by probe and that isn't an init function. Drop this so that we
don't get a section mismatch.

Reported-by: kbuild test robot <lkp@intel.com>
Cc: David Müller <dave.mueller@gmx.ch>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Fixes: 7c2e07130090 ("clk: x86: Add system specific quirk to mark clocks as critical")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---
 drivers/platform/x86/pmc_atom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
index eaec2d306481..c7039f52ad51 100644
--- a/drivers/platform/x86/pmc_atom.c
+++ b/drivers/platform/x86/pmc_atom.c
@@ -396,7 +396,7 @@ static int pmc_dbgfs_register(struct pmc_dev *pmc)
  * Some systems need one or more of their pmc_plt_clks to be
  * marked as critical.
  */
-static const struct dmi_system_id critclk_systems[] __initconst = {
+static const struct dmi_system_id critclk_systems[] = {
 	{
 		.ident = "MPL CEC1x",
 		.matches = {
-- 
Sent by a computer through tubes

[PATCH] platform/x86: pmc_atom: Drop __initconst on dmi table

[Stephen Boyd]

It's used by probe and that isn't an init function. Drop this so that we
don't get a section mismatch.

Reported-by: kbuild test robot <lkp@intel.com>
Cc: David Müller <dave.mueller@gmx.ch>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Fixes: 7c2e07130090 ("clk: x86: Add system specific quirk to mark clocks as critical")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---
 drivers/platform/x86/pmc_atom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
index eaec2d306481..c7039f52ad51 100644
--- a/drivers/platform/x86/pmc_atom.c
+++ b/drivers/platform/x86/pmc_atom.c
@@ -396,7 +396,7 @@ static int pmc_dbgfs_register(struct pmc_dev *pmc)
  * Some systems need one or more of their pmc_plt_clks to be
  * marked as critical.
  */
-static const struct dmi_system_id critclk_systems[] __initconst = {
+static const struct dmi_system_id critclk_systems[] = {
 	{
 		.ident = "MPL CEC1x",
 		.matches = {
-- 
Sent by a computer through tubes


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] platform/x86: pmc_atom: Drop __initconst on dmi table

[Hans de Goede]

Hi Stephen,

On 11-04-19 19:28, Stephen Boyd wrote:
> It's used by probe and that isn't an init function. Drop this so that we
> don't get a section mismatch.
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Cc: David Müller <dave.mueller@gmx.ch>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Fixes: 7c2e07130090 ("clk: x86: Add system specific quirk to mark clocks as critical")
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>

Thank you for fixing this, I agree that this is the correct fix:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>   drivers/platform/x86/pmc_atom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
> index eaec2d306481..c7039f52ad51 100644
> --- a/drivers/platform/x86/pmc_atom.c
> +++ b/drivers/platform/x86/pmc_atom.c
> @@ -396,7 +396,7 @@ static int pmc_dbgfs_register(struct pmc_dev *pmc)
>    * Some systems need one or more of their pmc_plt_clks to be
>    * marked as critical.
>    */
> -static const struct dmi_system_id critclk_systems[] __initconst = {
> +static const struct dmi_system_id critclk_systems[] = {
>   	{
>   		.ident = "MPL CEC1x",
>   		.matches = {
> 

Re: [PATCH] platform/x86: pmc_atom: Drop __initconst on dmi table

[Hans de Goede]

Hi Stephen,

On 11-04-19 19:28, Stephen Boyd wrote:
> It's used by probe and that isn't an init function. Drop this so that we
> don't get a section mismatch.
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Cc: David Müller <dave.mueller@gmx.ch>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Fixes: 7c2e07130090 ("clk: x86: Add system specific quirk to mark clocks as critical")
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>

Thank you for fixing this, I agree that this is the correct fix:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>   drivers/platform/x86/pmc_atom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
> index eaec2d306481..c7039f52ad51 100644
> --- a/drivers/platform/x86/pmc_atom.c
> +++ b/drivers/platform/x86/pmc_atom.c
> @@ -396,7 +396,7 @@ static int pmc_dbgfs_register(struct pmc_dev *pmc)
>    * Some systems need one or more of their pmc_plt_clks to be
>    * marked as critical.
>    */
> -static const struct dmi_system_id critclk_systems[] __initconst = {
> +static const struct dmi_system_id critclk_systems[] = {
>   	{
>   		.ident = "MPL CEC1x",
>   		.matches = {
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel