All of lore.kernel.org
 help / color / mirror / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: Re: [PATCH] send-email: default to quoted-printable when CR is present
Date: Fri, 12 Apr 2019 00:01:07 +0000	[thread overview]
Message-ID: <20190412000107.GK12419@genre.crustytoothpaste.net> (raw)
In-Reply-To: <CAPig+cT5-r=QqVDcD7viJj0-fPp+6OjnKq8aP4NLwKNdrAHFKw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

On Thu, Apr 11, 2019 at 01:44:06PM -0400, Eric Sunshine wrote:
> On Wed, Apr 10, 2019 at 7:35 PM brian m. carlson
> <sandals@crustytoothpaste.net> wrote:
> > [...]
> > Note that we are guaranteed to always correctly encode carriage returns
> > when writing quoted-printable since we explicitly specify the line
> > ending as "\n", forcing MIME::QuotedPrint to encode our carriage return
> > as "=OD".
> 
> s/=OD/=0D/
> 
> (That is, replace capital "O" with zero "0".)

Ah, yes. Thanks for pointing that out.

I'll wait to see if there's any other feedback and then reroll.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]

  reply	other threads:[~2019-04-12  0:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-10 23:34 [PATCH] send-email: default to quoted-printable when CR is present brian m. carlson
2019-04-11 17:44 ` Eric Sunshine
2019-04-12  0:01   ` brian m. carlson [this message]
2019-04-13 22:45 ` [PATCH v2] " brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190412000107.GK12419@genre.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sunshine@sunshineco.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.