From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v6] drm/i915/icl: Fix clockgating issue when
 using scalers
Date: Fri, 12 Apr 2019 10:25:03 +0300
Message-ID: <20190412072503.GG3888@intel.com>
References: <20190405150700.GL3888@intel.com>
 <20190405211437.8143-1-radhakrishna.sripada@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 9B2C7896E4
 for <intel-gfx@lists.freedesktop.org>; Fri, 12 Apr 2019 07:25:08 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190405211437.8143-1-radhakrishna.sripada@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBBcHIgMDUsIDIwMTkgYXQgMDI6MTQ6MzdQTSAtMDcwMCwgUmFkaGFrcmlzaG5hIFNy
aXBhZGEgd3JvdGU6Cj4gRml4ZXMgdGhlIGNsb2NrLWdhdGluZyBpc3N1ZSB3aGVuIHBpcGUgc2Nh
bGluZyBpcyBlbmFibGVkLgo+IChMaW5lYWdlICMyMDA2NjA0MzEyKQo+IAo+IFYyOiBGaXggdHlw
byBpbiBoZWFkbGluZShDaHJpcykKPiAgICAgSGFuZGxlIHRoZSBub24gZG91YmxlIGJ1ZmZlcmVk
IG5hdHVyZSBvZiB0aGUgcmVnaXN0ZXIoVmlsbGUpCj4gVjM6IEZpeCBjaGVja3BhdGNoIHdhcm5p
bmcuIEJBVCBmYWlsdXJlIGZvciBWMiBvbiBnZW4zIGxvb2tzIHVucmVsYXRlZC4KPiBWNDogU3Bs
aXQgdGhlIGljbCBhbmQgc2tsIHdhJ3MoVmlsbGUpCj4gVjU6IFNwbGl0IHRoZSBjaGVja3MgZm9y
IGljbCBhbmQgc2tsKFZpbGxlKQo+IFY2OiBDb3JyZWN0IHRoZSBmbGlwcGVkIGNoZWNrcyBpbiBp
bnRlbF9wcmVfcGxhbmVfdXBkYXRlKFZpbGxlKQo+IAo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlz
QGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBs
aW51eC5pbnRlbC5jb20+Cj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNv
bT4KPiBDYzogQWRpdHlhIFN3YXJ1cCA8YWRpdHlhLnN3YXJ1cEBpbnRlbC5jb20+Cj4gU2lnbmVk
LW9mZi1ieTogUmFkaGFrcmlzaG5hIFNyaXBhZGEgPHJhZGhha3Jpc2huYS5zcmlwYWRhQGludGVs
LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMzkg
KysrKysrKysrKysrKysrKysrKysrKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMzQgaW5zZXJ0
aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh
eS5jCj4gaW5kZXggY2Y2MDQ2MzkwZWViLi5hYjgyMGNhZDk5MGQgMTAwNjQ0Cj4gLS0tIGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTQ2Niw2ICs0NjYsNyBAQCBzdGF0aWMgY29uc3Qg
c3RydWN0IGludGVsX2xpbWl0IGludGVsX2xpbWl0c19ieHQgPSB7Cj4gIAkucDIgPSB7IC5wMl9z
bG93ID0gMSwgLnAyX2Zhc3QgPSAyMCB9LAo+ICB9Owo+ICAKPiArLyogV0EgRGlzcGxheSAjMDgy
NzogR2VuOTphbGwgKi8KPiAgc3RhdGljIHZvaWQKPiAgc2tsX3dhXzgyNyhzdHJ1Y3QgZHJtX2k5
MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGludCBwaXBlLCBib29sIGVuYWJsZSkKPiAgewo+IEBAIC00
NzksNiArNDgwLDE4IEBAIHNrbF93YV84Mjcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w
cml2LCBpbnQgcGlwZSwgYm9vbCBlbmFibGUpCj4gIAkJCSAgIH4oRFVQUzFfR0FUSU5HX0RJUyB8
IERVUFMyX0dBVElOR19ESVMpKTsKPiAgfQo+ICAKPiArLyogV2FfMjAwNjYwNDMxMjppY2wgKi8K
PiArc3RhdGljIHZvaWQKPiAraWNsX3dhX3NjYWxlcmNsa2dhdGluZyhzdHJ1Y3QgZHJtX2k5MTVf
cHJpdmF0ZSAqZGV2X3ByaXYsIGludCBwaXBlLCBib29sIGVuYWJsZSkKCmVudW0gcGlwZSBwbGVh
c2UKCj4gK3sKPiArCWlmIChlbmFibGUpCj4gKwkJSTkxNV9XUklURShDTEtHQVRFX0RJU19QU0wo
cGlwZSksCj4gKwkJCSAgIEk5MTVfUkVBRChDTEtHQVRFX0RJU19QU0wocGlwZSkpIHwgRFBGUl9H
QVRJTkdfRElTKTsKPiArCWVsc2UKPiArCQlJOTE1X1dSSVRFKENMS0dBVEVfRElTX1BTTChwaXBl
KSwKPiArCQkJICAgSTkxNV9SRUFEKENMS0dBVEVfRElTX1BTTChwaXBlKSkgJiB+RFBGUl9HQVRJ
TkdfRElTKTsKPiArfQo+ICsKPiAgc3RhdGljIGJvb2wKPiAgbmVlZHNfbW9kZXNldChjb25zdCBz
dHJ1Y3QgZHJtX2NydGNfc3RhdGUgKnN0YXRlKQo+ICB7Cj4gQEAgLTU0OTUsNiArNTUwOCwxNiBA
QCBzdGF0aWMgYm9vbCBuZWVkc19udjEyX3dhKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf
cHJpdiwKPiAgCXJldHVybiBmYWxzZTsKPiAgfQo+ICAKPiArc3RhdGljIGJvb2wgbmVlZHNfc2Nh
bGVyY2xrX3dhKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiArCQkJICAgICAg
IGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICt7Cj4gKwkvKiBX
YV8yMDA2NjA0MzEyOmljbCAqLwo+ICsJaWYgKGNydGNfc3RhdGUtPnBjaF9wZml0LmVuYWJsZWQg
JiYgSVNfSUNFTEFLRShkZXZfcHJpdikpCj4gKwkJcmV0dXJuIHRydWU7CgpBZnRlciByZWFkaW5n
IHRoZSB3L2EgZGVzY3JpcHRpb24gSSByZWFsaXplIHRoYXQgdGhpcyBpc24ndCBxdWl0ZQpzdWZm
aWNpZW50LiBBcHBhcmVudGx5IHdlIG5lZWQgdG8gZG8gdGhlIHNhbWUgdGhpbmcgZm9yIHBsYW5l
IHNjYWxpbmcuCgpJIHdhcyBnb2luZyB0byBzdWdnZXN0IGFkZGluZyBhIHNjYWxlZF9wbGFuZXMg
Yml0bWFzayAobGlrZSB3ZSBoYXZlCnthY3RpdmUsYzgsbnYxMn1fcGxhbmVzKSBidXQgYWN0dWFs
bHkgd2UgbWlndGggbm90IG5lZWQgdG8gZG8gdGhhdApzaW5jZSB3ZSBhbHJlYWR5IGhhdmUgdGhl
IHNjYWxlcl91c2VycyB0aGluZyBvbiBza2wrLiBJIHRoaW5rIEkgaGFkCnNvbWUgb3RoZXIgdXNl
IGluIG1pbmQgZm9yIHNjYWxlZF9wbGFuZXMgdG9vIGJ1dCBJIGNhbid0IHJlbWVtYmVyCndoYXQg
aXQgd2FzIHJpZ2h0IG5vdy4KCkkndmUgcHVzaGVkIHBhdGNoZXMgMSBhbmQgMiBpbiB0aGUgbWVh
bnRpbWUuIFRoYW5rcy4KCj4gKwo+ICsJcmV0dXJuIGZhbHNlOwo+ICt9Cj4gKwo+ICBzdGF0aWMg
dm9pZCBpbnRlbF9wb3N0X3BsYW5lX3VwZGF0ZShzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xk
X2NydGNfc3RhdGUpCj4gIHsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gdG9faW50ZWxf
Y3J0YyhvbGRfY3J0Y19zdGF0ZS0+YmFzZS5jcnRjKTsKPiBAQCAtNTUyOCwxMSArNTU1MSwxMyBA
QCBzdGF0aWMgdm9pZCBpbnRlbF9wb3N0X3BsYW5lX3VwZGF0ZShzdHJ1Y3QgaW50ZWxfY3J0Y19z
dGF0ZSAqb2xkX2NydGNfc3RhdGUpCj4gIAkJCWludGVsX3Bvc3RfZW5hYmxlX3ByaW1hcnkoJmNy
dGMtPmJhc2UsIHBpcGVfY29uZmlnKTsKPiAgCX0KPiAgCj4gLQkvKiBEaXNwbGF5IFdBIDgyNyAq
Lwo+ICAJaWYgKG5lZWRzX252MTJfd2EoZGV2X3ByaXYsIG9sZF9jcnRjX3N0YXRlKSAmJgo+IC0J
ICAgICFuZWVkc19udjEyX3dhKGRldl9wcml2LCBwaXBlX2NvbmZpZykpIHsKPiArCSAgICAhbmVl
ZHNfbnYxMl93YShkZXZfcHJpdiwgcGlwZV9jb25maWcpKQo+ICAJCXNrbF93YV84MjcoZGV2X3By
aXYsIGNydGMtPnBpcGUsIGZhbHNlKTsKPiAtCX0KPiArCj4gKwlpZiAobmVlZHNfc2NhbGVyY2xr
X3dhKGRldl9wcml2LCBvbGRfY3J0Y19zdGF0ZSkgJiYKPiArCSAgICAhbmVlZHNfc2NhbGVyY2xr
X3dhKGRldl9wcml2LCBwaXBlX2NvbmZpZykpCj4gKwkJaWNsX3dhX3NjYWxlcmNsa2dhdGluZyhk
ZXZfcHJpdiwgY3J0Yy0+cGlwZSwgZmFsc2UpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBpbnRl
bF9wcmVfcGxhbmVfdXBkYXRlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0
ZSwKPiBAQCAtNTU2OSw5ICs1NTk0LDEzIEBAIHN0YXRpYyB2b2lkIGludGVsX3ByZV9wbGFuZV91
cGRhdGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlLAo+ICAKPiAgCS8q
IERpc3BsYXkgV0EgODI3ICovCj4gIAlpZiAoIW5lZWRzX252MTJfd2EoZGV2X3ByaXYsIG9sZF9j
cnRjX3N0YXRlKSAmJgo+IC0JICAgIG5lZWRzX252MTJfd2EoZGV2X3ByaXYsIHBpcGVfY29uZmln
KSkgewo+ICsJICAgIG5lZWRzX252MTJfd2EoZGV2X3ByaXYsIHBpcGVfY29uZmlnKSkKPiAgCQlz
a2xfd2FfODI3KGRldl9wcml2LCBjcnRjLT5waXBlLCB0cnVlKTsKPiAtCX0KPiArCj4gKwkvKiBX
YV8yMDA2NjA0MzEyOmljbCAqLwo+ICsJaWYgKCFuZWVkc19zY2FsZXJjbGtfd2EoZGV2X3ByaXYs
IG9sZF9jcnRjX3N0YXRlKSAmJgo+ICsJICAgIG5lZWRzX3NjYWxlcmNsa193YShkZXZfcHJpdiwg
cGlwZV9jb25maWcpKQo+ICsJCWljbF93YV9zY2FsZXJjbGtnYXRpbmcoZGV2X3ByaXYsIGNydGMt
PnBpcGUsIHRydWUpOwo+ICAKPiAgCS8qCj4gIAkgKiBWYmxhbmsgdGltZSB1cGRhdGVzIGZyb20g
dGhlIHNoYWRvdyB0byBsaXZlIHBsYW5lIGNvbnRyb2wgcmVnaXN0ZXIKPiAtLSAKPiAyLjIwLjAu
cmMyLjcuZzk2NTc5OGQxZjI5OQoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs
aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz
a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=