Re: [Qemu-devel] [PATCH 01/17] include: Include fprintf-fn.h only where needed

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Markus Armbruster (armbru@redhat.com) wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  include/qemu-common.h | 2 --
>  include/qemu/cutils.h | 2 --
>  include/sysemu/cpus.h | 1 +
>  3 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/include/qemu-common.h b/include/qemu-common.h
> index a102245519..f891e05e7e 100644
> --- a/include/qemu-common.h
> +++ b/include/qemu-common.h
> @@ -12,8 +12,6 @@
>  #ifndef QEMU_COMMON_H
>  #define QEMU_COMMON_H
>  
> -#include "qemu/fprintf-fn.h"
> -
>  #define TFR(expr) do { if ((expr) != -1) break; } while (errno == EINTR)
>  
>  /* Copyright string for -version arguments, About dialogs, etc */
> diff --git a/include/qemu/cutils.h b/include/qemu/cutils.h
> index d2dad3057c..12301340a4 100644
> --- a/include/qemu/cutils.h
> +++ b/include/qemu/cutils.h
> @@ -1,8 +1,6 @@
>  #ifndef QEMU_CUTILS_H
>  #define QEMU_CUTILS_H
>  
> -#include "qemu/fprintf-fn.h"
> -
>  /**
>   * pstrcpy:
>   * @buf: buffer to copy string into
> diff --git a/include/sysemu/cpus.h b/include/sysemu/cpus.h
> index 731756d948..eea0010b53 100644
> --- a/include/sysemu/cpus.h
> +++ b/include/sysemu/cpus.h
> @@ -1,6 +1,7 @@
>  #ifndef QEMU_CPUS_H
>  #define QEMU_CPUS_H
>  
> +#include "qemu/fprintf-fn.h"
>  #include "qemu/timer.h"
>  
>  /* cpus.c */
> -- 
> 2.17.2
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK