From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64D5AC10F0E for ; Fri, 12 Apr 2019 19:12:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D1F920663 for ; Fri, 12 Apr 2019 19:12:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726886AbfDLTMT (ORCPT ); Fri, 12 Apr 2019 15:12:19 -0400 Received: from mga04.intel.com ([192.55.52.120]:31764 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726755AbfDLTMT (ORCPT ); Fri, 12 Apr 2019 15:12:19 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2019 12:12:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,342,1549958400"; d="scan'208";a="133862140" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.181]) by orsmga008.jf.intel.com with ESMTP; 12 Apr 2019 12:12:18 -0700 Date: Fri, 12 Apr 2019 12:12:18 -0700 From: Sean Christopherson To: Paolo Bonzini Cc: Radim =?utf-8?B?S3LEjW3DocWZ?= , kvm@vger.kernel.org, Krish Sadhukhan , Karl Heubaum , Jim Mattson Subject: Re: [PATCH v6 5/7] KVM: nVMX: Set VM-{Fail,Exit} failure info via params, not return val Message-ID: <20190412191218.GC21957@linux.intel.com> References: <20190411191809.8131-1-sean.j.christopherson@intel.com> <20190411191809.8131-6-sean.j.christopherson@intel.com> <3828cf0c-83bf-c948-301b-bc2114f63ae8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3828cf0c-83bf-c948-301b-bc2114f63ae8@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Apr 12, 2019 at 10:30:51AM +0200, Paolo Bonzini wrote: > On 11/04/19 21:18, Sean Christopherson wrote: > > Convert all top-level nested VM-Enter consistency check functions to > > use explicit parameters to pass failure information to the caller. > > Using an explicit parameter achieves several goals: > > > > - Provides consistent prototypes for all functions. > > - Self-documents the net effect of failure, e.g. without the explicit > > parameter it may not be obvious that nested_vmx_check_guest_state() > > leads to a VM-Exit. > > - Does not give the false impression that failure information is > > always consumed and/or relevant, e.g. vmx_set_nested_state() only > > cares whether or not the checks were successful. > > > > Suggested-by: Paolo Bonzini > > Signed-off-by: Sean Christopherson > > --- > > I think we have to agree to disagree on this one. :) Aaargh! The dreaded Maintainer Hammer of Doom! LGTM ;-)