From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC364C10F13 for ; Sun, 14 Apr 2019 20:50:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 897BD20850 for ; Sun, 14 Apr 2019 20:50:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727020AbfDNUuc (ORCPT ); Sun, 14 Apr 2019 16:50:32 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44102 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726461AbfDNUuc (ORCPT ); Sun, 14 Apr 2019 16:50:32 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BC3C414C711D0; Sun, 14 Apr 2019 13:50:31 -0700 (PDT) Date: Sun, 14 Apr 2019 13:50:31 -0700 (PDT) Message-Id: <20190414.135031.1978359258337057539.davem@davemloft.net> To: hkallweit1@gmail.com Cc: nic_swsd@realtek.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next 0/2] r8169: create function pointer arrays for PHY and chip hw init functions From: David Miller In-Reply-To: <4cb6d89c-144b-6e9a-1a1e-1085452b96c2@gmail.com> References: <4cb6d89c-144b-6e9a-1a1e-1085452b96c2@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 14 Apr 2019 13:50:31 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Sun, 14 Apr 2019 10:29:23 +0200 > Using function pointer arrays makes the code easier to read and better > maintainable. AFAIK function pointer arrays cause some performance > drawback due to Spectre mitigation, but we're not in a hot path. Series applied, thanks.