Hi, On Thu, Apr 11, 2019 at 11:44:19PM +0200, Clément Péron wrote: > Allwinner H6 has a SPDIF controller with an increase of the fifo > size and the possibility to output the master clock. > However it's still compatible with the already existing driver for > Allwiner H3. > > Add this compatible in the device-tree bindings documentation. How was this tested? After looking at the datasheet, it looks like it's still significantly different. In particular: - The MCLK divider isn't at the same offset - The bits to flush the FIFO aren't at the same offset - The FIFO trigger levels aren't at the same offset - The FIFO status register layout is almost entirely different So it doesn't really look compatible to me Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com