From: Adrian Bunk <bunk@stusta.de>
To: richard.purdie@linuxfoundation.org
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2] nettle: fix ptest failure
Date: Mon, 15 Apr 2019 11:39:57 +0300 [thread overview]
Message-ID: <20190415083957.GA4317@localhost> (raw)
In-Reply-To: <21cc3e7248d8e702f49de8818f26e2e53a001ed1.camel@linuxfoundation.org>
On Mon, Apr 15, 2019 at 09:06:12AM +0100, richard.purdie@linuxfoundation.org wrote:
> On Mon, 2019-04-15 at 16:09 +0800, Yu, Mingli wrote:
> >
> > On 2019年04月15日 15:59, richard.purdie@linuxfoundation.org wrote:
> > > On Mon, 2019-04-15 at 15:40 +0800, mingli.yu@windriver.com wrote:
> > > > ---- a/testsuite/dlopen-test.c 2016-10-01 00:28:38.000000000
> > > > -0700
> > > > -+++ b/testsuite/dlopen-test.c 2017-10-13 11:08:57.227572860
> > > > -0700
> > > > -@@ -9,7 +9,7 @@
> > > > +diff --git a/testsuite/dlopen-test.c b/testsuite/dlopen-test.c
> > > > +index 99d3535..92de9f8 100644
> > > > +--- a/testsuite/dlopen-test.c
> > > > ++++ b/testsuite/dlopen-test.c
> > > > +@@ -9,7 +9,9 @@ int
> > > > main (int argc UNUSED, char **argv UNUSED)
> > > > {
> > > > #if HAVE_LIBDL
> > > > - void *handle = dlopen ("../libnettle.so", RTLD_NOW);
> > > > + void *handle = dlopen ("/usr/lib/libnettle.so", RTLD_NOW);
> > > > ++ if (!handle)
> > > > ++ handle = dlopen ("/usr/lib64/libnettle.so", RTLD_NOW);
> > > > int (*get_version)(void);
> > > > if (!handle)
> > > > {
> > >
> > > What happens on a 32 bit system?
> > >
> > > You can't hardcode a specific libdir like that!
> >
> > I just rework the patch dlopen-test.patch which Juro Bystricky
> > generated
> > before, the previous patch only check /usr/lib/libnettle.so and I
> > updated it also to check /usr/lib64/libnettle.so if no
> > /usr/lib/libnettle.so exist.
> > - void *handle = dlopen ("../libnettle.so", RTLD_NOW);
> > + void *handle = dlopen ("/usr/lib/libnettle.so", RTLD_NOW);
> > ++ if (!handle)
> > ++ handle = dlopen ("/usr/lib64/libnettle.so", RTLD_NOW);
>
> What happens on x32? n32? or if I set libdir to lib32?
dlopen("libnettle.so", RTLD_NOW) should work,
this uses the normal library search path.
But is it actually worth permanently carrying a patch here?
run-ptest already skips one test for unrelated reasons,
and skipping another one would also be an option.
> Cheers,
>
> Richard
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2019-04-15 8:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 3:27 [PATCH] nettle: fix ptest failure mingli.yu
2019-04-12 21:57 ` Richard Purdie
2019-04-15 2:10 ` Yu, Mingli
2019-04-15 7:40 ` [PATCH v2] " mingli.yu
2019-04-15 7:59 ` richard.purdie
2019-04-15 8:09 ` Yu, Mingli
2019-04-15 8:06 ` richard.purdie
2019-04-15 8:39 ` Adrian Bunk [this message]
2019-04-15 8:43 ` Yu, Mingli
2019-04-15 9:05 ` [PATCH v3] " mingli.yu
2019-04-15 11:08 ` richard.purdie
2019-04-16 3:14 ` Yu, Mingli
2019-04-18 5:30 ` Yu, Mingli
2019-04-24 8:41 ` [PATCH v4 1/2] nettle: fix the Segmentation fault mingli.yu
2019-04-24 8:41 ` [PATCH v4 2/2] nettle: fix ptest failure mingli.yu
2019-04-24 9:21 ` [PATCH v4 1/2] nettle: fix the Segmentation fault Adrian Bunk
2019-04-29 6:48 ` Yu, Mingli
2019-05-11 1:27 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415083957.GA4317@localhost \
--to=bunk@stusta.de \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.