From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7EB2C10F12 for ; Mon, 15 Apr 2019 19:03:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2FB920880 for ; Mon, 15 Apr 2019 19:03:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555354999; bh=TRbjqahbdfBUxDCfCH+4t6kvwnI+9cf2RLkSjTmoMeg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2kkAQW/erW2saBYCiKkkPwSxVznAAs/7DONWDtzlvNcjiux/efPG8gzjYLHH5qMz3 BLGMbQq7Ji7stQFkpRTyab9WEs/OVQbR0O0gyzqiOCHlrDa+sZ0pRAyQ1Yw5mo8NNr asJ8a+NF6j4xgr5jfi6iX18iR7BHC5hg9hOxrV5I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729186AbfDOTDS (ORCPT ); Mon, 15 Apr 2019 15:03:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:34970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728218AbfDOTDQ (ORCPT ); Mon, 15 Apr 2019 15:03:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 45FBD20880; Mon, 15 Apr 2019 19:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555354995; bh=TRbjqahbdfBUxDCfCH+4t6kvwnI+9cf2RLkSjTmoMeg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0Uq8KFkmy8YFiLjRdChMFoj9RgLAQlfQAEQSchTbte2mrwlS1h826elni8fLI2/g8 Vu6UNy9fNNV4STbSakMX8graTslUyGU3nvcmZLTaYcYFWrAebND6UK63q3jgXZdq2V sXGX1fxfGMyW/djVQau32OTW+UKDe+7BPw4nZNtU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Gavi Teitz , Roi Dayan , Saeed Mahameed Subject: [PATCH 4.14 28/69] net/mlx5e: Fix error handling when refreshing TIRs Date: Mon, 15 Apr 2019 20:58:46 +0200 Message-Id: <20190415183731.346586583@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190415183726.036654568@linuxfoundation.org> References: <20190415183726.036654568@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gavi Teitz [ Upstream commit bc87a0036826a37b43489b029af8143bd07c6cca ] Previously, a false positive would be caught if the TIRs list is empty, since the err value was initialized to -ENOMEM, and was only updated if a TIR is refreshed. This is resolved by initializing the err value to zero. Fixes: b676f653896a ("net/mlx5e: Refactor refresh TIRs") Signed-off-by: Gavi Teitz Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx5/core/en_common.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/drivers/net/ethernet/mellanox/mlx5/core/en_common.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_common.c @@ -140,15 +140,17 @@ int mlx5e_refresh_tirs(struct mlx5e_priv { struct mlx5_core_dev *mdev = priv->mdev; struct mlx5e_tir *tir; - int err = -ENOMEM; + int err = 0; u32 tirn = 0; int inlen; void *in; inlen = MLX5_ST_SZ_BYTES(modify_tir_in); in = kvzalloc(inlen, GFP_KERNEL); - if (!in) + if (!in) { + err = -ENOMEM; goto out; + } if (enable_uc_lb) MLX5_SET(modify_tir_in, in, ctx.self_lb_block,