All of lore.kernel.org
 help / color / mirror / Atom feed
From: nadav.amit@gmail.com
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Nadav Amit <nadav.amit@gmail.com>,
	Sean Christopherson <sean.j.christopherson@intel.com>
Subject: [kvm-unit-tests PATCH v2] x86: Remove INIT deassert
Date: Mon, 15 Apr 2019 15:14:21 -0700	[thread overview]
Message-ID: <20190415221421.20903-1-nadav.amit@gmail.com> (raw)

From: Nadav Amit <nadav.amit@gmail.com>

Currently, the INIT deassert is marked as an edge event instead of a
level, which is wrong. The deassert is actually not needed, as the
arbitration ID should have already been set after boot, and is not
affected by further INIT IPIs.

Remove the INIT deassert for these reasons.

Cc: Sean Christopherson <sean.j.christopherson@intel.com>
Signed-off-by: Nadav Amit <nadav.amit@gmail.com>
---
 x86/cstart.S   | 1 -
 x86/cstart64.S | 1 -
 2 files changed, 2 deletions(-)

diff --git a/x86/cstart.S b/x86/cstart.S
index 143317e..79c5024 100644
--- a/x86/cstart.S
+++ b/x86/cstart.S
@@ -186,7 +186,6 @@ smp_init:
 	rep/movsb
 	mov $APIC_DEFAULT_PHYS_BASE, %eax
 	movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_INIT | APIC_INT_ASSERT), APIC_ICR(%eax)
-	movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_INIT), APIC_ICR(%eax)
 	movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_STARTUP), APIC_ICR(%eax)
 	call fwcfg_get_nb_cpus
 1:	pause
diff --git a/x86/cstart64.S b/x86/cstart64.S
index 21db10f..e38767b 100644
--- a/x86/cstart64.S
+++ b/x86/cstart64.S
@@ -285,7 +285,6 @@ smp_init:
 	rep/movsb
 	mov $APIC_DEFAULT_PHYS_BASE, %eax
 	movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_INIT | APIC_INT_ASSERT), APIC_ICR(%rax)
-	movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_INIT), APIC_ICR(%rax)
 	movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_STARTUP), APIC_ICR(%rax)
 	call fwcfg_get_nb_cpus
 1:	pause
-- 
2.17.1


             reply	other threads:[~2019-04-15 22:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15 22:14 nadav.amit [this message]
2019-04-15 22:27 ` [kvm-unit-tests PATCH v2] x86: Remove INIT deassertg Sean Christopherson
2019-04-16  8:28   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190415221421.20903-1-nadav.amit@gmail.com \
    --to=nadav.amit@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.