From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,6/7] usb: typec: displayport: Export probe and remove functions From: Heikki Krogerus Message-Id: <20190416074607.GC1747@kuha.fi.intel.com> Date: Tue, 16 Apr 2019 10:46:07 +0300 To: Ajay Gupta Cc: Greg Kroah-Hartman , "linux-usb@vger.kernel.org" List-ID: T24gVHVlLCBBcHIgMTYsIDIwMTkgYXQgMDk6Mjc6MDNBTSArMDMwMCwgSGVpa2tpIEtyb2dlcnVz IHdyb3RlOgo+IE9uIFR1ZSwgQXByIDE2LCAyMDE5IGF0IDEyOjQ1OjEyQU0gKzAwMDAsIEFqYXkg R3VwdGEgd3JvdGU6Cj4gPiBIaSBIZWlra2ksCj4gPiAKPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNz YWdlLS0tLS0KPiA+ID4gRnJvbTogbGludXgtdXNiLW93bmVyQHZnZXIua2VybmVsLm9yZyA8bGlu dXgtdXNiLW93bmVyQHZnZXIua2VybmVsLm9yZz4gT24KPiA+ID4gQmVoYWxmIE9mIEhlaWtraSBL cm9nZXJ1cwo+ID4gPiBTZW50OiBNb25kYXksIEFwcmlsIDE1LCAyMDE5IDU6MTAgQU0KPiA+ID4g VG86IEdyZWcgS3JvYWgtSGFydG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Cj4gPiA+ IENjOiBBamF5IEd1cHRhIDxhamF5Z0BudmlkaWEuY29tPjsgbGludXgtdXNiQHZnZXIua2VybmVs Lm9yZwo+ID4gPiBTdWJqZWN0OiBbUEFUQ0ggdjIgNi83XSB1c2I6IHR5cGVjOiBkaXNwbGF5cG9y dDogRXhwb3J0IHByb2JlIGFuZCByZW1vdmUKPiA+ID4gZnVuY3Rpb25zCj4gPiA+IAo+ID4gPiBG cm9tOiBBamF5IEd1cHRhIDxhamF5Z0BudmlkaWEuY29tPgo+ID4gPiAKPiA+ID4gVmlydHVhbExp bmsgc3RhbmRhcmQgZXh0ZW5kcyB0aGUgRGlzcGxheVBvcnQgQWx0IE1vZGUgYnkgdXRpbGl6aW5n IGFsc28gdGhlIFVTQiAyCj4gPiA+IHBpbnMgb24gdGhlIFVTQiBUeXBlLUMgY29ubmVjdG9yLgo+ ID4gPiBJdCB1c2VzIHRoZSBzYW1lIG1lc3NhZ2VzIGFzIERpc3BsYXlQb3J0LCBidXQgbm90IHRo ZSBEUCBTVklELiBBdCB0aGUgdGltZSBvZgo+ID4gPiB3cml0aW5nLCBVU0IgSUYgaGFzIG5vdCBh c3NpZ25lZCBhIFN0YW5kYXJkIElEIChTSUQpIGZvciBWaXJ0dWFsTGluaywgc28gdGhlCj4gPiA+ IG1hbnVmYWN0dXJlcnMgb2YgVmlydHVhbExpbmsgYWRhcHRlcnMgdXNlIHRoZWlyIFZlbmRvciBJ RHMgYXMgdGhlIFNWSUQuCj4gPiA+IAo+ID4gPiBTaW5jZSB0aGUgU1ZJRCBzcGVjaWZpYyBjb21t dW5pY2F0aW9uIGlzIGV4YWN0bHkgdGhlIHNhbWUgYXMgd2l0aCBEaXNwbGF5UG9ydAo+ID4gPiBh bHRlcm5hdGUgbW9kZSwgdGhlcmUgaXMgbm8gbmVlZCB0byBpbXBsZW1lbnQgc2VwYXJhdGUgZHJp dmVyIGZvciBWaXJ0dWFsTGluay4KPiA+ID4gV2UnbGwgaGFuZGxlIHRoZSBjdXJyZW50IFZpcnR1 YWxMaW5rIGFkYXB0ZXJzIHdpdGggcHJvYmUgZHJpdmVycywgYW5kIG9uY2UgdGhlcmUKPiA+ID4g aXMgU1ZJRCBhc3NpZ25lZCBmb3IgaXQsIHdlIGFkZCBpdCB0byB0aGUgZGlzcGxheXBvcnQgYWx0 IG1vZGUgZHJpdmVyLgo+ID4gPiAKPiA+ID4gVG8gc3VwcG9ydCBwcm9iaW5nIGRyaXZlcnMsIGV4 cG9ydGluZyB0aGUgcHJvYmUgYW5kIHJlbW92ZSBmdW5jdGlvbnMsIGFuZCBhbHNvCj4gPiA+IGNo YW5naW5nIHRoZSBEUF9IRUFERVIgaGVscGVyIG1hY3JvIHRvIHVzZSB0aGUgU1ZJRCBvZiB0aGUg YWx0ZXJuYXRlIG1vZGUKPiA+ID4gZGV2aWNlIGluc3RlYWQgb2YgdGhlIERpc3BsYXlQb3J0IGFs dCBtb2RlIFNWSUQuCj4gPiA+IAo+ID4gPiBTdWdnZXN0ZWQtYnk6IEhlaWtraSBLcm9nZXJ1cyA8 aGVpa2tpLmtyb2dlcnVzQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gU2lnbmVkLW9mZi1ieTogQWph eSBHdXB0YSA8YWpheWdAbnZpZGlhLmNvbT4KPiA+ID4gU2lnbmVkLW9mZi1ieTogSGVpa2tpIEty b2dlcnVzIDxoZWlra2kua3JvZ2VydXNAbGludXguaW50ZWwuY29tPgo+ID4gPiAtLS0KPiA+ID4g IGRyaXZlcnMvdXNiL3R5cGVjL2FsdG1vZGVzL2Rpc3BsYXlwb3J0LmMgfCAxMiArKysrKysrLS0t LS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0p Cj4gPiBMb29rcyBsaWtlIHlvdSBtaXNzZWQgYWRkaW5nIGRpc3BsYXlwb3J0LmggZmlsZS4gSXQg aXMgYXZhaWxhYmxlIGluIG9yaWdpbmFsIHBhdGNoIGJlbG93LAo+ID4gIGh0dHBzOi8vbWFyYy5p bmZvLz9sPWxpbnV4LXVzYiZtPTE1NTQ5MjU4NzIyNDM3OSZ3PTIgCj4gCj4gVGhhdCdzIHRoZSBv bmUgSSBwaWNrZWQsIGFuZCBJIGRpZCBjb21waWxlIHRoZSBkcml2ZXIgYXMgd2VsbC4uIEknbQo+ IG5vdCBzdXJlIHdoYXQgSSd2ZSBkb25lLCBidXQgSSdsbCByZXNlbmQgdGhlIHNlcmllcy4KCkl0 IGxvb2tzIGxpa2UgSSBicm9rZSB0aGUgcGF0Y2ggYWZ0ZXIgSSBkaWQgYSBzbWFsbCBtb2RpZmlj YXRpb24gdG8KaXQuIEkgaGFkIGNoYW5nZWQgeW91ciAiRnJvbSIgYWRkcmVzcyBzbyBpdCBtYXRj aGVzIHlvdXIgc2luZ2VkLW9mLWJ5CmFkZHJlc3MuIE15IGNvbXBpbGUgdGVzdCBwYXNzZWQgYmVj YXVzZSB0aGUgaGVhZGVyIHdhcyBhbiB1bnRyYWNrZWQKZmlsZSA6LSkKClNvcnJ5IGFnYWluLiBM ZXQncyBkbyBvbmUgbW9yZSB0ZXN0IHJvdW5kLCBhbmQgcmVzZW5kLgoKdGhhbmtzLAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21A35C10F13 for ; Tue, 16 Apr 2019 07:46:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA4CC2073F for ; Tue, 16 Apr 2019 07:46:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728169AbfDPHqL (ORCPT ); Tue, 16 Apr 2019 03:46:11 -0400 Received: from mga12.intel.com ([192.55.52.136]:5454 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726775AbfDPHqK (ORCPT ); Tue, 16 Apr 2019 03:46:10 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 00:46:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,355,1549958400"; d="scan'208";a="165132433" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 16 Apr 2019 00:46:08 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 16 Apr 2019 10:46:07 +0300 Date: Tue, 16 Apr 2019 10:46:07 +0300 From: Heikki Krogerus To: Ajay Gupta Cc: Greg Kroah-Hartman , "linux-usb@vger.kernel.org" Subject: Re: [PATCH v2 6/7] usb: typec: displayport: Export probe and remove functions Message-ID: <20190416074607.GC1747@kuha.fi.intel.com> References: <20190415120931.61328-1-heikki.krogerus@linux.intel.com> <20190415120931.61328-7-heikki.krogerus@linux.intel.com> <20190416062703.GA1747@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190416062703.GA1747@kuha.fi.intel.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190416074607.NoLhTu7Wn9uu_c173_sUoJ6S2n4NvgmtpGatYxoYa5Q@z> On Tue, Apr 16, 2019 at 09:27:03AM +0300, Heikki Krogerus wrote: > On Tue, Apr 16, 2019 at 12:45:12AM +0000, Ajay Gupta wrote: > > Hi Heikki, > > > > > -----Original Message----- > > > From: linux-usb-owner@vger.kernel.org On > > > Behalf Of Heikki Krogerus > > > Sent: Monday, April 15, 2019 5:10 AM > > > To: Greg Kroah-Hartman > > > Cc: Ajay Gupta ; linux-usb@vger.kernel.org > > > Subject: [PATCH v2 6/7] usb: typec: displayport: Export probe and remove > > > functions > > > > > > From: Ajay Gupta > > > > > > VirtualLink standard extends the DisplayPort Alt Mode by utilizing also the USB 2 > > > pins on the USB Type-C connector. > > > It uses the same messages as DisplayPort, but not the DP SVID. At the time of > > > writing, USB IF has not assigned a Standard ID (SID) for VirtualLink, so the > > > manufacturers of VirtualLink adapters use their Vendor IDs as the SVID. > > > > > > Since the SVID specific communication is exactly the same as with DisplayPort > > > alternate mode, there is no need to implement separate driver for VirtualLink. > > > We'll handle the current VirtualLink adapters with probe drivers, and once there > > > is SVID assigned for it, we add it to the displayport alt mode driver. > > > > > > To support probing drivers, exporting the probe and remove functions, and also > > > changing the DP_HEADER helper macro to use the SVID of the alternate mode > > > device instead of the DisplayPort alt mode SVID. > > > > > > Suggested-by: Heikki Krogerus > > > Signed-off-by: Ajay Gupta > > > Signed-off-by: Heikki Krogerus > > > --- > > > drivers/usb/typec/altmodes/displayport.c | 12 +++++++----- > > > 1 file changed, 7 insertions(+), 5 deletions(-) > > Looks like you missed adding displayport.h file. It is available in original patch below, > > https://marc.info/?l=linux-usb&m=155492587224379&w=2 > > That's the one I picked, and I did compile the driver as well.. I'm > not sure what I've done, but I'll resend the series. It looks like I broke the patch after I did a small modification to it. I had changed your "From" address so it matches your singed-of-by address. My compile test passed because the header was an untracked file :-) Sorry again. Let's do one more test round, and resend. thanks, -- heikki