From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:35094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGJVV-0002rv-0a for qemu-devel@nongnu.org; Tue, 16 Apr 2019 04:31:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGJVT-0006Fc-VX for qemu-devel@nongnu.org; Tue, 16 Apr 2019 04:31:56 -0400 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:35768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGJVT-0006CT-Ir for qemu-devel@nongnu.org; Tue, 16 Apr 2019 04:31:55 -0400 Received: by mail-pg1-x52f.google.com with SMTP id g8so9991863pgf.2 for ; Tue, 16 Apr 2019 01:31:55 -0700 (PDT) From: Richard Henderson Date: Mon, 15 Apr 2019 22:31:48 -1000 Message-Id: <20190416083150.19649-1-richard.henderson@linaro.org> Subject: [Qemu-devel] [PATCH 0/2] tcg: Fix launchpad 1824853 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org This is a case where we generate more than 64k code for a mere 231 guest instructions. This hits some assertions within TCG that we're not overflowing the uint16_t that we use for representing our unwind info. Fix this by returning an error indication, rather than asserting. This lets us try again from tb_gen_code with a lower max_insns. This should resolve the problem for x86 as a host. There are other failure modes wrt out-of-range relocations that might affect the RISC hosts. I'm going to leave those for a different patch set. r~ Richard Henderson (2): tcg: Hoist max_insns computation to tb_gen_code tcg: Restart after TB code generation overflow include/exec/exec-all.h | 4 +-- include/exec/translator.h | 3 +- accel/tcg/translate-all.c | 54 +++++++++++++++++++++++++++++------ accel/tcg/translator.c | 15 ++-------- target/alpha/translate.c | 4 +-- target/arm/translate.c | 4 +-- target/cris/translate.c | 10 +------ target/hppa/translate.c | 5 ++-- target/i386/translate.c | 4 +-- target/lm32/translate.c | 10 +------ target/m68k/translate.c | 4 +-- target/microblaze/translate.c | 10 +------ target/mips/translate.c | 4 +-- target/moxie/translate.c | 11 ++----- target/nios2/translate.c | 14 ++------- target/openrisc/translate.c | 4 +-- target/ppc/translate.c | 4 +-- target/riscv/translate.c | 4 +-- target/s390x/translate.c | 4 +-- target/sh4/translate.c | 4 +-- target/sparc/translate.c | 4 +-- target/tilegx/translate.c | 12 +------- target/tricore/translate.c | 16 ++--------- target/unicore32/translate.c | 10 +------ target/xtensa/translate.c | 4 +-- tcg/tcg.c | 4 +++ 26 files changed, 93 insertions(+), 133 deletions(-) -- 2.17.1