From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH] nvmem: core: add NVMEM_SYSFS Kconfig Date: Tue, 16 Apr 2019 12:34:54 +0300 Message-ID: <20190416093454.GN2654@lahna.fi.intel.com> References: <20190415164011.2638-1-srinivas.kandagatla@linaro.org> <3a66797d-347d-2414-14e1-edbcd7c39ae8@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <3a66797d-347d-2414-14e1-edbcd7c39ae8@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Gaurav Kohli Cc: Srinivas Kandagatla , gregkh@linuxfoundation.org, maxime.ripard@bootlin.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On Tue, Apr 16, 2019 at 10:49:22AM +0530, Gaurav Kohli wrote: > Hi Srinivas, > > Thanks for the patch, > By default NVMEM_SYSFS should be set true, those whose don't want they can > disable the same. > > If we go with disable option, there are chances of eeprom may break in below > case: > > if (config->compat) { > rval = nvmem_sysfs_setup_compat(nvmem, config); -> this will > return error as config is disabled. > if (rval) > goto err_device_del; > } I also think this may cause problems with Thunderbolt devices because the upgradeable NVM is exposed to the userspace via these sysfs files and those are being used by fwupd. If the files disappear it makes NVM upgrade somewhat harder ;-) At least it would be good to include following as part of this series if you plan to disable the sysfs entries by default: diff --git a/drivers/thunderbolt/Kconfig b/drivers/thunderbolt/Kconfig index f4869c38c7e4..dd5facab0af2 100644 --- a/drivers/thunderbolt/Kconfig +++ b/drivers/thunderbolt/Kconfig @@ -7,6 +7,7 @@ menuconfig THUNDERBOLT select CRYPTO select CRYPTO_HASH select NVMEM + select NVMEM_SYSFS help Thunderbolt Controller driver. This driver is required if you want to hotplug Thunderbolt devices on Apple hardware or on PCs