From: Petri Latvala <petri.latvala@intel.com>
To: "Ser, Simon" <simon.ser@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] runner/job_list: print error when job list is empty
Date: Tue, 16 Apr 2019 12:56:58 +0300 [thread overview]
Message-ID: <20190416095658.GK22949@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <96da33a9733551056af386be61df22d86296668e.camel@intel.com>
On Mon, Apr 15, 2019 at 05:29:25PM +0300, Ser, Simon wrote:
> On Mon, 2019-03-25 at 15:59 +0200, Petri Latvala wrote:
> > An actual comment: We use the kernel coding style, so one-liner if
> > blocks should omit the braces. (Probably still a ton of violations of
> > this in runner/*...)
> >
> > With that,
> >
> > Reviewed-by: Petri Latvala <petri.latvala@intel.com>
>
> Hi Petri,
>
> Do you want me to send a v2 with this fixed?
Nah, I fixed it up and merged the patch. Sorry for leaving you hanging.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-04-16 9:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 12:44 [igt-dev] [PATCH i-g-t] runner/job_list: print error when job list is empty Simon Ser
2019-03-21 13:22 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-22 2:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-25 11:19 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2019-03-25 13:51 ` Ser, Simon
2019-03-25 13:59 ` Petri Latvala
2019-04-15 14:29 ` Ser, Simon
2019-04-16 9:56 ` Petri Latvala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416095658.GK22949@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=simon.ser@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.