From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,6/7] usb: typec: displayport: Export probe and remove functions From: Greg Kroah-Hartman Message-Id: <20190416100311.GF896@kroah.com> Date: Tue, 16 Apr 2019 12:03:11 +0200 To: Heikki Krogerus Cc: Ajay Gupta , "linux-usb@vger.kernel.org" List-ID: T24gVHVlLCBBcHIgMTYsIDIwMTkgYXQgMTA6NDY6MDdBTSArMDMwMCwgSGVpa2tpIEtyb2dlcnVz IHdyb3RlOgo+IE9uIFR1ZSwgQXByIDE2LCAyMDE5IGF0IDA5OjI3OjAzQU0gKzAzMDAsIEhlaWtr aSBLcm9nZXJ1cyB3cm90ZToKPiA+IE9uIFR1ZSwgQXByIDE2LCAyMDE5IGF0IDEyOjQ1OjEyQU0g KzAwMDAsIEFqYXkgR3VwdGEgd3JvdGU6Cj4gPiA+IEhpIEhlaWtraSwKPiA+ID4gCj4gPiA+ID4g LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+ID4gPiBGcm9tOiBsaW51eC11c2Itb3duZXJA dmdlci5rZXJuZWwub3JnIDxsaW51eC11c2Itb3duZXJAdmdlci5rZXJuZWwub3JnPiBPbgo+ID4g PiA+IEJlaGFsZiBPZiBIZWlra2kgS3JvZ2VydXMKPiA+ID4gPiBTZW50OiBNb25kYXksIEFwcmls IDE1LCAyMDE5IDU6MTAgQU0KPiA+ID4gPiBUbzogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hA bGludXhmb3VuZGF0aW9uLm9yZz4KPiA+ID4gPiBDYzogQWpheSBHdXB0YSA8YWpheWdAbnZpZGlh LmNvbT47IGxpbnV4LXVzYkB2Z2VyLmtlcm5lbC5vcmcKPiA+ID4gPiBTdWJqZWN0OiBbUEFUQ0gg djIgNi83XSB1c2I6IHR5cGVjOiBkaXNwbGF5cG9ydDogRXhwb3J0IHByb2JlIGFuZCByZW1vdmUK PiA+ID4gPiBmdW5jdGlvbnMKPiA+ID4gPiAKPiA+ID4gPiBGcm9tOiBBamF5IEd1cHRhIDxhamF5 Z0BudmlkaWEuY29tPgo+ID4gPiA+IAo+ID4gPiA+IFZpcnR1YWxMaW5rIHN0YW5kYXJkIGV4dGVu ZHMgdGhlIERpc3BsYXlQb3J0IEFsdCBNb2RlIGJ5IHV0aWxpemluZyBhbHNvIHRoZSBVU0IgMgo+ ID4gPiA+IHBpbnMgb24gdGhlIFVTQiBUeXBlLUMgY29ubmVjdG9yLgo+ID4gPiA+IEl0IHVzZXMg dGhlIHNhbWUgbWVzc2FnZXMgYXMgRGlzcGxheVBvcnQsIGJ1dCBub3QgdGhlIERQIFNWSUQuIEF0 IHRoZSB0aW1lIG9mCj4gPiA+ID4gd3JpdGluZywgVVNCIElGIGhhcyBub3QgYXNzaWduZWQgYSBT dGFuZGFyZCBJRCAoU0lEKSBmb3IgVmlydHVhbExpbmssIHNvIHRoZQo+ID4gPiA+IG1hbnVmYWN0 dXJlcnMgb2YgVmlydHVhbExpbmsgYWRhcHRlcnMgdXNlIHRoZWlyIFZlbmRvciBJRHMgYXMgdGhl IFNWSUQuCj4gPiA+ID4gCj4gPiA+ID4gU2luY2UgdGhlIFNWSUQgc3BlY2lmaWMgY29tbXVuaWNh dGlvbiBpcyBleGFjdGx5IHRoZSBzYW1lIGFzIHdpdGggRGlzcGxheVBvcnQKPiA+ID4gPiBhbHRl cm5hdGUgbW9kZSwgdGhlcmUgaXMgbm8gbmVlZCB0byBpbXBsZW1lbnQgc2VwYXJhdGUgZHJpdmVy IGZvciBWaXJ0dWFsTGluay4KPiA+ID4gPiBXZSdsbCBoYW5kbGUgdGhlIGN1cnJlbnQgVmlydHVh bExpbmsgYWRhcHRlcnMgd2l0aCBwcm9iZSBkcml2ZXJzLCBhbmQgb25jZSB0aGVyZQo+ID4gPiA+ IGlzIFNWSUQgYXNzaWduZWQgZm9yIGl0LCB3ZSBhZGQgaXQgdG8gdGhlIGRpc3BsYXlwb3J0IGFs dCBtb2RlIGRyaXZlci4KPiA+ID4gPiAKPiA+ID4gPiBUbyBzdXBwb3J0IHByb2JpbmcgZHJpdmVy cywgZXhwb3J0aW5nIHRoZSBwcm9iZSBhbmQgcmVtb3ZlIGZ1bmN0aW9ucywgYW5kIGFsc28KPiA+ ID4gPiBjaGFuZ2luZyB0aGUgRFBfSEVBREVSIGhlbHBlciBtYWNybyB0byB1c2UgdGhlIFNWSUQg b2YgdGhlIGFsdGVybmF0ZSBtb2RlCj4gPiA+ID4gZGV2aWNlIGluc3RlYWQgb2YgdGhlIERpc3Bs YXlQb3J0IGFsdCBtb2RlIFNWSUQuCj4gPiA+ID4gCj4gPiA+ID4gU3VnZ2VzdGVkLWJ5OiBIZWlr a2kgS3JvZ2VydXMgPGhlaWtraS5rcm9nZXJ1c0BsaW51eC5pbnRlbC5jb20+Cj4gPiA+ID4gU2ln bmVkLW9mZi1ieTogQWpheSBHdXB0YSA8YWpheWdAbnZpZGlhLmNvbT4KPiA+ID4gPiBTaWduZWQt b2ZmLWJ5OiBIZWlra2kgS3JvZ2VydXMgPGhlaWtraS5rcm9nZXJ1c0BsaW51eC5pbnRlbC5jb20+ Cj4gPiA+ID4gLS0tCj4gPiA+ID4gIGRyaXZlcnMvdXNiL3R5cGVjL2FsdG1vZGVzL2Rpc3BsYXlw b3J0LmMgfCAxMiArKysrKysrLS0tLS0KPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0 aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiA+ID4gTG9va3MgbGlrZSB5b3UgbWlzc2VkIGFkZGlu ZyBkaXNwbGF5cG9ydC5oIGZpbGUuIEl0IGlzIGF2YWlsYWJsZSBpbiBvcmlnaW5hbCBwYXRjaCBi ZWxvdywKPiA+ID4gIGh0dHBzOi8vbWFyYy5pbmZvLz9sPWxpbnV4LXVzYiZtPTE1NTQ5MjU4NzIy NDM3OSZ3PTIgCj4gPiAKPiA+IFRoYXQncyB0aGUgb25lIEkgcGlja2VkLCBhbmQgSSBkaWQgY29t cGlsZSB0aGUgZHJpdmVyIGFzIHdlbGwuLiBJJ20KPiA+IG5vdCBzdXJlIHdoYXQgSSd2ZSBkb25l LCBidXQgSSdsbCByZXNlbmQgdGhlIHNlcmllcy4KPiAKPiBJdCBsb29rcyBsaWtlIEkgYnJva2Ug dGhlIHBhdGNoIGFmdGVyIEkgZGlkIGEgc21hbGwgbW9kaWZpY2F0aW9uIHRvCj4gaXQuIEkgaGFk IGNoYW5nZWQgeW91ciAiRnJvbSIgYWRkcmVzcyBzbyBpdCBtYXRjaGVzIHlvdXIgc2luZ2VkLW9m LWJ5Cj4gYWRkcmVzcy4gTXkgY29tcGlsZSB0ZXN0IHBhc3NlZCBiZWNhdXNlIHRoZSBoZWFkZXIg d2FzIGFuIHVudHJhY2tlZAo+IGZpbGUgOi0pCj4gCj4gU29ycnkgYWdhaW4uIExldCdzIGRvIG9u ZSBtb3JlIHRlc3Qgcm91bmQsIGFuZCByZXNlbmQuCgpPaywgZHJvcHBpbmcgdGhpcyB3aG9sZSBz ZXJpZXMgZnJvbSBteSBxdWV1ZSBub3csIHRoYW5rcy4KCmdyZWcgay1oCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE007C10F14 for ; Tue, 16 Apr 2019 10:38:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D6BB206BA for ; Tue, 16 Apr 2019 10:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555411123; bh=WgE7GxQCPAoAeSfcGJZwt/noavHnmekZn95eyaMWz58=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=puPBig5FpmAFLLunsVSugV1pd6Dev48f4QCyd5KOp++u4LoihthuiY3HFFA36d0+h FennuWZMEpeDIwdzz9tsFG1NrdZs6zO7Pv+OYJ8TYz09PCxAyuyobjOgQo5fp7vi6v ewknlq3qeBzeuxCr+ogLGGgA14DK2wGd3GQaWP7Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728734AbfDPKim (ORCPT ); Tue, 16 Apr 2019 06:38:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:57288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726682AbfDPKil (ORCPT ); Tue, 16 Apr 2019 06:38:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8C334206BA; Tue, 16 Apr 2019 10:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555411121; bh=WgE7GxQCPAoAeSfcGJZwt/noavHnmekZn95eyaMWz58=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HQF0uNLvP8yUoepZ/oHJ43oGbCv2dwF97CeGqnsRWGpKaH1wYzE2nn/WXX/66cD+H GR8Elzle02US9hrD3D+ASRPfZtxqHIW5oizCjg5G3FN+VF8NMfCovz+If9JPZSfROi 5yYStVFNSSk/84DUVeWHZZyeIMj3XUBgZ4YnbNGc= Date: Tue, 16 Apr 2019 12:03:11 +0200 From: Greg Kroah-Hartman To: Heikki Krogerus Cc: Ajay Gupta , "linux-usb@vger.kernel.org" Subject: Re: [PATCH v2 6/7] usb: typec: displayport: Export probe and remove functions Message-ID: <20190416100311.GF896@kroah.com> References: <20190415120931.61328-1-heikki.krogerus@linux.intel.com> <20190415120931.61328-7-heikki.krogerus@linux.intel.com> <20190416062703.GA1747@kuha.fi.intel.com> <20190416074607.GC1747@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190416074607.GC1747@kuha.fi.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190416100311.0sgK4ztF3aWSUSWtpS4TOvvPCVt9DUPOAUZC8__CUIY@z> On Tue, Apr 16, 2019 at 10:46:07AM +0300, Heikki Krogerus wrote: > On Tue, Apr 16, 2019 at 09:27:03AM +0300, Heikki Krogerus wrote: > > On Tue, Apr 16, 2019 at 12:45:12AM +0000, Ajay Gupta wrote: > > > Hi Heikki, > > > > > > > -----Original Message----- > > > > From: linux-usb-owner@vger.kernel.org On > > > > Behalf Of Heikki Krogerus > > > > Sent: Monday, April 15, 2019 5:10 AM > > > > To: Greg Kroah-Hartman > > > > Cc: Ajay Gupta ; linux-usb@vger.kernel.org > > > > Subject: [PATCH v2 6/7] usb: typec: displayport: Export probe and remove > > > > functions > > > > > > > > From: Ajay Gupta > > > > > > > > VirtualLink standard extends the DisplayPort Alt Mode by utilizing also the USB 2 > > > > pins on the USB Type-C connector. > > > > It uses the same messages as DisplayPort, but not the DP SVID. At the time of > > > > writing, USB IF has not assigned a Standard ID (SID) for VirtualLink, so the > > > > manufacturers of VirtualLink adapters use their Vendor IDs as the SVID. > > > > > > > > Since the SVID specific communication is exactly the same as with DisplayPort > > > > alternate mode, there is no need to implement separate driver for VirtualLink. > > > > We'll handle the current VirtualLink adapters with probe drivers, and once there > > > > is SVID assigned for it, we add it to the displayport alt mode driver. > > > > > > > > To support probing drivers, exporting the probe and remove functions, and also > > > > changing the DP_HEADER helper macro to use the SVID of the alternate mode > > > > device instead of the DisplayPort alt mode SVID. > > > > > > > > Suggested-by: Heikki Krogerus > > > > Signed-off-by: Ajay Gupta > > > > Signed-off-by: Heikki Krogerus > > > > --- > > > > drivers/usb/typec/altmodes/displayport.c | 12 +++++++----- > > > > 1 file changed, 7 insertions(+), 5 deletions(-) > > > Looks like you missed adding displayport.h file. It is available in original patch below, > > > https://marc.info/?l=linux-usb&m=155492587224379&w=2 > > > > That's the one I picked, and I did compile the driver as well.. I'm > > not sure what I've done, but I'll resend the series. > > It looks like I broke the patch after I did a small modification to > it. I had changed your "From" address so it matches your singed-of-by > address. My compile test passed because the header was an untracked > file :-) > > Sorry again. Let's do one more test round, and resend. Ok, dropping this whole series from my queue now, thanks. greg k-h