From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v7] drm/i915/icl: Fix clockgating issue when
 using scalers
Date: Tue, 16 Apr 2019 17:14:04 +0300
Message-ID: <20190416141404.GH24299@intel.com>
References: <20190412072503.GG3888@intel.com>
 <20190415225519.29643-1-radhakrishna.sripada@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id A1C8C89CB3
 for <intel-gfx@lists.freedesktop.org>; Tue, 16 Apr 2019 14:14:08 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190415225519.29643-1-radhakrishna.sripada@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBBcHIgMTUsIDIwMTkgYXQgMDM6NTU6MTlQTSAtMDcwMCwgUmFkaGFrcmlzaG5hIFNy
aXBhZGEgd3JvdGU6Cj4gRml4ZXMgdGhlIGNsb2NrLWdhdGluZyBpc3N1ZSB3aGVuIHBpcGUgc2Nh
bGluZyBpcyBlbmFibGVkLgo+IChMaW5lYWdlICMyMDA2NjA0MzEyKQo+IAo+IFYyOiBGaXggdHlw
byBpbiBoZWFkbGluZShDaHJpcykKPiAgICAgSGFuZGxlIHRoZSBub24gZG91YmxlIGJ1ZmZlcmVk
IG5hdHVyZSBvZiB0aGUgcmVnaXN0ZXIoVmlsbGUpCj4gVjM6IEZpeCBjaGVja3BhdGNoIHdhcm5p
bmcuIEJBVCBmYWlsdXJlIGZvciBWMiBvbiBnZW4zIGxvb2tzIHVucmVsYXRlZC4KPiBWNDogU3Bs
aXQgdGhlIGljbCBhbmQgc2tsIHdhJ3MoVmlsbGUpCj4gVjU6IFNwbGl0IHRoZSBjaGVja3MgZm9y
IGljbCBhbmQgc2tsKFZpbGxlKQo+IFY2OiBDb3JyZWN0IHRoZSBmbGlwcGVkIGNoZWNrcyBpbiBp
bnRlbF9wcmVfcGxhbmVfdXBkYXRlKFZpbGxlKQo+IFY3OiBVc2UgZW51bSBmb3IgcGlwZSBhbmQg
ZXh0ZW5kIHRoZSBXQSBmb3IgcGxhbmUgc2NhbGVycyhWaWxsZSkKPiAKPiBDYzogQ2hyaXMgV2ls
c29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IFZpbGxlIFN5cmphbGEgPHZpbGxl
LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2
aUBpbnRlbC5jb20+Cj4gQ2M6IENsaW50IFRheWxvciA8Y2xpbnRvbi5hLnRheWxvckBpbnRlbC5j
b20+Cj4gU2lnbmVkLW9mZi1ieTogUmFkaGFrcmlzaG5hIFNyaXBhZGEgPHJhZGhha3Jpc2huYS5z
cmlwYWRhQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz
cGxheS5jIHwgNDIgKysrKysrKysrKysrKysrKysrKysrKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdl
ZCwgMzcgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfZGlzcGxheS5jCj4gaW5kZXggM2JkNDBhNGE2NzM5Li42ZjY4ZDAzOWFiNDcgMTAwNjQ0
Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTQ3Niw2ICs0NzYsNyBAQCBz
dGF0aWMgY29uc3Qgc3RydWN0IGludGVsX2xpbWl0IGludGVsX2xpbWl0c19ieHQgPSB7Cj4gIAku
cDIgPSB7IC5wMl9zbG93ID0gMSwgLnAyX2Zhc3QgPSAyMCB9LAo+ICB9Owo+ICAKPiArLyogV0Eg
RGlzcGxheSAjMDgyNzogR2VuOTphbGwgKi8KPiAgc3RhdGljIHZvaWQKPiAgc2tsX3dhXzgyNyhz
dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGludCBwaXBlLCBib29sIGVuYWJsZSkK
PiAgewo+IEBAIC00ODksNiArNDkwLDE5IEBAIHNrbF93YV84Mjcoc3RydWN0IGRybV9pOTE1X3By
aXZhdGUgKmRldl9wcml2LCBpbnQgcGlwZSwgYm9vbCBlbmFibGUpCj4gIAkJCSAgIH4oRFVQUzFf
R0FUSU5HX0RJUyB8IERVUFMyX0dBVElOR19ESVMpKTsKPiAgfQo+ICAKPiArLyogV2FfMjAwNjYw
NDMxMjppY2wgKi8KPiArc3RhdGljIHZvaWQKPiAraWNsX3dhX3NjYWxlcmNsa2dhdGluZyhzdHJ1
Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gcGlwZSBwaXBlLAo+ICsJCSAgICAg
ICBib29sIGVuYWJsZSkKPiArewo+ICsJaWYgKGVuYWJsZSkKPiArCQlJOTE1X1dSSVRFKENMS0dB
VEVfRElTX1BTTChwaXBlKSwKPiArCQkJICAgSTkxNV9SRUFEKENMS0dBVEVfRElTX1BTTChwaXBl
KSkgfCBEUEZSX0dBVElOR19ESVMpOwo+ICsJZWxzZQo+ICsJCUk5MTVfV1JJVEUoQ0xLR0FURV9E
SVNfUFNMKHBpcGUpLAo+ICsJCQkgICBJOTE1X1JFQUQoQ0xLR0FURV9ESVNfUFNMKHBpcGUpKSAm
IH5EUEZSX0dBVElOR19ESVMpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgYm9vbAo+ICBuZWVkc19tb2Rl
c2V0KGNvbnN0IHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqc3RhdGUpCj4gIHsKPiBAQCAtNTUwNSw2
ICs1NTE5LDE4IEBAIHN0YXRpYyBib29sIG5lZWRzX252MTJfd2Eoc3RydWN0IGRybV9pOTE1X3By
aXZhdGUgKmRldl9wcml2LAo+ICAJcmV0dXJuIGZhbHNlOwo+ICB9Cj4gIAo+ICtzdGF0aWMgYm9v
bCBuZWVkc19zY2FsZXJjbGtfd2Eoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+
ICsJCQkgICAgICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4g
K3sKPiArCS8qIFdhXzIwMDY2MDQzMTI6aWNsICovCj4gKwlpZiAoSVNfSUNFTEFLRShkZXZfcHJp
dikgJiYKPiArCSAgICAoY3J0Y19zdGF0ZS0+cGNoX3BmaXQuZW5hYmxlZCB8fAoKSSBkb24ndCB0
aGluayB3ZSBuZWVkIHRoZSBwZml0IGNoZWNrIGFueW1vcmUuIHNjYWxlcl91c2VycyBzaG91bGQK
YWNjb3VudCBmb3IgdGhhdD8KCj4gKwkgICAgIGNydGNfc3RhdGUtPnNjYWxlcl9zdGF0ZS5zY2Fs
ZXJfdXNlcnMgPiAwKSkKPiArCQlyZXR1cm4gdHJ1ZTsKPiArCj4gKwlyZXR1cm4gZmFsc2U7Cj4g
K30KPiArCj4gIHN0YXRpYyB2b2lkIGludGVsX3Bvc3RfcGxhbmVfdXBkYXRlKHN0cnVjdCBpbnRl
bF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSkKPiAgewo+ICAJc3RydWN0IGludGVsX2NydGMg
KmNydGMgPSB0b19pbnRlbF9jcnRjKG9sZF9jcnRjX3N0YXRlLT5iYXNlLmNydGMpOwo+IEBAIC01
NTM4LDExICs1NTY0LDEzIEBAIHN0YXRpYyB2b2lkIGludGVsX3Bvc3RfcGxhbmVfdXBkYXRlKHN0
cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSkKPiAgCQkJaW50ZWxfcG9zdF9l
bmFibGVfcHJpbWFyeSgmY3J0Yy0+YmFzZSwgcGlwZV9jb25maWcpOwo+ICAJfQo+ICAKPiAtCS8q
IERpc3BsYXkgV0EgODI3ICovCj4gIAlpZiAobmVlZHNfbnYxMl93YShkZXZfcHJpdiwgb2xkX2Ny
dGNfc3RhdGUpICYmCj4gLQkgICAgIW5lZWRzX252MTJfd2EoZGV2X3ByaXYsIHBpcGVfY29uZmln
KSkgewo+ICsJICAgICFuZWVkc19udjEyX3dhKGRldl9wcml2LCBwaXBlX2NvbmZpZykpCj4gIAkJ
c2tsX3dhXzgyNyhkZXZfcHJpdiwgY3J0Yy0+cGlwZSwgZmFsc2UpOwo+IC0JfQo+ICsKPiArCWlm
IChuZWVkc19zY2FsZXJjbGtfd2EoZGV2X3ByaXYsIG9sZF9jcnRjX3N0YXRlKSAmJgo+ICsJICAg
ICFuZWVkc19zY2FsZXJjbGtfd2EoZGV2X3ByaXYsIHBpcGVfY29uZmlnKSkKPiArCQlpY2xfd2Ff
c2NhbGVyY2xrZ2F0aW5nKGRldl9wcml2LCBjcnRjLT5waXBlLCBmYWxzZSk7Cj4gIH0KPiAgCj4g
IHN0YXRpYyB2b2lkIGludGVsX3ByZV9wbGFuZV91cGRhdGUoc3RydWN0IGludGVsX2NydGNfc3Rh
dGUgKm9sZF9jcnRjX3N0YXRlLAo+IEBAIC01NTc5LDkgKzU2MDcsMTMgQEAgc3RhdGljIHZvaWQg
aW50ZWxfcHJlX3BsYW5lX3VwZGF0ZShzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNf
c3RhdGUsCj4gIAo+ICAJLyogRGlzcGxheSBXQSA4MjcgKi8KPiAgCWlmICghbmVlZHNfbnYxMl93
YShkZXZfcHJpdiwgb2xkX2NydGNfc3RhdGUpICYmCj4gLQkgICAgbmVlZHNfbnYxMl93YShkZXZf
cHJpdiwgcGlwZV9jb25maWcpKSB7Cj4gKwkgICAgbmVlZHNfbnYxMl93YShkZXZfcHJpdiwgcGlw
ZV9jb25maWcpKQo+ICAJCXNrbF93YV84MjcoZGV2X3ByaXYsIGNydGMtPnBpcGUsIHRydWUpOwo+
IC0JfQo+ICsKPiArCS8qIFdhXzIwMDY2MDQzMTI6aWNsICovCj4gKwlpZiAoIW5lZWRzX3NjYWxl
cmNsa193YShkZXZfcHJpdiwgb2xkX2NydGNfc3RhdGUpICYmCj4gKwkgICAgbmVlZHNfc2NhbGVy
Y2xrX3dhKGRldl9wcml2LCBwaXBlX2NvbmZpZykpCj4gKwkJaWNsX3dhX3NjYWxlcmNsa2dhdGlu
ZyhkZXZfcHJpdiwgY3J0Yy0+cGlwZSwgdHJ1ZSk7Cj4gIAo+ICAJLyoKPiAgCSAqIFZibGFuayB0
aW1lIHVwZGF0ZXMgZnJvbSB0aGUgc2hhZG93IHRvIGxpdmUgcGxhbmUgY29udHJvbCByZWdpc3Rl
cgo+IC0tIAo+IDIuMjAuMC5yYzIuNy5nOTY1Nzk4ZDFmMjk5CgotLSAKVmlsbGUgU3lyasOkbMOk
CkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu
dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw
czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==