From: Andrew Morton <akpm@linux-foundation.org>
To: Aubrey Li <aubrey.li@linux.intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, peterz@infradead.org,
hpa@zytor.com, ak@linux.intel.com, tim.c.chen@linux.intel.com,
dave.hansen@intel.com, arjan@linux.intel.com,
adobriyan@gmail.com, aubrey.li@intel.com,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v15 1/3] /proc/pid/status: Add support for architecture specific output
Date: Tue, 16 Apr 2019 16:01:43 -0700 [thread overview]
Message-ID: <20190416160143.8292ced993dc803aae7fa0da@linux-foundation.org> (raw)
In-Reply-To: <20190416063250.7514-1-aubrey.li@linux.intel.com>
On Tue, 16 Apr 2019 14:32:48 +0800 Aubrey Li <aubrey.li@linux.intel.com> wrote:
> The architecture specific information of the running processes could
> be useful to the userland. Add support to examine process architecture
> specific information externally.
The implementation looks just fine to me. Have you had any feedback on
the overall desirability of adding this feature?
> --- a/fs/proc/array.c
> +++ b/fs/proc/array.c
> @@ -96,6 +96,11 @@
> #include <asm/processor.h>
> #include "internal.h"
>
> +/* Add support for architecture specific output in /proc/pid/status */
> +#ifndef arch_proc_pid_status
> +#define arch_proc_pid_status(m, task)
> +#endif
To this I suggest adding
/* arch_proc_pid_status() must be defined in asm/processor.h */
Because we've regularly had different architectures defining such things
in different headers, resulting in a mess.
next prev parent reply other threads:[~2019-04-16 23:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 6:32 [PATCH v15 1/3] /proc/pid/status: Add support for architecture specific output Aubrey Li
2019-04-16 6:32 ` [PATCH v15 2/3] x86,/proc/pid/status: Add AVX-512 usage elapsed time Aubrey Li
2019-04-16 6:32 ` [PATCH v15 3/3] Documentation/filesystems/proc.txt: add AVX512_elapsed_ms Aubrey Li
2019-04-16 23:01 ` Andrew Morton [this message]
2019-04-17 10:07 ` [PATCH v15 1/3] /proc/pid/status: Add support for architecture specific output Li, Aubrey
2019-04-17 19:45 ` Andy Lutomirski
2019-04-18 13:00 ` Thomas Gleixner
2019-04-19 11:42 ` Li, Aubrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416160143.8292ced993dc803aae7fa0da@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=aubrey.li@intel.com \
--cc=aubrey.li@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.