All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Douglas Anderson <dianders@chromium.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Jason Wessel <jason.wessel@windriver.com>,
	Christophe Leroy <christophe.leroy@c-s.fr>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Kees Cook <keescook@chromium.org>,
	kgdb-bugreport@lists.sourceforge.net,
	Johannes Weiner <hannes@cmpxchg.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Nicholas Mc Guire <hofrat@osadl.org>,
	Joe Perches <joe@perches.com>
Subject: Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary
Date: Tue, 16 Apr 2019 16:30:34 -0700	[thread overview]
Message-ID: <20190416163034.3e642818ebf27ed6891c1981@linux-foundation.org> (raw)
In-Reply-To: <CAK7LNARYMy2=viA1et9tZk409M=OSteD5D675oAKQEs6SG77HQ@mail.gmail.com>

On Thu, 11 Apr 2019 18:06:23 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> On Sat, Mar 23, 2019 at 10:55 AM Douglas Anderson <dianders@chromium.org> wrote:
> >
> > If you drop into kdb and type "summary", it prints out a line that
> > says this:
> >
> >   ccversion  CCVERSION
> >
> > ...and I don't mean that it actually prints out the version of the C
> > compiler.  It literally prints out the string "CCVERSION".
> >
> > The version of the C Compiler is already printed at boot up and it
> > doesn't seem useful to replicate this in kdb.  Let's just delete it.
> > We can also delete the bit of the Makefile that called the C compiler
> > in an attempt to pass this into kdb.  This will remove one extra call
> > to the C compiler at Makefile parse time and (very slightly) speed up
> > builds.
> >
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> 
> 
> I know you add lots of Cc: lines
> when you pick up patches, but I think
> your script can be improved.
> 
> You added "Cc: Douglas Anderson <dianders@chromium.org>",
> but Douglas is the author.
> I think the author should be excluded from Cc.

Whoops.

It's pretty benign: Doug will still only get a single email.


checkpatch checks for duplicates cc's but I think it assumes that
things like

Reported-by: fred
Tested-by: fred

were intentional.

It would perhaps be better for checkpatch to special-case the "Cc:
fred" tag and report a duplicated Cc: if fred was also mentioned in any
other tag.


  reply	other threads:[~2019-04-16 23:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-23  1:52 [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary Douglas Anderson
2019-03-30 12:14 ` Masahiro Yamada
2019-04-11  9:06 ` Masahiro Yamada
2019-04-16 23:30   ` Andrew Morton [this message]
2019-04-17  6:37     ` Masahiro Yamada
2019-04-18 23:06       ` Andrew Morton
2019-04-19  3:28         ` Masahiro Yamada
2019-04-19 11:14           ` Joe Perches
2019-04-19 20:58             ` Andrew Morton
2019-04-20  3:57               ` Joe Perches
2019-05-06 14:28             ` Masahiro Yamada
2019-05-07 13:55               ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190416163034.3e642818ebf27ed6891c1981@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=daniel.thompson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=gustavo@embeddedor.com \
    --cc=hannes@cmpxchg.org \
    --cc=hofrat@osadl.org \
    --cc=jason.wessel@windriver.com \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.