From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F122C282DC for ; Wed, 17 Apr 2019 03:38:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F06E21773 for ; Wed, 17 Apr 2019 03:38:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731132AbfDQDiq (ORCPT ); Tue, 16 Apr 2019 23:38:46 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:51846 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728508AbfDQDiq (ORCPT ); Tue, 16 Apr 2019 23:38:46 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hGbPB-0006NU-Ku; Wed, 17 Apr 2019 11:38:37 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hGbP8-00015Z-2U; Wed, 17 Apr 2019 11:38:34 +0800 Date: Wed, 17 Apr 2019 11:38:34 +0800 From: Herbert Xu To: Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= Cc: Johannes Berg , Arend Van Spriel , Felix Fietkau , linux-wireless@vger.kernel.org, Eric Dumazet , netdev@vger.kernel.org Subject: Re: [PATCH 5/5] mac80211: set NETIF_F_LLTX when using intermediate tx queues Message-ID: <20190417033834.ep6t7r6ttvjek5g7@gondor.apana.org.au> References: <20190416074444.pdubbh6fbibdnhi7@gondor.apana.org.au> <73b18131-2777-da5c-a6ee-9d9b3e13cd06@broadcom.com> <20190416083636.5ttvezqyhzr2worg@gondor.apana.org.au> <87ef62uwfm.fsf@toke.dk> <95f86cf69dee05a176625925657cf0df0e97b5c9.camel@sipsolutions.net> <20190416093707.dtlwcmitzqopaeaw@gondor.apana.org.au> <20190416131346.u2uolljlrd5t2jro@gondor.apana.org.au> <87wojut7f7.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87wojut7f7.fsf@toke.dk> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Apr 16, 2019 at 02:18:36PM +0100, Toke Høiland-Jørgensen wrote: > > > The congestion control happens at two levels. You are right that the > > socket buffer acts as one limit. However, other applications may also > > rely on the TX queue being full as the throttle (by setting a > > sufficiently large socket buffer size). > > Do you happen to have an example of an application that does this that > could be used for testing? :) Have a look at commit 6ce9e7b5fe3195d1ae6e3a0753d4ddcac5cd699e Author: Eric Dumazet Date: Wed Sep 2 18:05:33 2009 -0700 ip: Report qdisc packet drops You should be able to do a UDP flood while setting IP_RECVERR to detect the packet drop due to a full queue which AFAICS will never happen with the current mac80211 setup. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt